New issue
Advanced search Search tips

Issue 826304 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q2



Sign in to add a comment

Popup Menu: Add badges to tools menu items

Project Member Reported by gambard@chromium.org, Mar 27 2018

Issue description

Like today on the ReadingList entry, the tools menu items should have badges.
 
Status: Started (was: Assigned)
Labels: -Q1 Q2
Labels: -small large
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cb8ff4e6260da47ce6eeedf58970bc36dc890c6

commit 6cb8ff4e6260da47ce6eeedf58970bc36dc890c6
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Apr 03 16:06:05 2018

Add number and text badge to the tools menu items

This CL adds two badges, mutually exclusives, to the tools menu items.
Those badge can have text or number.

Bug:  826304 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I497c3332f12be2cd4869ab9857959ac87cfa81e4
Reviewed-on: https://chromium-review.googlesource.com/987894
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547723}
[modify] https://crrev.com/6cb8ff4e6260da47ce6eeedf58970bc36dc890c6/ios/chrome/browser/ui/popup_menu/cells/BUILD.gn
[modify] https://crrev.com/6cb8ff4e6260da47ce6eeedf58970bc36dc890c6/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.h
[modify] https://crrev.com/6cb8ff4e6260da47ce6eeedf58970bc36dc890c6/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.mm
[modify] https://crrev.com/6cb8ff4e6260da47ce6eeedf58970bc36dc890c6/ios/chrome/browser/ui/reading_list/number_badge_view.mm
[modify] https://crrev.com/6cb8ff4e6260da47ce6eeedf58970bc36dc890c6/ios/chrome/browser/ui/reading_list/text_badge_view.mm

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b14c4d31feba2de949a201cc5dd5efb005d558d8

commit b14c4d31feba2de949a201cc5dd5efb005d558d8
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Apr 04 12:00:49 2018

Add number of unread items to the tools menu

This CL adds the number of unread items in the ReadingList to the badge
associated with the ReadingList entry in the tools menu.

Bug:  826304 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id806406c1e1452793092afdefeb6937051e9bdaf
Reviewed-on: https://chromium-review.googlesource.com/992233
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548024}
[modify] https://crrev.com/b14c4d31feba2de949a201cc5dd5efb005d558d8/ios/chrome/browser/ui/popup_menu/BUILD.gn
[modify] https://crrev.com/b14c4d31feba2de949a201cc5dd5efb005d558d8/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.mm
[modify] https://crrev.com/b14c4d31feba2de949a201cc5dd5efb005d558d8/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[modify] https://crrev.com/b14c4d31feba2de949a201cc5dd5efb005d558d8/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.h
[modify] https://crrev.com/b14c4d31feba2de949a201cc5dd5efb005d558d8/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[modify] https://crrev.com/b14c4d31feba2de949a201cc5dd5efb005d558d8/ios/chrome/browser/ui/popup_menu/popup_menu_mediator_unittest.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in 67.0.3393.0 Canary, iPhone X iOS 11.3 beta 6, iPhone 6 iOS 10.3.3, iPhone 7 iOS11, iPad Pro iOS11

Number is added on Reading List icon in NTP.
Looks good.

Sign in to add a comment