New issue
Advanced search Search tips

Issue 826298 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Feature
Launch-Privacy: NotReviewed
Launch-Security: NotReviewed
Launch-UI: NotReviewed



Sign in to add a comment

New extensions API: enterprise.reportingPrivate.uploadChromeDesktopReport

Project Member Reported by georgesak@chromium.org, Mar 27 2018

Issue description

New Extension API Proposal

API Namespace: enterprise.reportingPrivate
API Owners: georgesak, zmin, mad, pastarmovj
API Overview Doc: https://docs.google.com/document/d/1YbGYeb1N4IWDZbdQf9LXTD4GPl9QLSqfVy8qfEC6CWE/edit#bookmark=id.3ag6xxvnlpl7
Design Doc: N/A
Supplementary Resources: This is part of the new Chrome Admin Panel integration effort by the enterprise team.
 
Cc: rdevlin....@chromium.org
Please see the process at https://chromium.googlesource.com/chromium/src/+/master/extensions/docs/new_api_proposal.md.  In particular, the API overview doc should be generated from the template there (what's linked here looks more like a supplementary design doc).  Additionally, the design doc linked describes three distinct APIs being changed reportingPrivate, metrics, and webRequest.  For clarity, I'd recommend we split these apart, so that it's clear what's being discussed in each, and so that we don't need to be block implementation on all of them if one is still being discussed.
Status: Assigned (was: Untriaged)
(bug triage)

Comment 3 Deleted

Comment 4 by zmin@chromium.org, Apr 4 2018

I have created a doc based on the template only for the reportingPrivate API, please take a look:

https://docs.google.com/document/d/10gVlhgW1LBS6YLL8df6vf-COT8-w-DT9MFykDPROC9c/edit?usp=sharing
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdada01a75db65126449561b8b7b62adb902efe8

commit fdada01a75db65126449561b8b7b62adb902efe8
Author: Owen Min <zmin@chromium.org>
Date: Fri Apr 13 04:36:23 2018

Create a new extension API for enterprise browser reporting.

It introduces new permission, IDL and skeleton of implementation.

This privacy API is used to upload browsers and devices status that
are collected by extension to the admin console.


Bug:  826298 
Change-Id: I60780d76c9e7680843acef38ce906e9cbe150025
Reviewed-on: https://chromium-review.googlesource.com/976819
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550521}
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/browser/extensions/BUILD.gn
[add] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/browser/extensions/api/enterprise_reporting_private/OWNERS
[add] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_api.cc
[add] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_api.h
[add] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_unittest.cc
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/common/extensions/api/BUILD.gn
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/common/extensions/api/_api_features.json
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/common/extensions/api/_permission_features.json
[add] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/common/extensions/api/enterprise_reporting_private.idl
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/common/extensions/permissions/chrome_api_permissions.cc
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/common/extensions/permissions/permission_set_unittest.cc
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/test/BUILD.gn
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/extensions/common/permissions/api_permission.h
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/tools/metrics/histograms/enums.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdada01a75db65126449561b8b7b62adb902efe8

commit fdada01a75db65126449561b8b7b62adb902efe8
Author: Owen Min <zmin@chromium.org>
Date: Fri Apr 13 04:36:23 2018

Create a new extension API for enterprise browser reporting.

It introduces new permission, IDL and skeleton of implementation.

This privacy API is used to upload browsers and devices status that
are collected by extension to the admin console.


Bug:  826298 
Change-Id: I60780d76c9e7680843acef38ce906e9cbe150025
Reviewed-on: https://chromium-review.googlesource.com/976819
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550521}
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/browser/extensions/BUILD.gn
[add] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/browser/extensions/api/enterprise_reporting_private/OWNERS
[add] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_api.cc
[add] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_api.h
[add] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_unittest.cc
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/common/extensions/api/BUILD.gn
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/common/extensions/api/_api_features.json
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/common/extensions/api/_permission_features.json
[add] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/common/extensions/api/enterprise_reporting_private.idl
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/common/extensions/permissions/chrome_api_permissions.cc
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/common/extensions/permissions/permission_set_unittest.cc
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/chrome/test/BUILD.gn
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/extensions/common/permissions/api_permission.h
[modify] https://crrev.com/fdada01a75db65126449561b8b7b62adb902efe8/tools/metrics/histograms/enums.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0eae27d80e7499c5740580c960c6bf73c81c9865

commit 0eae27d80e7499c5740580c960c6bf73c81c9865
Author: Georges Khalil <georgesak@chromium.org>
Date: Tue Jul 17 23:55:26 2018

Enable enterprise.reportingPrivate API on Stable.

Change-Id: I1bbeefa0bb68da658443e65ed1f9d63a510c4ed8
Bug:  826298 
Reviewed-on: https://chromium-review.googlesource.com/1141050
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575854}
[modify] https://crrev.com/0eae27d80e7499c5740580c960c6bf73c81c9865/chrome/common/extensions/api/_permission_features.json

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 18

Labels: merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bb922d7b87c89b1e4e2d291ecd7a4a4c3661062

commit 6bb922d7b87c89b1e4e2d291ecd7a4a4c3661062
Author: Georges Khalil <georgesak@chromium.org>
Date: Wed Jul 18 23:26:08 2018

Enable enterprise.reportingPrivate API on Stable.

Change-Id: I1bbeefa0bb68da658443e65ed1f9d63a510c4ed8
Bug:  826298 
Reviewed-on: https://chromium-review.googlesource.com/1141050
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Georges Khalil <georgesak@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#575854}(cherry picked from commit 0eae27d80e7499c5740580c960c6bf73c81c9865)
Reviewed-on: https://chromium-review.googlesource.com/1142664
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#716}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/6bb922d7b87c89b1e4e2d291ecd7a4a4c3661062/chrome/common/extensions/api/_permission_features.json

Labels: -Launch-API-NotReviewed Launch-API-Yes
(Delayed bit flip)
This can be closed right?
Status: Verified (was: Assigned)
Yup.

Sign in to add a comment