New issue
Advanced search Search tips

Issue 826297 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[Stylus Text Selection] Flickering of Selection popup during Stylus button selection

Project Member Reported by ajit...@samsung.com, Mar 27 2018

Issue description

Chrome Version: 65.0.3325.109
OS: Android 8.0
Device: Samsung Galaxy Note 8

What steps will reproduce the problem?
(1) Load any web page say, Google privacy page
(2) Try to do text selection using stylus primary button drag
(3) Observe text selection popup is appearing only upon releasing stylus button
(4) Without clearing existing selection, try to do another stylus selection using primary button and observe
(5) We can see selection popup is showing and hiding and kind of flickering

What is the expected result?
Selection popup should appear only after releasing the button with a signal of concluding active selection.

What happens instead?
selection popup is keep appearing during stylus button selection during drag, and appears like flickering.
 
stylus-selection.mp4
2.7 MB View Download

Comment 1 by ajit...@samsung.com, Mar 27 2018

Cc: amaralp@chromium.org
Labels: android-fe-triaged
Status: Available (was: Untriaged)
Owner: amaralp@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a52caad09e40377c58296887635640ec21c102b

commit 1a52caad09e40377c58296887635640ec21c102b
Author: AJITH KUMAR V <ajith.v@samsung.com>
Date: Thu Mar 29 11:26:17 2018

[Stylus Text Selection] Interpretting Stylus Secondary button as HANDLE_DRAG

Currently long press drag is treating selection drag as HANDLE_DRAG and
appropriately handling selection popup state. This was missing in case of
stylus drag selection. Hence flickering observed with selection popup
when we do stylus text selection. Now notifying stylus selection as
HANDLE_DRAG for appropriately handling the selection popup UI logic

Bug:  826297 
Change-Id: I17aec4a725dd7eab98db322b31574b347b6b0d9d
Reviewed-on: https://chromium-review.googlesource.com/981734
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: AJITH KUMAR V <ajith.v@samsung.com>
Cr-Commit-Position: refs/heads/master@{#546789}
[modify] https://crrev.com/1a52caad09e40377c58296887635640ec21c102b/content/browser/renderer_host/render_widget_host_view_android.cc

Comment 5 by ajit...@samsung.com, Mar 29 2018

Status: Fixed (was: Available)

Sign in to add a comment