MacViews: bookmark bar buttons have no focus indication |
||||||
Issue descriptionTabbing through the bookmark bar (with full keyboard access enabled) doesn't draw focus rings on these buttons, or any other kind of indicator.
,
Apr 11 2018
,
Apr 17 2018
,
Apr 25 2018
Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.
,
Apr 30 2018
,
May 7 2018
Any progress here?
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/863a60dad81526b65e56ea57406db32f87cd06ff commit 863a60dad81526b65e56ea57406db32f87cd06ff Author: Leonard Grey <lgrey@chromium.org> Date: Wed May 16 16:46:46 2018 MacViews: Use focus rings for many focused elements instead of ink drop This change adds a new platform style constant for whether focus rings should should be preferred over ink drops to indicate focus. Button subclasses can opt into this behavior by setting install_focus_ring_on_focus to true. This change includes this opt in for all top chrome buttons (as well as page actions). Bug: 836961 , 826294 Change-Id: I32239b88c4e3862d6f1029b375df7c678b5044a5 Reviewed-on: https://chromium-review.googlesource.com/1043011 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#559139} [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/chrome/browser/ui/views/frame/app_menu_button.cc [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/chrome/browser/ui/views/page_action/page_action_icon_view.cc [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/chrome/browser/ui/views/page_action/page_action_icon_view.h [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/chrome/browser/ui/views/toolbar/toolbar_action_view.cc [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/ui/views/controls/button/button.cc [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/ui/views/controls/button/button.h [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/ui/views/style/platform_style.cc [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/ui/views/style/platform_style.h [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/ui/views/style/platform_style_mac.mm
,
May 16 2018
Can this be marked as fixed if nothing else is pending?
,
May 17 2018
Verified the fix on Mac 10.13.3 using Chrome version #68.0.3433.0 as per the comment #0. Able to reproduce the issue on chrome version 68.0.3430.0 (build without fix) Attaching screencast for reference. Observed that "focus rings on the bookmark buttons." Hence, the fix is working as expected, adding Verified labels Thanks...!
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66d1e6b8e4eb1277df1487b1b52e41baba973e5b commit 66d1e6b8e4eb1277df1487b1b52e41baba973e5b Author: Leonard Grey <lgrey@chromium.org> Date: Thu May 17 16:36:16 2018 Don't clip bookmark bar to bounds This was originally introduced to prevent the bookmark bar overlaying the toolbar mid-animation, but this seems to no longer be the case. The motivation to remove this is due to the clipping cutting off the top of the bookmark buttons' focus rings. Bug: 826294 Change-Id: I3c5909f1c8e86ff2c0593ebb6cbf866614c9df2d Reviewed-on: https://chromium-review.googlesource.com/1064176 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#559564} [modify] https://crrev.com/66d1e6b8e4eb1277df1487b1b52e41baba973e5b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
,
May 18 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by lgrey@chromium.org
, Apr 11 2018