Video SurfaceLayer: fix WebMediaPlayerImplTest failures |
||
Issue descriptionOne CL landed for the LayoutTest and SurfaceLayer so I sent something to try to see if that helped us. It doesn't fix the layout tests but I was able to see that we still have a few WMPITests failing. Maybe worth fixing. Tests are: WebMediaPlayerImplTest.InfiniteDuration WebMediaPlayerImplTest.NaturalSizeChange WebMediaPlayerImplTest.VideoLockedWhenPausedWhenHidden WebMediaPlayerImplTest.NoStreams WebMediaPlayerImplTest.NaturalSizeChange_Rotated
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1847936bfa1a855fab330974d8e6f371f6a4e90 commit c1847936bfa1a855fab330974d8e6f371f6a4e90 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Tue Mar 27 17:05:28 2018 Video SurfaceLayer: fix failing WebMediaPlayerImplTest.* Some tests were failing because of mock methods expectations and non-expectation to be called. The tests are passing locally with the flag on. The flag is not currently enabled on trunk. Bug: 826284 Change-Id: I41d40e5bd85737dde2aa97b778d8c66080a04a2c Reviewed-on: https://chromium-review.googlesource.com/980995 Reviewed-by: Frank Liberato <liberato@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#546142} [modify] https://crrev.com/c1847936bfa1a855fab330974d8e6f371f6a4e90/media/blink/webmediaplayer_impl_unittest.cc
,
Mar 27 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by mlamouri@chromium.org
, Mar 27 2018