MacViewsBrowser: Tab hover highlight tracking is janky |
||
Issue descriptionChrome Version: 67.0.3381.0 OS: macOS 10.13.3 What steps will reproduce the problem? (1) --enable-features=ViewsBrowserWindows (2) Install a darker theme like https://chrome.google.com/webstore/detail/greyscale/olagifopidokilmoeiiejpmpfclmopfk to make this easier to observe (3) Open several tabs in the tab strip (4) Scrub your mouse over the tabstrip rapidly, watching the highlight effect that should be on the currently-hovered tab What is the expected result? The highlight effect should keep up with the mouse tracking, even when the mouse rapidly. What happens instead? The highlight animation falls behind and cannot keep up with the mouse. Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Mar 29 2018
** Bulk Edit ** FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.
,
Apr 25 2018
Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.
,
May 2 2018
I can repro this behavior on both macOS and Windows, but I think this is WAI. There's no main thread jank in either case. There's a timed animation for getting rid of the glow when the mouse leaves the tab: https://cs.chromium.org/chromium/src/ui/views/controls/glow_hover_controller.cc?sq=package:chromium&dr&l=58 You can also see this by moving you mouse on a tab, and then moving it down. The tab will slowly fade out. So what you're observing in the video is that the fade-out is occurring on many tabs [potentially several tabs behind your cursor], because you're moving the cursor at a relatively fast rate compared to the fade-out time. I don't think the current behavior [including video] looks particularly bad so I'm closing to close this bug. If we want to change the behavior, I'd be happy to tweak the animation numbers and/or chat with a UX designer.
,
May 2 2018
Confirming as tabstrip owner -- comment 4 is correct. |
||
►
Sign in to add a comment |
||
Comment 1 by ellyjo...@chromium.org
, Mar 29 2018Owner: erikc...@chromium.org
Status: Assigned (was: Untriaged)