Issue metadata
Sign in to add a comment
|
MacViewsBrowser: Spacing between bookmark bar icon and text is too wide |
||||||||||||||||||||||
Issue descriptionChrome Version: 67.0.3381.0 OS: macOS 10.13.3 What steps will reproduce the problem? (1) --enable-features=ViewsBrowserWindows (2) Add a few bookmarks to the bookmark bar (3) Compare spacing between the bookmark's icon and its text What is the expected result? More narrow spacing, so there's a logical grouping of "Icon + Text" and more spacing between individual bookmarks What happens instead? It's about even spacing between the icon and text and other bookmarks, making it harder to visually scan. Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Mar 29 2018
** Bulk Edit ** FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.
,
Apr 13 2018
Per Issue 757673 this seems (unfortunately IMO) WAI
,
Apr 16 2018
,
Apr 18 2018
A couple of other experiments! 4pt spacing inserted between bookmarks and 2pt interior margins added. plain: 4pt between bookmarks, 2pt interior margin, 4pt icon <-> label borders: same as plain, but with a 1pt Grey 200 border added to each bookmark backgrounds: same as plain, but with a 10% alpha 2A3146 background added
,
Apr 18 2018
Thanks ellyjones@. I prefer plain without any borders or background :-) What do you think about 6px between icon and text, since the spacing left of the icon and right of the text is also 6px. Attached a mock :-)
,
Apr 18 2018
#9: yeah, I'm following up with UI about this. I'll post here with their decision :)
,
Apr 18 2018
Great thanks :-)
,
Apr 18 2018
Calling this Started - I own chatting with bettes@ about it. Either we'll come back with design changes & I'll implement them, or we'll come back with an affirmation that the current design is desired.
,
Apr 20 2018
8.png in c5 is perfect. The embellishments on c6 are not necessary for steady states. Thanks Elly. Re: c9 I was imagining 4px inner padding instead of the 6px seen in that screenshot, but I rather like the 6px. I'll change the spec accordingly. For guidance on feedback colors, please refer to go/chrome-ux-gm2: https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g36e7d8d795_33_231 Tear sheet: go/chrome-ux-gm2-core
,
Apr 23 2018
#13: I'm going to: 1) Change the label <-> icon spacing from 12pt to 8pt 2) Change the inner padding on the buttons from 0pt to 6pt I will attach screenshots shortly :)
,
Apr 23 2018
,
Apr 23 2018
Screenshots for <https://chromium-review.googlesource.com/c/chromium/src/+/1023319>.
,
Apr 23 2018
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31047d0e1fa217d247ba5a82e4d7f62c7b452c56 commit 31047d0e1fa217d247ba5a82e4d7f62c7b452c56 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Apr 23 20:47:08 2018 views: adjust bookmark bar spacings The old spacings: 12pt label <-> icon, 0pt between New spacings: 8pt label <-> icon, 6pt between Before & after screenshot attached to the bug. Bug: 826264 Change-Id: I63b042bd7188a02a12d6150936d6236ef6e97478 Reviewed-on: https://chromium-review.googlesource.com/1023319 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#552821} [modify] https://crrev.com/31047d0e1fa217d247ba5a82e4d7f62c7b452c56/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/31047d0e1fa217d247ba5a82e4d7f62c7b452c56/chrome/browser/ui/views/harmony/harmony_layout_provider.cc
,
Apr 24 2018
The NextAction date has arrived: 2018-04-24
,
Apr 24 2018
Verified the fix on Mac 10.13.1 using Chrome version #68.0.3405.0 as per the comment #0. Attaching screen shot for reference. Observed that the spacing is proper in bookmark bar. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version 67.0.3381.0 Thanks...!!
,
Apr 24 2018
,
Apr 24 2018
Issue 816671 has been merged into this issue.
,
Apr 28 2018
Decide, please, this question, for the last half of the year you are making the second indentation ever wider. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ellyjo...@chromium.org
, Mar 29 2018Owner: ellyjo...@chromium.org
Status: Assigned (was: Untriaged)