New issue
Advanced search Search tips

Issue 826263 link

Starred by 3 users
Status: WontFix
Owner:
weili@chromium.org
Closed: May 2018
Cc:
pkasting@chromium.org
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

MacViewsBrowser: Themed tab outlines are of different color and thickness

Project Member Reported by rsesek@chromium.org, Mar 27 2018 
Chrome Version: 67.0.3381.0
OS: macOS 10.13.3

What steps will reproduce the problem?
(1) --enable-features=ViewsBrowserWindows
(2) Install Greyscale theme: https://chrome.google.com/webstore/detail/greyscale/olagifopidokilmoeiiejpmpfclmopfk
(3) Note difference in the outline of tabs. The Cocoa UI has a sharp, dark outline while the Views UI has a lighter, fuzzy outline

What is the expected result?
The Views UI should look as good as Cocoa.

What happens instead?
It doesn't.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
Cocoa.png
67.6 KB View Download
Views.png
70.8 KB View Download

Comment 1 by rsesek@chromium.org, Mar 27 2018

Labels: Proj-MacViews MacViews-Browser

Comment 2 by ellyjo...@chromium.org, Mar 29 2018

Labels: M-68 Target-68
Owner: weili@chromium.org
Status: Assigned (was: Untriaged)
weili@, can you take a look at this? thanks :)

Comment 3 by meh...@chromium.org, Mar 29 2018 

It's also very noticeable in an Incognito Window.
Bildschirmfoto 2018-03-29 um 21.05.20.png
54.4 KB View Download

Comment 4 by rsesek@chromium.org, Mar 29 2018

Summary: MacViewsBrowser: Themed tab outlines are of different color and thickness (was: MacViewsBrowser: Themed tab outlines are different of different color and thickness )

Comment 5 by gov...@chromium.org, Mar 29 2018 

** Bulk Edit **

FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.

Comment 6 by weili@chromium.org, Apr 13 2018

Labels: Sprint-1

Comment 7 by weili@chromium.org, Apr 20 2018

Status: Started (was: Assigned)

Comment 8 by weili@chromium.org, Apr 25 2018

Labels: -M-68 -Target-68 -Sprint-1 Target-69 M-69
My first attempt was not successful. https://chromium-review.googlesource.com/c/chromium/src/+/1025015, it may need to be addressed across platforms if needed.

However, the new UI refresh removes the outline, so not sure whether this is still needed. Punt it to the next release for now.

Comment 9 by weili@chromium.org, May 24 2018

Status: WontFix (was: Started)
As the new UI (MacViews+Refresh) won't have tab outline, the theme border looks pretty sharp -- see attached. Mark it won't fix.
Screen Shot.png
69.2 KB View Download
►

Sign in to add a comment