New issue
Advanced search Search tips

Issue 826251 link

Starred by 1 user
Status: Assigned
Owner:
grunell@chromium.org
Cc:
guidou@chromium.org
eladalon@chromium.org
terelius@chromium.org
solenberg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Insufficient unit tests suite - WebRtcLogCleanupTest

Project Member Reported by eladalon@chromium.org, Mar 27 2018 
The unit tests suite is insufficient - it doesn't cover the deletion of the entries representing the logs from the logs' index file, which is why https://bugs.chromium.org/p/chromium/issues/detail?id=825977 was never caught.

Comment 1 by grunell@chromium.org, Mar 28 2018 

This test is for testing the cleanup done in Chrome when the browser starts. The user clearing all data as in the linked issue seems to be a different thing. Can you elaborate on a test or test case that should be added?

Comment 2 by eladalon@chromium.org, Mar 28 2018 

I would suggest:
* Logs in user-indicated time range removed.
* Logs not in user-indicated time range not removed.
* Entries in the index, which are in user-indicated time range, are removed.
* Entries in the index, which are not in user-indicated time range, are not removed.
* Log files files removed even if no corresponding index entry exists.
* Entries from index removed even if no corresponding log files exist.

Please note that the last test would actually fail now. I am in the process of piggypacking the solution to that on another CL I am producing now.
►

Sign in to add a comment