Issue metadata
Sign in to add a comment
|
Regression:Cookies in use overlay closes after clicking on end process from task manager.
Reported by
vku...@etouch.net,
Mar 27 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 67.0.3381.0 (Official Build) Revision ae7ce2710f11dd78c2f787b888d2cc19b912bf49-refs/heads/master@{#545918} (32/64-bit) OS: Win(7,8,8.1,10), Linux (14.04 LTS) What steps will reproduce the problem? (1)Launch chrome and navigate to any webpage for e.g https://www.google.co.in (2)Right click on tab > duplicate > click on view site info > cookies (3)Press shift+Esc key to open task manager,click on google task > end process and observe Actual: Cookies in use overlay closes after clicking on end process from task manager. Expected: Cookies in use overlay should not close after clicking on end process from manager. This is a regression issue broken in 'M66' and providing the bisect using per-revision script Good Build: 66.0.3344.0 (Revision:535593) Bad Build: 66.0.3345.0 (Revision:536026) You are probably looking for a change made after 535734 (known good), but no later than 535735 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/7dc3a173d256cf3edbca00d8ca2680a4e4b32a97..ac6eb20fcb81e18d29a739e5efdca110c5c5e7cf Suspect: https://chromium.googlesource.com/chromium/src/+/ac6eb20fcb81e18d29a739e5efdca110c5c5e7cf @dmazzoni: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1.Issue not seen on Mac OS (10.12.6, 10.13.1, 10.13.4) 2.Issue is also seen on Dev build #67.0.3377.1
,
Apr 11 2018
,
Apr 12 2018
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2837c5891e07d0cd2afe61537b08706d2fef71e1 commit 2837c5891e07d0cd2afe61537b08706d2fef71e1 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Fri Apr 13 20:18:58 2018 WebView should not hide its NativeViewHost when showing a crash overlay. In r535735 we made WebView responsible for showing an overlay (like a sad tab) when the WebContents has crashed. When the overlay was showing we hid the NativeViewHost to be safe (using SetVisible(false)). This had the unintended consequence of closing modal dialogs such as a cookie dialog or dangerous download warning dialog. In testing, it seems safe to not actually hide |holder_|, the NativeViewHost. The overlay is absolute-positioned on top of it, and it's not possible to focus the WebContents. This was more or less true in the previous Sad Tab implementation where it was displayed in a Widget on top of the WebView instead of as a child View. Bug: 826248 , 821312 Change-Id: I748afeff1ac8d7e1fa18ccafe709706f803ae6cc Reviewed-on: https://chromium-review.googlesource.com/1008621 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#550742} [modify] https://crrev.com/2837c5891e07d0cd2afe61537b08706d2fef71e1/ui/views/controls/webview/webview.cc
,
Apr 16 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2837c5891e07d0cd2afe61537b08706d2fef71e1 commit 2837c5891e07d0cd2afe61537b08706d2fef71e1 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Fri Apr 13 20:18:58 2018 WebView should not hide its NativeViewHost when showing a crash overlay. In r535735 we made WebView responsible for showing an overlay (like a sad tab) when the WebContents has crashed. When the overlay was showing we hid the NativeViewHost to be safe (using SetVisible(false)). This had the unintended consequence of closing modal dialogs such as a cookie dialog or dangerous download warning dialog. In testing, it seems safe to not actually hide |holder_|, the NativeViewHost. The overlay is absolute-positioned on top of it, and it's not possible to focus the WebContents. This was more or less true in the previous Sad Tab implementation where it was displayed in a Widget on top of the WebView instead of as a child View. Bug: 826248 , 821312 Change-Id: I748afeff1ac8d7e1fa18ccafe709706f803ae6cc Reviewed-on: https://chromium-review.googlesource.com/1008621 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#550742} [modify] https://crrev.com/2837c5891e07d0cd2afe61537b08706d2fef71e1/ui/views/controls/webview/webview.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rtoy@chromium.org
, Mar 29 2018