Issue metadata
Sign in to add a comment
|
Settings: Network details: Configure button should be disabled when security type is 'None' |
||||||||||||||||||||||
Issue descriptionChrome Version: 66.0.3359.62/10452.28.0 beta channel Glimmer,Wolf,Banjo and Squawks OS: Chrome What steps will reproduce the problem? (1)Sign-in to user>> Navigate to chrome://settings (2)Click on Add WiFi and give some random name>> Click on Connect (3)Click on Error notification and then on Configure and observe Actual: No field can be edited but 'Save' and 'Cancel' buttons are seen enabled Expected: Atleast some field can be edited (Like password field in Old UI) This is a Regression issue as same is working fine in M64 NOTE: Issue is seen on M65 and M67 also @Stevenjb: Please confirm the issue
,
May 14 2018
,
Jun 6 2018
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17573c429dad1deee0c668f3933efc21e6b61a3a commit 17573c429dad1deee0c668f3933efc21e6b61a3a Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Jun 11 20:29:20 2018 settings: Internet: Fix configure button spacing and vis This CL: * Hides the 'configure' button for non secure WiFi networks (there is nothing to configure). * Fixes the spacing for the 'connect' and 'disconnect' buttons. Bug: 826242 , 838868 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id447a929234b90bfa4064a5daa88e5df6e95a4a4 Reviewed-on: https://chromium-review.googlesource.com/1089469 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#566131} [modify] https://crrev.com/17573c429dad1deee0c668f3933efc21e6b61a3a/chrome/browser/resources/settings/internet_page/internet_detail_page.html [modify] https://crrev.com/17573c429dad1deee0c668f3933efc21e6b61a3a/chrome/browser/resources/settings/internet_page/internet_detail_page.js
,
Jun 11 2018
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3002b04d1c1c04e0e5e6d9c884abb38e49d73f3 commit e3002b04d1c1c04e0e5e6d9c884abb38e49d73f3 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Jun 27 19:31:37 2018 settings: Internet: Fix configure button spacing and vis This CL: * Hides the 'configure' button for non secure WiFi networks (there is nothing to configure). * Fixes the spacing for the 'connect' and 'disconnect' buttons. TBR=stevenjb@chromium.org (cherry picked from commit 17573c429dad1deee0c668f3933efc21e6b61a3a) Bug: 826242 , 838868 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id447a929234b90bfa4064a5daa88e5df6e95a4a4 Reviewed-on: https://chromium-review.googlesource.com/1089469 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#566131} Reviewed-on: https://chromium-review.googlesource.com/1117464 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#555} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/e3002b04d1c1c04e0e5e6d9c884abb38e49d73f3/chrome/browser/resources/settings/internet_page/internet_detail_page.html [modify] https://crrev.com/e3002b04d1c1c04e0e5e6d9c884abb38e49d73f3/chrome/browser/resources/settings/internet_page/internet_detail_page.js |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Mar 27 2018Summary: Settings: Network details: Configure button should be disabled when security type is 'None' (was: Regression: Unable to edit in Configure dialog of Network settings)