Repro'd. I'll have a look at it.

From the proposed CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1086816

1. If the dialog was opened from Privacy then we navigate back to
privacy and focus on the subpage arrow that we used to open the dialog.

2. If the dialog was opened from Storage then the basic page will
show when the dialog is open (can't really change this). When the
dialog closes we re-navigate to the Storage subpage.

This is kind of a hack. It would be better if we could leave the
storage subpage open while the dialog is showing, but that would
require a special case in basic_page.

> This is kind of a hack. It would be better if we could leave the
storage subpage open while the dialog is showing, but that would
require a special case in basic_page.


Showing the one and only CBD instance in Settings, while still in the Storage subpage would require quite a bit of plumbing. An alternative would be to show a different CBD instance that is a direct child of the subpage in question. The fact that we use Web Components should make that fairly easy, but I don't know if there are any other complications (for example the URL would not show /clearBrowsingData for that other CBD instance).

(First, apologies to rjwright@ - this turns out to be much less straightforward than it might seem).

Navigating from the Device > Storage subpage, back to the Privacy section of the basic page, then to the Device > Storage subpage seems awkward at best. I think the current behavior would actually be better.

If we do anything, I think we should either:
1. Make Privacy > Clear browsing data a link to Device > Storage and move dialog ownership there (maybe we have to copy it for non CrOS?).

2. Modify the dialog so that it can be owned by each page/subpage:
* Re-factor <settings-clear-browsing-data-dialog> to just include the dialog contents (maybe rename it to settings-clear-browsing-data-dialog-contents, although that's a mouthful).
* Embed the <cr-dialog> wrapper separately in privacy_page.html and the device storage subpage. A small amount of code duplication will be required to handle open/close actions for each page, but that also gives us the ability to return to the correct page.

+dpapad@, WDYT?
+sgabriel@ for UX perspective.

As said in my previous response, moving the existing CBD dialog instance around does not seem trivial, and especially as proposed by bullet point 2 in comment #6, having a separate canonical CBD instance for CrOS vs non-CrOS seems even more complicated.

If anything, I would say it's fine to not return to the chrome://settings/storage page when opening and closing CBD. Consider that the user is linked from chrome://settings/storage to chrome://settings/clearBrowserData, and therefore a navigation has occured, and there is no need to return back.

If opening CBD from storage page should not be considered a navigation, then having the storage page own a 2nd instance of CBD is the easiest, if you are willing to live with some minor differences from the canonical one (like the URL not being /clearBrowsingData.

> Navigating from the Device > Storage subpage, back to the Privacy section of the basic page, then to the Device > Storage subpage seems awkward at best. I think the current behavior would actually be better.

I agree. We seem to do something similar with Device > Storage > Other Users, but because Other Users is a subpage and not a floating dialog you don't really see the navigation.

A small improvement (IMO) on the existing behavior is to just navigate to the previous route. The basic page can't be scrolled while the dialog is open so it will just go back to '/privacy' if the dialog was opened from Privacy, and '/' if the dialog was opened from Storage. We can keep the refocus onto the subpage-arrow in the Privacy case. I may also be able to refocus on the storage row for the Storage case.

> If opening CBD from storage page should not be considered a navigation, then having the storage page own a 2nd instance of CBD is the easiest, if you are willing to live with some minor differences from the canonical one (like the URL not being /clearBrowsingData.

I can give this a go, but it might take me a while to find time to do it.

I can also do my first suggestion in this comment first, as it is very easy, and follow up with the second suggestion later.

I started this, but it turned out to be more complicated than I expected

chromium-review.googlesource.com/c/chromium/src/+/1086816

I won't have time to look at it for a while, so someone else can pick it up if they want.

 Issue 868537  has been merged into this issue.

As I am in the process of refactoring how page transitions work in Settings ( https://crbug.com/907333 ), I am closing this bug. You can see in the attached screencast how this will look after the refactoring.

Once the subpage/page code is simpler, we can potentially re-visit. IMO there are  a few solutions to this problem (see #7, or moving CBD outside of the privacy page), but I don't think is a high priority either. Closing for now.

Deleted: storage_cbd_storage.mp4 410 KB

	storage_cbd_storage.mp4 410 KB View Download