New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826230 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 754471
issue 771643



Sign in to add a comment

fade in setup not working as expected

Reported by narayana...@gmail.com, Mar 27 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3379.0 Safari/537.36

Steps to reproduce the problem:
1. visit https://openspeedtest.com
2. when page finished loading app UI should fade it (Animation)
3. now it is not showing fade in animation 

What is the expected behavior?
when page load completed app ui should fade in  

What went wrong?
when page load completed app ui should fade in  it is not working completely. now it is showing instantly after few seconds . no fade in animation.

Did this work before? N/A 

Chrome version: 67.0.3379.0  Channel: canary
OS Version: OS X 10.13.3
Flash Version: 

fade in setup not working as expected on canary desk and mobile.

when page load completed app ui should fade in  

working fine on stable chrome.
 
Labels: Needs-Triage-M67
Components: -UI Blink>Animation
Labels: -OS-Mac
Since the report suggests both desktop and mobile, forwarding to blink and unmarking mac.
Labels: -Type-Bug Needs-Bisect Type-Bug-Regression
Status: Untriaged (was: Unconfirmed)
Labels: Triaged-ET Needs-Feedback
Tested the issue on chrome reported version 67.0.3379.0 using MacBook Air 10.13.3/10.12.6 and MacBook pro 10.13.3 with steps mentioned below:
1) Launched chrome reported version and navigate to URL: https://openspeedtest.com
2) Page loaded completely(seen some animation before page load completely), then clicked on "Start Testing Speed", able to see upload and download speed updated successfully

@Reporter: Please find the attached screen cast for your reference and let us know if we missed anything in verifying the issue,  try to test this issue on latest canary or creating new person with no apps and extensions in it and let us know if the issue still persists, you can download latest canary from URL: https://www.chromium.org/getting-involved/dev-channel. If possible could you please provide the screen cast of the which helps us in better understanding.

Thanks! 
826230.mp4
4.2 MB View Download
User interface should Appear with a fade in animation. Video attached.  
UI-ISSUE.mp4
22.6 MB Download
This is how it works.

With CSS a blue object blinks until the page loads completely (Window.ready)

After that with JavaScript Application User interface including button and gauges will fade in. it will take around 1.5 seconds i believe.

On stable chrome it is working as expected (You can see that in the right side in the video i attached)

On chrome 67 This fade in event is not working. (You can see that in the left side in the video i attached)

Comment 7 by ajha@chromium.org, Apr 17 2018

Labels: -Needs-Feedback
Components: Blink>Paint
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable RegressedIn-67 M-67 Target-67 FoundIn-67 Target-68 FoundIn-68 OS-Linux OS-Mac OS-Windows Pri-1
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce the issue on reported chrome version 67.0.3379.0, Dev 67.0.3393.4 and latest chrome 68.0.3398.0 using Windows-10, Mac 10.12.6 & Ubuntu 14.04  hence providing Bisect Info
Bisect Info:
================
Good build: 67.0.3371.0
Bad build: 67.0.3372.0

You are probably looking for a change made after 543290 (known good), but no later than 543291 (first known bad).

https://chromium.googlesource.com/chromium/src/+log/63667eca2a1d86f5de61f29c7c5c6417cc351757..3a3c78a924a686ed0d3f90d765b00cdd78453e11

Reviewed-on: https://chromium-review.googlesource.com/923572

@Xianzhu Wang: Please confirm the issue and help in re-assigning if it is not related to your change.
Adding ReleaseBlock-Stable as it is seems a receent break, feel free to remove it if not applicable.

Thanks!
Blocking: 803867
Cc: smcgruer@chromium.org dtapu...@chromium.org sindhu.chelamcherla@chromium.org wangxianzhu@chromium.org xidac...@chromium.org schenney@chromium.org
 Issue 831207  has been merged into this issue.
Blocking: -803867 754471 771643

Comment 12 by yigu@chromium.org, Apr 19 2018

Labels: Performance
 Issue 834184  has been merged into this issue.
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/371ffcdbb5dca7fb1a0aeb53956905bb1d4f9fc5

commit 371ffcdbb5dca7fb1a0aeb53956905bb1d4f9fc5
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Sat Apr 21 02:54:42 2018

[SPv175] Repaint non-composited layer on layer visibility change

When opacity changes between 0 or near-0 to non-zero (<1), existence
of paint chunk may change we do need to repaint the layers.

Bug:  826230 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I45d47d5eb8422df0fc991530ce41a4c2b7a86252
Reviewed-on: https://chromium-review.googlesource.com/1017917
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552560}
[modify] https://crrev.com/371ffcdbb5dca7fb1a0aeb53956905bb1d4f9fc5/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[add] https://crrev.com/371ffcdbb5dca7fb1a0aeb53956905bb1d4f9fc5/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/opacity-from-zero-to-non-zero-expected.txt
[add] https://crrev.com/371ffcdbb5dca7fb1a0aeb53956905bb1d4f9fc5/third_party/WebKit/LayoutTests/paint/invalidation/compositing/opacity-from-zero-to-non-zero-composited-expected.html
[add] https://crrev.com/371ffcdbb5dca7fb1a0aeb53956905bb1d4f9fc5/third_party/WebKit/LayoutTests/paint/invalidation/compositing/opacity-from-zero-to-non-zero-composited-expected.txt
[add] https://crrev.com/371ffcdbb5dca7fb1a0aeb53956905bb1d4f9fc5/third_party/WebKit/LayoutTests/paint/invalidation/compositing/opacity-from-zero-to-non-zero-composited.html
[add] https://crrev.com/371ffcdbb5dca7fb1a0aeb53956905bb1d4f9fc5/third_party/WebKit/LayoutTests/paint/invalidation/opacity-from-zero-to-non-zero-expected.html
[add] https://crrev.com/371ffcdbb5dca7fb1a0aeb53956905bb1d4f9fc5/third_party/WebKit/LayoutTests/paint/invalidation/opacity-from-zero-to-non-zero-expected.txt
[add] https://crrev.com/371ffcdbb5dca7fb1a0aeb53956905bb1d4f9fc5/third_party/WebKit/LayoutTests/paint/invalidation/opacity-from-zero-to-non-zero.html
[add] https://crrev.com/371ffcdbb5dca7fb1a0aeb53956905bb1d4f9fc5/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/opacity-from-zero-to-non-zero-expected.txt
[modify] https://crrev.com/371ffcdbb5dca7fb1a0aeb53956905bb1d4f9fc5/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/371ffcdbb5dca7fb1a0aeb53956905bb1d4f9fc5/third_party/blink/renderer/core/paint/paint_layer_painter.cc
[modify] https://crrev.com/371ffcdbb5dca7fb1a0aeb53956905bb1d4f9fc5/third_party/blink/renderer/core/paint/paint_layer_painter.h
[modify] https://crrev.com/371ffcdbb5dca7fb1a0aeb53956905bb1d4f9fc5/third_party/blink/renderer/core/paint/paint_layer_painter_test.cc

Labels: Merge-Request-67
Project Member

Comment 16 by sheriffbot@chromium.org, Apr 24 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 24 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/884c284f8789f37bc9befc756134f4fa1e4924e9

commit 884c284f8789f37bc9befc756134f4fa1e4924e9
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Apr 24 17:37:19 2018

[SPv175] Repaint non-composited layer on layer visibility change

When opacity changes between 0 or near-0 to non-zero (<1), existence
of paint chunk may change we do need to repaint the layers.

TBR=wangxianzhu@chromium.org

(cherry picked from commit 371ffcdbb5dca7fb1a0aeb53956905bb1d4f9fc5)

Bug:  826230 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I45d47d5eb8422df0fc991530ce41a4c2b7a86252
Reviewed-on: https://chromium-review.googlesource.com/1017917
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552560}
Reviewed-on: https://chromium-review.googlesource.com/1026197
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#258}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/884c284f8789f37bc9befc756134f4fa1e4924e9/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[add] https://crrev.com/884c284f8789f37bc9befc756134f4fa1e4924e9/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/opacity-from-zero-to-non-zero-expected.txt
[add] https://crrev.com/884c284f8789f37bc9befc756134f4fa1e4924e9/third_party/WebKit/LayoutTests/paint/invalidation/compositing/opacity-from-zero-to-non-zero-composited-expected.html
[add] https://crrev.com/884c284f8789f37bc9befc756134f4fa1e4924e9/third_party/WebKit/LayoutTests/paint/invalidation/compositing/opacity-from-zero-to-non-zero-composited-expected.txt
[add] https://crrev.com/884c284f8789f37bc9befc756134f4fa1e4924e9/third_party/WebKit/LayoutTests/paint/invalidation/compositing/opacity-from-zero-to-non-zero-composited.html
[add] https://crrev.com/884c284f8789f37bc9befc756134f4fa1e4924e9/third_party/WebKit/LayoutTests/paint/invalidation/opacity-from-zero-to-non-zero-expected.html
[add] https://crrev.com/884c284f8789f37bc9befc756134f4fa1e4924e9/third_party/WebKit/LayoutTests/paint/invalidation/opacity-from-zero-to-non-zero-expected.txt
[add] https://crrev.com/884c284f8789f37bc9befc756134f4fa1e4924e9/third_party/WebKit/LayoutTests/paint/invalidation/opacity-from-zero-to-non-zero.html
[add] https://crrev.com/884c284f8789f37bc9befc756134f4fa1e4924e9/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/opacity-from-zero-to-non-zero-expected.txt
[modify] https://crrev.com/884c284f8789f37bc9befc756134f4fa1e4924e9/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/884c284f8789f37bc9befc756134f4fa1e4924e9/third_party/blink/renderer/core/paint/paint_layer_painter.cc
[modify] https://crrev.com/884c284f8789f37bc9befc756134f4fa1e4924e9/third_party/blink/renderer/core/paint/paint_layer_painter.h
[modify] https://crrev.com/884c284f8789f37bc9befc756134f4fa1e4924e9/third_party/blink/renderer/core/paint/paint_layer_painter_test.cc

Status: Fixed (was: Assigned)

Sign in to add a comment