Scrollbar indicators for find-in-page hits move around chaotically |
||||||||||
Issue description67.0.3378.0 (Official Build) canary (64-bit) (cohort: Clang-64) Repro: open a Chromium code review, expand all files, C-f and type something that will have some number of hits, then do things like scroll via scrollwheel or C-g to move around the results. Notice that the yellow bars in the scroll area not only don't seem to correspond in any meaningful way with the hits on the page, but they jump around randomly as you scroll. Pre-emptively adding RBS since this is quite a bad UX.
,
Mar 28 2018
Able to repro on Linux. A bisect would be helpful
,
Mar 28 2018
Nevermind - it's RootLayerScrolling :( I'll take a closer look tomorrow.
,
Mar 28 2018
,
Mar 29 2018
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62cc7d83fd0870e628bee9a9fad7a470b77e0e3e commit 62cc7d83fd0870e628bee9a9fad7a470b77e0e3e Author: David Bokan <bokan@chromium.org> Date: Thu Mar 29 23:13:34 2018 [root layer scrolls] Fix find-in-page tickmarks Tickmarks are calculated based on Document-relative rects but turning on RLS made these rect Frame-relative since they're "absolute". This patch explicitly converts them to document coordinates. Bug: 826219 Change-Id: Id39f1b337f2bebe34587d79398879778ddb864cc Reviewed-on: https://chromium-review.googlesource.com/986715 Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#547008} [modify] https://crrev.com/62cc7d83fd0870e628bee9a9fad7a470b77e0e3e/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp [modify] https://crrev.com/62cc7d83fd0870e628bee9a9fad7a470b77e0e3e/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
,
Mar 29 2018
Will let this roll through canary and request a merge after the weekend.
,
Apr 3 2018
Confirmed on Windows 67.0.3387.0. Requesting merge.
,
Apr 3 2018
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 3 2018
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6213623322eefe6089ed0be0638f393006af4b5b commit 6213623322eefe6089ed0be0638f393006af4b5b Author: David Bokan <bokan@chromium.org> Date: Tue Apr 03 18:29:42 2018 [root layer scrolls] Fix find-in-page tickmarks Tickmarks are calculated based on Document-relative rects but turning on RLS made these rect Frame-relative since they're "absolute". This patch explicitly converts them to document coordinates. Bug: 826219 Change-Id: Id39f1b337f2bebe34587d79398879778ddb864cc Reviewed-on: https://chromium-review.googlesource.com/986715 Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#547008}(cherry picked from commit 62cc7d83fd0870e628bee9a9fad7a470b77e0e3e) Reviewed-on: https://chromium-review.googlesource.com/993312 Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#553} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/6213623322eefe6089ed0be0638f393006af4b5b/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp [modify] https://crrev.com/6213623322eefe6089ed0be0638f393006af4b5b/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
,
Apr 3 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by e...@chromium.org
, Mar 28 2018