chrome://webrtc-logs doesn't refresh; must be restarted to refresh |
|||
Issue descriptionchrome://webrtc-logs can't be refreshed. It must be closed and reopened to update with new information (Encountered on Linux between M66 and M67)
,
Mar 27 2018
Fwiw, chrome://crashes behaves the same (or at least did some time ago). Would be nice to fix.
,
Mar 27 2018
(I mean you should fix webrtc-logs, not crashes, unless you want.)
,
Mar 27 2018
Let's see what time permits. :-)
,
Mar 27 2018
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5714379d9bfebb6753d407ac1fb0d33f8b3dddf0 commit 5714379d9bfebb6753d407ac1fb0d33f8b3dddf0 Author: Elad Alon <eladalon@chromium.org> Date: Fri Apr 27 10:52:54 2018 Fix refresh behavior in chrome://webrtc-logs Before this CL, refreshing had no effect; the page tab would have to be closed and reopened for the list to actually be refreshed. This CL fixes the issue. Piggy-backed on this CL is also a fix of a problem where base::Unretained was used instead of a WeakPtr. Bug: 826206 Change-Id: I49e6f5bb7e62487d71a0816a7faaf8538fb04363 Reviewed-on: https://chromium-review.googlesource.com/1028070 Reviewed-by: Henrik Grunell <grunell@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#554352} [modify] https://crrev.com/5714379d9bfebb6753d407ac1fb0d33f8b3dddf0/chrome/browser/ui/webui/media/webrtc_logs_ui.cc
,
Apr 27 2018
,
Apr 27 2018
chrome://crashes seems to be fine on M66 and M68. Haven't checked for M67, but if there's a problem there, it would be too late to merge a fix anyway, so I won't check.
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a059205b96d3fc71925865f43c25c762da65019 commit 7a059205b96d3fc71925865f43c25c762da65019 Author: Elad Alon <eladalon@chromium.org> Date: Mon Apr 30 09:51:42 2018 Mark WebRtcLogsDOMHandler as final This would prevent a sub-class adding data members after the WeakPtrFactory. Bug: 826206 Change-Id: Idb81d4e677915391a248fc148f1d7ccfbeb852c3 Reviewed-on: https://chromium-review.googlesource.com/1032614 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Henrik Grunell <grunell@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#554715} [modify] https://crrev.com/7a059205b96d3fc71925865f43c25c762da65019/chrome/browser/ui/webui/media/webrtc_logs_ui.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by eladalon@chromium.org
, Mar 27 2018