New issue
Advanced search Search tips

Issue 826203 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 803853



Sign in to add a comment

Migrate scheduler classes to new directory structure

Project Member Reported by yutak@chromium.org, Mar 27 2018

Issue description

(Part of Scheduler Architecture 2.0: issue 803853)

New directory structure is described here:
https://docs.google.com/document/d/1dk71yTd5fndb5gMSb7wlB2P80hw5ImFxbPao06Ti8EQ/edit?usp=sharing

Directories under platform/scheduler will be:
  public/ main_thread/ worker/ common/ util/ test/

The following current directories will eventually retire:
  child/ renderer/ utility/
  base/ (-> move to //base)

 

Comment 1 by yutak@chromium.org, Mar 27 2018

Blocking: 803853
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acde32e9049330c23e727c5511cb56ee49d62bc7

commit acde32e9049330c23e727c5511cb56ee49d62bc7
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu Mar 29 07:17:27 2018

Migrate FrameScheduler-related files to new scheduler directory structure.

Blink scheduler code is transitioning to a new directory structure.
This patch moves a few files related to FrameScheduler, and rewrites
include paths in the affected files.

This patch introduces new directories: platform/scheduler/public and
platform/scheduler/main_thread. DEPS file is added to main_thread/
for moved tests.

Bug: 826203
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5894ccb0635922957aed6ada2a6e4e2e536d02e7
Reviewed-on: https://chromium-review.googlesource.com/983084
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546756}
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/core/paint/PaintTiming.cpp
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/core/scheduler/FrameSchedulerTest.cpp
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/core/script/PendingScript.cpp
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.h
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/loader/testing/MockFetchContext.h
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/child/worker_metrics_helper.h
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.h
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_proxy.cc
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_proxy.h
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/common/throttling/task_queue_throttler.cc
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[add] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/main_thread/DEPS
[rename] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/main_thread/frame_origin_type.cc
[rename] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/main_thread/frame_origin_type.h
[rename] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/main_thread/frame_scheduler_impl.cc
[rename] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/main_thread/frame_scheduler_impl.h
[rename] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc
[rename] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/public/frame_scheduler.h
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/renderer/frame_status.cc
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/renderer/page_scheduler.h
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/renderer/page_scheduler_impl.cc
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/renderer/page_scheduler_impl_unittest.cc
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/renderer/queueing_time_estimator.cc
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper.cc
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper_unittest.cc
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
[modify] https://crrev.com/acde32e9049330c23e727c5511cb56ee49d62bc7/third_party/WebKit/Source/platform/scheduler/test/fake_frame_scheduler.h

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd

commit 8ed7ee5e13f4b2ff689a418bde3496455e06ffdd
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu Mar 29 09:00:31 2018

Migrate PageScheduler-related files to new scheduler directory structure.

Blink scheduler code is transitioning to a new directory structure.
This path moves PageScheduler and PageSchedulerImpl, and rewrites
include paths.

Bug: 826203
Change-Id: Ieeebbd77a4046ff6c7238baba0f7d34817839679
Reviewed-on: https://chromium-review.googlesource.com/985597
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546774}
[modify] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/core/inspector/InspectorEmulationAgent.h
[modify] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/core/page/Page.h
[modify] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/core/scheduler/ActiveConnectionThrottlingTest.cpp
[modify] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/core/scheduler/VirtualTimeTest.cpp
[modify] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[modify] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/platform/scheduler/child/web_scheduler.h
[modify] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.cc
[modify] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc
[rename] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/platform/scheduler/main_thread/page_scheduler_impl.cc
[rename] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/platform/scheduler/main_thread/page_scheduler_impl.h
[rename] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/platform/scheduler/main_thread/page_scheduler_impl_unittest.cc
[rename] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/platform/scheduler/public/page_scheduler.h
[modify] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/platform/scheduler/renderer/frame_status.cc
[modify] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
[modify] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/platform/scheduler/renderer/renderer_web_scheduler_impl.cc
[modify] https://crrev.com/8ed7ee5e13f4b2ff689a418bde3496455e06ffdd/third_party/WebKit/Source/platform/scheduler/test/fake_page_scheduler.h

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b

commit e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Apr 02 07:56:19 2018

Rename files for ChildScheduler and its children.

Blink scheduler code is transitioning to a new directory structure.
This patch moves files for ChildScheduler and its children, and
rewrites affected include paths.

This patch only renames files; the class names are not changed yet.
The file names reflect the new names of the classes, instead of the
current names, to avoid renaming include paths twice. The class names
will be updated in a follow-up patch.

The renaming scheme of those classes is a bit complex. Look at the
design doc linked from the bug for details.

TBR=kinuko@chromium.org,dalecurtis@chromium.org

Bug: 826203
Change-Id: I72c10ee15f3510c11e9d0520d7f6e7d4a5715b66
Reviewed-on: https://chromium-review.googlesource.com/986112
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547422}
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/content/public/test/render_view_test.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/content/renderer/dom_storage/dom_storage_cached_area.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/content/renderer/input/input_handler_manager.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/content/renderer/input/main_thread_event_queue.h
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/content/renderer/input/main_thread_event_queue_task.h
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/content/renderer/input/widget_input_handler_impl.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/content/renderer/input/widget_input_handler_manager.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/content/renderer/render_thread_impl.h
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/content/renderer/render_thread_impl_browsertest.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/content/renderer/render_widget.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/content/renderer/renderer_main.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/media/blink/run_all_unittests.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/core/loader/InteractiveDetectorTest.cpp
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/core/loader/NavigationScheduler.h
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/core/scheduler/ThrottlingTest.cpp
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/TimerTest.cpp
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/child/idle_canceled_delayed_task_sweeper.h
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/child/idle_helper.h
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/child/single_thread_idle_task_runner.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/child/web_scheduler.h
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/child/webthread_base.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/child/worker_global_scope_scheduler.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/child/worker_global_scope_scheduler_unittest.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_proxy.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/child/worker_task_queue.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/common/throttling/budget_pool_unittest.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/common/throttling/task_queue_throttler.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/main_thread/DEPS
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc
[rename] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/main_thread/main_thread_scheduler.cc
[rename] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/main_thread/main_thread_scheduler.h
[rename] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/main_thread/main_thread_scheduler_unittest.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/main_thread/page_scheduler_impl.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/main_thread/page_scheduler_impl_unittest.cc
[rename] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/main_thread/render_widget_scheduling_state.cc
[rename] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/main_thread/web_main_thread_scheduler.cc
[rename] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/public/non_main_thread_scheduler.h
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/renderer/main_thread_task_queue.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/renderer/queueing_time_estimator_unittest.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/renderer/render_widget_signals.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/renderer/render_widget_signals_unittest.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper_unittest.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_web_scheduler_impl.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/renderer/user_model.h
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/renderer/web_scoped_virtual_time_pauser.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/test/renderer_scheduler_test_support.cc
[add] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/worker/DEPS
[rename] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/worker/compositor_thread_scheduler.cc
[rename] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/worker/compositor_thread_scheduler.h
[rename] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/worker/non_main_thread_scheduler.cc
[rename] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/worker/worker_thread_scheduler.cc
[rename] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/worker/worker_thread_scheduler.h
[rename] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/scheduler/worker/worker_thread_scheduler_unittest.cc
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/Source/platform/testing/TestingPlatformSupportWithMockScheduler.cpp
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/public/BUILD.gn
[rename] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/public/platform/scheduler/render_widget_scheduling_state.h
[rename] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/public/platform/scheduler/single_thread_idle_task_runner.h
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/public/platform/scheduler/test/fake_renderer_scheduler.h
[modify] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/public/platform/scheduler/test/mock_renderer_scheduler.h
[rename] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/public/platform/scheduler/web_main_thread_scheduler.h
[rename] https://crrev.com/e0a4f7c29d1758dfff5944e74d1d4dfb281a2e1b/third_party/WebKit/public/platform/scheduler/web_thread_scheduler.h

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903

commit 3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu Apr 05 11:12:25 2018

Rename RendererScheduler to WebMainThreadScheduler.

Scheduler classes are being renamed as part of scheduler
architecture refactoring.

RendererScheduler is used in very many places, so this patch affects
a lot of files. The diffs are basically simple renames of classes,
functions or variables.

TBR=kinuko@chromium.org,dalecurtis@chromium.org

Bug: 826203
Change-Id: I4fd701b5e8b35e9ec5ab44f136af2fbe00f07d83
Reviewed-on: https://chromium-review.googlesource.com/994854
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548385}
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/public/test/render_view_test.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/public/test/render_view_test.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/dom_storage/dom_storage_cached_area.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/dom_storage/dom_storage_cached_area.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/dom_storage/dom_storage_cached_area_unittest.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/dom_storage/dom_storage_dispatcher.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/dom_storage/local_storage_cached_area.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/dom_storage/local_storage_cached_area.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/dom_storage/local_storage_cached_area_unittest.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/dom_storage/local_storage_cached_areas.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/dom_storage/local_storage_cached_areas.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/gpu/compositor_dependencies.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/input/input_handler_manager.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/input/input_handler_manager.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/input/main_thread_event_queue.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/input/main_thread_event_queue.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/input/widget_input_handler_manager.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/input/widget_input_handler_manager.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/render_thread_impl.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/render_thread_impl_browsertest.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/render_view_impl.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/render_widget.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/renderer_main.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/test/fake_compositor_dependencies.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/test/fake_compositor_dependencies.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/test/layouttest_support.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/content/test/test_blink_web_unit_test_support.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/media/blink/run_all_unittests.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/third_party/WebKit/Source/core/dom/IdleDeadlineTest.cpp
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/third_party/WebKit/Source/core/dom/ScriptedIdleTaskControllerTest.cpp
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/third_party/WebKit/Source/core/loader/NavigationScheduler.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/third_party/WebKit/Source/core/scheduler/ThrottlingTest.cpp
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/third_party/WebKit/Source/platform/scheduler/child/web_scheduler.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/third_party/WebKit/Source/platform/scheduler/main_thread/main_thread_scheduler.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/third_party/WebKit/Source/platform/scheduler/main_thread/main_thread_scheduler_unittest.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/third_party/WebKit/Source/platform/scheduler/main_thread/web_main_thread_scheduler.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/third_party/WebKit/Source/platform/scheduler/renderer/renderer_web_scheduler_impl.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/third_party/WebKit/Source/platform/scheduler/renderer/renderer_web_scheduler_impl.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/third_party/WebKit/Source/platform/scheduler/test/renderer_scheduler_test_support.cc
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/third_party/WebKit/public/platform/scheduler/test/fake_renderer_scheduler.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/third_party/WebKit/public/platform/scheduler/test/mock_renderer_scheduler.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/third_party/WebKit/public/platform/scheduler/test/renderer_scheduler_test_support.h
[modify] https://crrev.com/3331f5c7a7eb5885f1e15064bb3a4e3f88bbf903/third_party/WebKit/public/platform/scheduler/web_main_thread_scheduler.h

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39219b441b7dd819bb8cf24efef0be0e46a0ee22

commit 39219b441b7dd819bb8cf24efef0be0e46a0ee22
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Apr 06 10:28:14 2018

Prepend "Web" to RenderWidgetSchedulingState.

This class is Blink's public interface, so its name should start with
"Web".

This is a follow-up of crrev.com/c/986112.

Bug: 826203
Change-Id: I88933aa86fbe64c695cc10a76ce36edc1b981f7a
Reviewed-on: https://chromium-review.googlesource.com/989386
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548734}
[modify] https://crrev.com/39219b441b7dd819bb8cf24efef0be0e46a0ee22/content/renderer/render_widget.cc
[modify] https://crrev.com/39219b441b7dd819bb8cf24efef0be0e46a0ee22/content/renderer/render_widget.h
[modify] https://crrev.com/39219b441b7dd819bb8cf24efef0be0e46a0ee22/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[modify] https://crrev.com/39219b441b7dd819bb8cf24efef0be0e46a0ee22/third_party/WebKit/Source/platform/scheduler/main_thread/main_thread_scheduler.cc
[modify] https://crrev.com/39219b441b7dd819bb8cf24efef0be0e46a0ee22/third_party/WebKit/Source/platform/scheduler/main_thread/main_thread_scheduler.h
[rename] https://crrev.com/39219b441b7dd819bb8cf24efef0be0e46a0ee22/third_party/WebKit/Source/platform/scheduler/main_thread/web_render_widget_scheduling_state.cc
[modify] https://crrev.com/39219b441b7dd819bb8cf24efef0be0e46a0ee22/third_party/WebKit/Source/platform/scheduler/renderer/render_widget_signals.cc
[modify] https://crrev.com/39219b441b7dd819bb8cf24efef0be0e46a0ee22/third_party/WebKit/Source/platform/scheduler/renderer/render_widget_signals.h
[modify] https://crrev.com/39219b441b7dd819bb8cf24efef0be0e46a0ee22/third_party/WebKit/Source/platform/scheduler/renderer/render_widget_signals_unittest.cc
[modify] https://crrev.com/39219b441b7dd819bb8cf24efef0be0e46a0ee22/third_party/WebKit/Source/platform/scheduler/test/fake_renderer_scheduler.cc
[modify] https://crrev.com/39219b441b7dd819bb8cf24efef0be0e46a0ee22/third_party/WebKit/public/BUILD.gn
[delete] https://crrev.com/83bfc0c839ae2de2b6a0fa49de2b998ffd0bf31d/third_party/WebKit/public/platform/scheduler/render_widget_scheduling_state.h
[modify] https://crrev.com/39219b441b7dd819bb8cf24efef0be0e46a0ee22/third_party/WebKit/public/platform/scheduler/test/fake_renderer_scheduler.h
[modify] https://crrev.com/39219b441b7dd819bb8cf24efef0be0e46a0ee22/third_party/WebKit/public/platform/scheduler/test/mock_renderer_scheduler.h
[modify] https://crrev.com/39219b441b7dd819bb8cf24efef0be0e46a0ee22/third_party/WebKit/public/platform/scheduler/web_main_thread_scheduler.h
[add] https://crrev.com/39219b441b7dd819bb8cf24efef0be0e46a0ee22/third_party/WebKit/public/platform/scheduler/web_render_widget_scheduling_state.h

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9ccc270117255234e9ebe32226013c4c9448a2f

commit d9ccc270117255234e9ebe32226013c4c9448a2f
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue Apr 10 06:36:43 2018

Rename main_thread_scheduler.{h,cc} to main_thread_scheduler_impl.

These files were renamed in crrev.com/c/986112, but they should have
"_impl" in the back. This patch corrects those names.

Bug: 826203
Change-Id: Ib4cf5e51f1e5cd8d517486a0e1fb177bb30d8f78
Reviewed-on: https://chromium-review.googlesource.com/994504
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549436}
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/core/loader/interactive_detector_test.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/common/throttling/budget_pool_unittest.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc
[rename] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[rename] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[rename] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl_unittest.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/main_thread/web_main_thread_scheduler.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/renderer/main_thread_task_queue.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/renderer/queueing_time_estimator_unittest.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/renderer/renderer_metrics_helper.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/renderer/renderer_metrics_helper_unittest.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/renderer/renderer_web_scheduler_impl.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/renderer/web_scoped_virtual_time_pauser.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/scheduler/test/renderer_scheduler_test_support.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc
[modify] https://crrev.com/d9ccc270117255234e9ebe32226013c4c9448a2f/third_party/blink/renderer/platform/timer_test.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ae826082205b856063f6b390d4a3767dc642ed7

commit 7ae826082205b856063f6b390d4a3767dc642ed7
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue Apr 10 07:06:29 2018

Rename WorkerScheduler to NonMainThreadScheduler.

Scheduler classes are being renamed as part of scheduler
architecture refactoring.

Bug: 826203
Change-Id: Ic9a74dd8ef8238c0d83dda03d3c9e5a6f505d85b
Reviewed-on: https://chromium-review.googlesource.com/994853
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549440}
[modify] https://crrev.com/7ae826082205b856063f6b390d4a3767dc642ed7/third_party/blink/renderer/core/workers/worker_thread.cc
[modify] https://crrev.com/7ae826082205b856063f6b390d4a3767dc642ed7/third_party/blink/renderer/platform/scheduler/child/webthread_base.cc
[modify] https://crrev.com/7ae826082205b856063f6b390d4a3767dc642ed7/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc
[modify] https://crrev.com/7ae826082205b856063f6b390d4a3767dc642ed7/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.h
[modify] https://crrev.com/7ae826082205b856063f6b390d4a3767dc642ed7/third_party/blink/renderer/platform/scheduler/child/worker_global_scope_scheduler.cc
[modify] https://crrev.com/7ae826082205b856063f6b390d4a3767dc642ed7/third_party/blink/renderer/platform/scheduler/child/worker_global_scope_scheduler.h
[modify] https://crrev.com/7ae826082205b856063f6b390d4a3767dc642ed7/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_helper.cc
[modify] https://crrev.com/7ae826082205b856063f6b390d4a3767dc642ed7/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_helper.h
[modify] https://crrev.com/7ae826082205b856063f6b390d4a3767dc642ed7/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/7ae826082205b856063f6b390d4a3767dc642ed7/third_party/blink/renderer/platform/scheduler/child/worker_task_queue.cc
[modify] https://crrev.com/7ae826082205b856063f6b390d4a3767dc642ed7/third_party/blink/renderer/platform/scheduler/child/worker_task_queue.h
[modify] https://crrev.com/7ae826082205b856063f6b390d4a3767dc642ed7/third_party/blink/renderer/platform/scheduler/public/non_main_thread_scheduler.h
[modify] https://crrev.com/7ae826082205b856063f6b390d4a3767dc642ed7/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.cc
[modify] https://crrev.com/7ae826082205b856063f6b390d4a3767dc642ed7/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.h
[modify] https://crrev.com/7ae826082205b856063f6b390d4a3767dc642ed7/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler.cc
[modify] https://crrev.com/7ae826082205b856063f6b390d4a3767dc642ed7/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc
[modify] https://crrev.com/7ae826082205b856063f6b390d4a3767dc642ed7/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6467b5120a0d80a041b70cf64f68906eedaf18c9

commit 6467b5120a0d80a041b70cf64f68906eedaf18c9
Author: Yuta Kitamura <yutak@chromium.org>
Date: Wed Apr 11 03:50:10 2018

Rename WorkerSchedulerImpl to WorkerThreadScheduler.

Scheduler classes are being renamed as part of scheduler
architecture refactoring.

Bug: 826203
Change-Id: I36c342c1dc9f084826def5726476659295942a70
Reviewed-on: https://chromium-review.googlesource.com/1004815
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549747}
[modify] https://crrev.com/6467b5120a0d80a041b70cf64f68906eedaf18c9/third_party/blink/renderer/platform/scheduler/child/worker_global_scope_scheduler_unittest.cc
[modify] https://crrev.com/6467b5120a0d80a041b70cf64f68906eedaf18c9/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_proxy.cc
[modify] https://crrev.com/6467b5120a0d80a041b70cf64f68906eedaf18c9/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_proxy.h
[modify] https://crrev.com/6467b5120a0d80a041b70cf64f68906eedaf18c9/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/6467b5120a0d80a041b70cf64f68906eedaf18c9/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler.cc
[modify] https://crrev.com/6467b5120a0d80a041b70cf64f68906eedaf18c9/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc
[modify] https://crrev.com/6467b5120a0d80a041b70cf64f68906eedaf18c9/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h
[modify] https://crrev.com/6467b5120a0d80a041b70cf64f68906eedaf18c9/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9070d659c39b45c99fb84c09b1d36092bc15cd4b

commit 9070d659c39b45c99fb84c09b1d36092bc15cd4b
Author: Yuta Kitamura <yutak@chromium.org>
Date: Wed Apr 11 03:50:42 2018

Rename CompositorWorkerScheduler to CompositorThreadScheduler.

Scheduler classes are being renamed as part of scheduler
architecture refactoring.

Bug: 826203
Change-Id: I1c6cc7800eb32d16b505e90d635d162b05865300
Reviewed-on: https://chromium-review.googlesource.com/1004874
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549748}
[modify] https://crrev.com/9070d659c39b45c99fb84c09b1d36092bc15cd4b/third_party/blink/renderer/platform/scheduler/child/webthread_base.cc
[modify] https://crrev.com/9070d659c39b45c99fb84c09b1d36092bc15cd4b/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.cc
[modify] https://crrev.com/9070d659c39b45c99fb84c09b1d36092bc15cd4b/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.h

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efb40b0b459f3fd7877ea8e564ef225b995bd240

commit efb40b0b459f3fd7877ea8e564ef225b995bd240
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu Apr 12 09:33:18 2018

Move files related to SchedulerHelper to the new directories.

Scheduler files are being moved as part of scheduler architecture
refactoring.

Bug: 826203
Change-Id: Ic5fec44a4e37309bc5432ccafa0de9d2d9d7f3bd
Reviewed-on: https://chromium-review.googlesource.com/1006734
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550121}
[modify] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/child/idle_canceled_delayed_task_sweeper.h
[modify] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/child/idle_canceled_delayed_task_sweeper_unittest.cc
[modify] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/child/idle_helper.cc
[modify] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/child/idle_helper.h
[modify] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/child/idle_helper_unittest.cc
[rename] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.cc
[rename] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.h
[rename] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/common/scheduler_helper_unittest.cc
[rename] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_helper.cc
[rename] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_helper.h
[modify] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/public/non_main_thread_scheduler.h
[modify] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/renderer/auto_advancing_virtual_time_domain.cc
[modify] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/renderer/auto_advancing_virtual_time_domain_unittest.cc
[modify] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.cc
[rename] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_helper.cc
[rename] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_helper.h
[modify] https://crrev.com/efb40b0b459f3fd7877ea8e564ef225b995bd240/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f65764097d0624640af0cac226377a8bc4bf66f

commit 7f65764097d0624640af0cac226377a8bc4bf66f
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu Apr 12 11:54:22 2018

Rename RendererSchedulerImpl to MainThreadSchedulerImpl.

Scheduler classes are being renamed as part of scheduler architecture
refactoring.

There are a number of string literals containing "RendererScheduler"
for tracing and UMA purposes. Among these, tracing names are renamed
to "MainThreadScheduler", but UMA names are kept as is in order to
maintain the continuity of UMA data.

Bug: 826203
Change-Id: I0cb113036e602fcf14a255153d0c76f3b2898c83
Reviewed-on: https://chromium-review.googlesource.com/1004888
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550147}
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/public/platform/web_scoped_virtual_time_pauser.h
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/common/throttling/budget_pool_unittest.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler.h
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.h
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_helper.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_helper.h
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.h
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl_unittest.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/main_thread/web_main_thread_scheduler.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/renderer/main_thread_task_queue.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/renderer/main_thread_task_queue.h
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/renderer/queueing_time_estimator_unittest.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/renderer/renderer_metrics_helper.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/renderer/renderer_metrics_helper.h
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/renderer/renderer_metrics_helper_unittest.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/renderer/renderer_web_scheduler_impl.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/renderer/renderer_web_scheduler_impl.h
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/renderer/web_scoped_virtual_time_pauser.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.h
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/scheduler/test/renderer_scheduler_test_support.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h
[modify] https://crrev.com/7f65764097d0624640af0cac226377a8bc4bf66f/third_party/blink/renderer/platform/timer_test.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e190efbdd60c8a0c3cb4a62079e8469b13460fc

commit 8e190efbdd60c8a0c3cb4a62079e8469b13460fc
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Apr 13 08:33:14 2018

Rename WorkerSchedulerHelper to NonMainThreadSchedulerHelper.

The class now supports NonMainThreadScheduler, so its name should also
be changed. File names are also updated.

Bug: 826203
Change-Id: I49c08a359db10d28db5db434b8db5e5b0c985e6f
Reviewed-on: https://chromium-review.googlesource.com/1011862
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550548}
[modify] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/child/idle_helper_unittest.cc
[modify] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/common/scheduler_helper_unittest.cc
[modify] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/public/non_main_thread_scheduler.h
[modify] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/renderer/auto_advancing_virtual_time_domain_unittest.cc
[modify] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.cc
[modify] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler.cc
[rename] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_helper.cc
[rename] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_helper.h
[modify] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dea26b734148b257a776f1516d52996e0521ed8b

commit dea26b734148b257a776f1516d52996e0521ed8b
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Fri Apr 13 16:51:04 2018

Scheduler: Rename WorkerGlobalScopeScheduler to WorkerScheduler

This is a follow-up CL for
https://chromium-review.googlesource.com/c/chromium/src/+/994552/12/third_party/blink/renderer/platform/scheduler/public/frame_or_worker_global_scope_scheduler.h#13

Bug: 826203
Change-Id: Id43950524c7f74f797942bc43b7f51c5abe805be
Reviewed-on: https://chromium-review.googlesource.com/1006837
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550651}
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/core/execution_context/execution_context.h
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/core/testing/null_execution_context.cc
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/core/testing/null_execution_context.h
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/core/workers/worker_thread.cc
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/core/workers/worker_thread.h
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/platform/scheduler/BUILD.gn
[rename] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/platform/scheduler/child/worker_scheduler.cc
[rename] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/platform/scheduler/child/worker_scheduler.h
[rename] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_unittest.cc
[rename] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/platform/scheduler/public/frame_or_worker_scheduler.h
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/platform/scheduler/public/frame_scheduler.h

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e190efbdd60c8a0c3cb4a62079e8469b13460fc

commit 8e190efbdd60c8a0c3cb4a62079e8469b13460fc
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Apr 13 08:33:14 2018

Rename WorkerSchedulerHelper to NonMainThreadSchedulerHelper.

The class now supports NonMainThreadScheduler, so its name should also
be changed. File names are also updated.

Bug: 826203
Change-Id: I49c08a359db10d28db5db434b8db5e5b0c985e6f
Reviewed-on: https://chromium-review.googlesource.com/1011862
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550548}
[modify] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/child/idle_helper_unittest.cc
[modify] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/common/scheduler_helper_unittest.cc
[modify] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/public/non_main_thread_scheduler.h
[modify] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/renderer/auto_advancing_virtual_time_domain_unittest.cc
[modify] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.cc
[modify] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler.cc
[rename] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_helper.cc
[rename] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_helper.h
[modify] https://crrev.com/8e190efbdd60c8a0c3cb4a62079e8469b13460fc/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dea26b734148b257a776f1516d52996e0521ed8b

commit dea26b734148b257a776f1516d52996e0521ed8b
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Fri Apr 13 16:51:04 2018

Scheduler: Rename WorkerGlobalScopeScheduler to WorkerScheduler

This is a follow-up CL for
https://chromium-review.googlesource.com/c/chromium/src/+/994552/12/third_party/blink/renderer/platform/scheduler/public/frame_or_worker_global_scope_scheduler.h#13

Bug: 826203
Change-Id: Id43950524c7f74f797942bc43b7f51c5abe805be
Reviewed-on: https://chromium-review.googlesource.com/1006837
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550651}
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/core/execution_context/execution_context.h
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/core/testing/null_execution_context.cc
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/core/testing/null_execution_context.h
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/core/workers/worker_thread.cc
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/core/workers/worker_thread.h
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/platform/scheduler/BUILD.gn
[rename] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/platform/scheduler/child/worker_scheduler.cc
[rename] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/platform/scheduler/child/worker_scheduler.h
[rename] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_unittest.cc
[rename] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/platform/scheduler/public/frame_or_worker_scheduler.h
[modify] https://crrev.com/dea26b734148b257a776f1516d52996e0521ed8b/third_party/blink/renderer/platform/scheduler/public/frame_scheduler.h

Project Member

Comment 18 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6df3a4b0c8c315e959daa80a94ce1646cf455fbd

commit 6df3a4b0c8c315e959daa80a94ce1646cf455fbd
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Apr 27 05:02:36 2018

scheduler: Rename WebScheduler to ThreadScheduler.

Scheduler classes are being renamed and relocated as part of scheduler
architecture refactoring.

The header file is moved to its new location: scheduler/public, since
the file is referred from Blink.

Bug: 826203
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1c28c5c59ea8a2efd42eb896d89cd7539df4f609
Reviewed-on: https://chromium-review.googlesource.com/1029794
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554311}
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/public/platform/web_thread.h
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/bindings/core/v8/rejected_promises.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/bindings/core/v8/v8_gc_for_context_dispose.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/bindings/core/v8/v8_idle_task_runner.h
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/css/threaded/multi_threaded_test_util.h
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/dom/computed_accessible_node.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/dom/idle_deadline.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/dom/idle_deadline_test.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/dom/presentation_attribute_style.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/dom/scripted_idle_task_controller.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/dom/scripted_idle_task_controller.h
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/fetch/data_consumer_handle_test_util.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/frame/root_frame_viewport_test.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/html/parser/html_document_parser.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/html/parser/html_parser_scheduler.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/inspector/thread_debugger.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/layout/layout_text.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/loader/navigation_scheduler.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/page/scoped_page_pauser.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/page/scoped_page_pauser.h
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/scheduler/throttling_test.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/script/script_runner.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/svg/graphics/svg_image_chrome_client.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/timing/worker_performance.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/workers/worker_global_scope.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/core/xmlhttprequest/xml_http_request_progress_event_throttle.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/modules/websockets/web_socket_handle_impl.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/graphics/begin_frame_provider.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/graphics/bitmap_image.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge_test.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_impl.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/graphics/test/fake_scrollable_area.h
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/heap/DEPS
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/heap/thread_state.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/loader/fetch/raw_resource.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/loader/fetch/raw_resource_test.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/mac/scroll_animator_mac.mm
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/scheduler/child/web_scheduler_impl.h
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.h
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.h
[rename] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/scheduler/public/thread_scheduler.h
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/scheduler/renderer/renderer_web_scheduler_impl.h
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.h
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/scheduler/utility/webthread_impl_for_utility_thread.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/scheduler/utility/webthread_impl_for_utility_thread.h
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/scroll/DEPS
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/scroll/scroll_animator_test.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/scroll/scrollable_area.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/scroll/scrollbar_test_suite.h
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/timer.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/timer_test.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/third_party/blink/renderer/platform/web_thread_supporting_gc.cc
[modify] https://crrev.com/6df3a4b0c8c315e959daa80a94ce1646cf455fbd/tools/v8_context_snapshot/v8_context_snapshot_generator.cc

Project Member

Comment 19 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a

commit 00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon May 07 07:04:38 2018

scheduler: Move various files in renderer/ to main_thread/.

This patch moves source files that only serve the main thread scheduler
from renderer/ to main_thread/, which is the new home for those files
after the ongoing scheduler architecture refactoring.

All moved headers are only included from main_thread/, with the
exception of auto_advancing_virtual_time_domain.h which is used by a
test in common/, which should be OK.

Bug: 826203
Change-Id: I7ea7594cca5c2ebf66805db0dfacd0183cc7a6d4
Reviewed-on: https://chromium-review.googlesource.com/1038944
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556386}
[modify] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[modify] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/DEPS
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain.cc
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain.h
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain_unittest.cc
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/deadline_task_runner.cc
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/deadline_task_runner.h
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/deadline_task_runner_unittest.cc
[modify] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/idle_time_estimator.cc
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/idle_time_estimator.h
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/idle_time_estimator_unittest.cc
[modify] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_helper.cc
[modify] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_helper.h
[modify] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.cc
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.h
[modify] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator.cc
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator.h
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator_unittest.cc
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/render_widget_signals.cc
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/render_widget_signals.h
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/render_widget_signals_unittest.cc
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/renderer_metrics_helper.cc
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/renderer_metrics_helper.h
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/renderer_metrics_helper_unittest.cc
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/task_cost_estimator.cc
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/task_cost_estimator.h
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/task_cost_estimator_unittest.cc
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/use_case.h
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/user_model.cc
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/user_model.h
[rename] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/user_model_unittest.cc
[modify] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/main_thread/web_render_widget_scheduling_state.cc
[modify] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/scheduler/test/fake_frame_scheduler.h
[modify] https://crrev.com/00e055a6bfc24bc8e55ecb68c9e1c9ab1307bf8a/third_party/blink/renderer/platform/timer_test.cc

Project Member

Comment 20 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84578181124fa6dabd79d44a6ca369b7fce68a19

commit 84578181124fa6dabd79d44a6ca369b7fce68a19
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon May 07 09:16:15 2018

scheduler: Merge WebSchedulerImpl into NonMainThreadScheduler.

As part of ongoing scheduler architecture refactoring, this patch
updates NonMainThreadScheduler so it can be used in place of
WebSchedulerImpl.

Specifically, this patch does the following:

* Let NonMainThreadScheduler inherit from ThreadScheduler (in addition
  to WebThreadScheduler).
* Implement required virtual functions.
* Remove WebSchedulerImpl instance from WebThreadImplForWorkerScheduler,
  and make it work with NonMainThreadScheduler.

Now, WebThreadImplForWorkerScheduler works without relying on
WebSchedulerImpl.

WebSchedulerImpl is still used by RendererWebSchedulerImpl, so the class
itself is not removed yet.

This patch adds post-constructor initialization to NonMainThreadScheduler
in order to initialize a member requiring a virtual function call. The
work is done in the Init() function which is now a non-virtual function
of the class, and the original virtual Init() function is renamed to
InitImpl(), which is called from Init().

Bug: 826203
Change-Id: I7499fb1df197b760e2289414020f7136e3545a46
Reviewed-on: https://chromium-review.googlesource.com/1032452
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556394}
[modify] https://crrev.com/84578181124fa6dabd79d44a6ca369b7fce68a19/third_party/blink/renderer/core/dom/idle_deadline_test.cc
[modify] https://crrev.com/84578181124fa6dabd79d44a6ca369b7fce68a19/third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
[modify] https://crrev.com/84578181124fa6dabd79d44a6ca369b7fce68a19/third_party/blink/renderer/platform/scheduler/child/web_scheduler_impl.cc
[modify] https://crrev.com/84578181124fa6dabd79d44a6ca369b7fce68a19/third_party/blink/renderer/platform/scheduler/child/web_scheduler_impl.h
[modify] https://crrev.com/84578181124fa6dabd79d44a6ca369b7fce68a19/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc
[modify] https://crrev.com/84578181124fa6dabd79d44a6ca369b7fce68a19/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.h
[modify] https://crrev.com/84578181124fa6dabd79d44a6ca369b7fce68a19/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc
[modify] https://crrev.com/84578181124fa6dabd79d44a6ca369b7fce68a19/third_party/blink/renderer/platform/scheduler/public/non_main_thread_scheduler.h
[modify] https://crrev.com/84578181124fa6dabd79d44a6ca369b7fce68a19/third_party/blink/renderer/platform/scheduler/public/thread_scheduler.h
[modify] https://crrev.com/84578181124fa6dabd79d44a6ca369b7fce68a19/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.cc
[modify] https://crrev.com/84578181124fa6dabd79d44a6ca369b7fce68a19/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.h
[modify] https://crrev.com/84578181124fa6dabd79d44a6ca369b7fce68a19/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler.cc
[modify] https://crrev.com/84578181124fa6dabd79d44a6ca369b7fce68a19/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc
[modify] https://crrev.com/84578181124fa6dabd79d44a6ca369b7fce68a19/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h

Project Member

Comment 21 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa72a22bdc4c38d293e7d21e04bb8963d9d37c2d

commit aa72a22bdc4c38d293e7d21e04bb8963d9d37c2d
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue May 08 07:35:45 2018

scheduler: Rename RendererMetricsHelper to MainThreadMetricsHelper.

This is a change suggested by altimin@ in <crrev.com/c/1038944>.

Bug: 826203
Change-Id: Ic4b772834fea28cfcf5ed92e12418e437ca92652
Reviewed-on: https://chromium-review.googlesource.com/1046869
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556717}
[modify] https://crrev.com/aa72a22bdc4c38d293e7d21e04bb8963d9d37c2d/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/aa72a22bdc4c38d293e7d21e04bb8963d9d37c2d/third_party/blink/renderer/platform/scheduler/child/metrics_helper.h
[rename] https://crrev.com/aa72a22bdc4c38d293e7d21e04bb8963d9d37c2d/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper.cc
[rename] https://crrev.com/aa72a22bdc4c38d293e7d21e04bb8963d9d37c2d/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper.h
[rename] https://crrev.com/aa72a22bdc4c38d293e7d21e04bb8963d9d37c2d/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper_unittest.cc
[modify] https://crrev.com/aa72a22bdc4c38d293e7d21e04bb8963d9d37c2d/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/aa72a22bdc4c38d293e7d21e04bb8963d9d37c2d/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/aa72a22bdc4c38d293e7d21e04bb8963d9d37c2d/third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator.h

Project Member

Comment 22 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35f88f0c5ba860dc45ce5c651b338ac510f8004e

commit 35f88f0c5ba860dc45ce5c651b338ac510f8004e
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon May 14 08:42:58 2018

Remove {WebMain,}ThreadScheduler::{Add,Remove}PendingNavigation().

All overridden implementations of ThreadScheduler's interfaces are
no-op, so they can be removed without breaking any functionalities.

WebMainThreadScheduler's interfaces actually have some implementation.
However, they are not used by any production code, and only a few
tests depend on them.

There functions are perhaps the remnants of past refactoring. Since
nobody seems to rely on them currently, they can be removed entirely.

Bug: 826203
Change-Id: Ic8efe0afe09270c080bc7706287937a6da354ae1
Reviewed-on: https://chromium-review.googlesource.com/1055142
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558226}
[modify] https://crrev.com/35f88f0c5ba860dc45ce5c651b338ac510f8004e/third_party/blink/public/platform/scheduler/test/fake_renderer_scheduler.h
[modify] https://crrev.com/35f88f0c5ba860dc45ce5c651b338ac510f8004e/third_party/blink/public/platform/scheduler/test/mock_renderer_scheduler.h
[modify] https://crrev.com/35f88f0c5ba860dc45ce5c651b338ac510f8004e/third_party/blink/public/platform/scheduler/web_main_thread_scheduler.h
[modify] https://crrev.com/35f88f0c5ba860dc45ce5c651b338ac510f8004e/third_party/blink/renderer/core/dom/idle_deadline_test.cc
[modify] https://crrev.com/35f88f0c5ba860dc45ce5c651b338ac510f8004e/third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
[modify] https://crrev.com/35f88f0c5ba860dc45ce5c651b338ac510f8004e/third_party/blink/renderer/core/loader/navigation_scheduler.cc
[modify] https://crrev.com/35f88f0c5ba860dc45ce5c651b338ac510f8004e/third_party/blink/renderer/core/loader/navigation_scheduler.h
[modify] https://crrev.com/35f88f0c5ba860dc45ce5c651b338ac510f8004e/third_party/blink/renderer/platform/scheduler/child/web_scheduler_impl.h
[modify] https://crrev.com/35f88f0c5ba860dc45ce5c651b338ac510f8004e/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/35f88f0c5ba860dc45ce5c651b338ac510f8004e/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/35f88f0c5ba860dc45ce5c651b338ac510f8004e/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
[modify] https://crrev.com/35f88f0c5ba860dc45ce5c651b338ac510f8004e/third_party/blink/renderer/platform/scheduler/public/non_main_thread_scheduler.h
[modify] https://crrev.com/35f88f0c5ba860dc45ce5c651b338ac510f8004e/third_party/blink/renderer/platform/scheduler/public/thread_scheduler.h
[modify] https://crrev.com/35f88f0c5ba860dc45ce5c651b338ac510f8004e/third_party/blink/renderer/platform/scheduler/test/fake_renderer_scheduler.cc

Project Member

Comment 23 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/539b9d26cab1fc0fd485f5e70978854089eed3f0

commit 539b9d26cab1fc0fd485f5e70978854089eed3f0
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon May 14 10:41:56 2018

Return scoped_refptr in ThreadScheduler::*TaskRunner().

This is a purely cosmetic change -- the behavior remains the same.

Currently, WebThreadScheduler::*TaskRunner() returns a scoped_refptr,
while ThreadScheduler::*TaskRunner() returns a raw pointer. This incon-
sistency causes a small trouble in a later patch, so this patch lets
those functions always return scoped_refptr.

Bug: 826203
Change-Id: Ie448c8bc39d395c27a2565a762222bb38e63c7e2
Reviewed-on: https://chromium-review.googlesource.com/1056894
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558254}
[modify] https://crrev.com/539b9d26cab1fc0fd485f5e70978854089eed3f0/third_party/blink/renderer/core/dom/idle_deadline_test.cc
[modify] https://crrev.com/539b9d26cab1fc0fd485f5e70978854089eed3f0/third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
[modify] https://crrev.com/539b9d26cab1fc0fd485f5e70978854089eed3f0/third_party/blink/renderer/platform/scheduler/child/web_scheduler_impl.cc
[modify] https://crrev.com/539b9d26cab1fc0fd485f5e70978854089eed3f0/third_party/blink/renderer/platform/scheduler/child/web_scheduler_impl.h
[modify] https://crrev.com/539b9d26cab1fc0fd485f5e70978854089eed3f0/third_party/blink/renderer/platform/scheduler/public/non_main_thread_scheduler.h
[modify] https://crrev.com/539b9d26cab1fc0fd485f5e70978854089eed3f0/third_party/blink/renderer/platform/scheduler/public/thread_scheduler.h
[modify] https://crrev.com/539b9d26cab1fc0fd485f5e70978854089eed3f0/third_party/blink/renderer/platform/scheduler/renderer/renderer_web_scheduler_impl.cc
[modify] https://crrev.com/539b9d26cab1fc0fd485f5e70978854089eed3f0/third_party/blink/renderer/platform/scheduler/renderer/renderer_web_scheduler_impl.h
[modify] https://crrev.com/539b9d26cab1fc0fd485f5e70978854089eed3f0/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler.cc

Project Member

Comment 24 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc39f455f396ecbbdb436afb6abd4e19119e3483

commit dc39f455f396ecbbdb436afb6abd4e19119e3483
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu May 17 08:17:26 2018

Merge RendererWebSchedulerImpl into MainThreadSchedulerImpl.

This patch moves virtual function implementation of Renderer-
WebSchedulerImpl to MainThreadSchedulerImpl, and remove Renderer-
WebSchedulerImpl. MainThreadSchedulerImpl now inherits from both
WebMainThreadScheduler and ThreadScheduler, just like NonMainThread-
Scheduler.

WebMainThreadScheduler and ThreadScheduler have a substantial number of
overlapping functions. They are implemented in MainThreadSchedulerImpl
at the same time, as those functions are compatible with each other's.
A future cleanup is planned to reduce the overlaps for a cleaner code
structure.

Bug: 826203
Change-Id: Ic32a1175b07a9f9e86123f4a70329b269758a841
Reviewed-on: https://chromium-review.googlesource.com/1058990
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559452}
[modify] https://crrev.com/dc39f455f396ecbbdb436afb6abd4e19119e3483/third_party/blink/renderer/core/dom/idle_deadline_test.cc
[modify] https://crrev.com/dc39f455f396ecbbdb436afb6abd4e19119e3483/third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
[modify] https://crrev.com/dc39f455f396ecbbdb436afb6abd4e19119e3483/third_party/blink/renderer/platform/scheduler/BUILD.gn
[delete] https://crrev.com/051869e84f6fd73f9c1708ffeaf18ab6d3e2c115/third_party/blink/renderer/platform/scheduler/child/web_scheduler_impl.cc
[delete] https://crrev.com/051869e84f6fd73f9c1708ffeaf18ab6d3e2c115/third_party/blink/renderer/platform/scheduler/child/web_scheduler_impl.h
[modify] https://crrev.com/dc39f455f396ecbbdb436afb6abd4e19119e3483/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc
[modify] https://crrev.com/dc39f455f396ecbbdb436afb6abd4e19119e3483/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/dc39f455f396ecbbdb436afb6abd4e19119e3483/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/dc39f455f396ecbbdb436afb6abd4e19119e3483/third_party/blink/renderer/platform/scheduler/public/non_main_thread_scheduler.h
[modify] https://crrev.com/dc39f455f396ecbbdb436afb6abd4e19119e3483/third_party/blink/renderer/platform/scheduler/public/thread_scheduler.h
[delete] https://crrev.com/051869e84f6fd73f9c1708ffeaf18ab6d3e2c115/third_party/blink/renderer/platform/scheduler/renderer/renderer_web_scheduler_impl.cc
[delete] https://crrev.com/051869e84f6fd73f9c1708ffeaf18ab6d3e2c115/third_party/blink/renderer/platform/scheduler/renderer/renderer_web_scheduler_impl.h
[modify] https://crrev.com/dc39f455f396ecbbdb436afb6abd4e19119e3483/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.cc
[modify] https://crrev.com/dc39f455f396ecbbdb436afb6abd4e19119e3483/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.h
[modify] https://crrev.com/dc39f455f396ecbbdb436afb6abd4e19119e3483/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler.cc

Project Member

Comment 25 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1ee639a707d712bd40c4c704a6ddd21f6846b7a

commit c1ee639a707d712bd40c4c704a6ddd21f6846b7a
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri May 18 10:45:28 2018

Add (NonMain)ThreadScheduler::Current().

The function returns the current thread's instance of ThreadScheduler.
This is an alias of the "Platform::Current()->CurrentThread()
->Scheduler()" idiom which is currently widely used in Blink, and all
such calls will be replaced with the shorter "ThreadScheduler
::Current()" call in the future.

This patch also adds similar NonMainThreadScheduler::Current(), which
DCHECKs the caller is on the right thread. When we add
MainThreadScheduler in the future (this is likely to happen), it will
also have the similar Current() function.

Bug: 826203
Change-Id: Iaba856ff37cb81a33cbdf4b558764ab5634adf84
Reviewed-on: https://chromium-review.googlesource.com/1065538
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559857}
[modify] https://crrev.com/c1ee639a707d712bd40c4c704a6ddd21f6846b7a/third_party/blink/renderer/platform/scheduler/BUILD.gn
[add] https://crrev.com/c1ee639a707d712bd40c4c704a6ddd21f6846b7a/third_party/blink/renderer/platform/scheduler/common/thread_scheduler.cc
[modify] https://crrev.com/c1ee639a707d712bd40c4c704a6ddd21f6846b7a/third_party/blink/renderer/platform/scheduler/public/non_main_thread_scheduler.h
[modify] https://crrev.com/c1ee639a707d712bd40c4c704a6ddd21f6846b7a/third_party/blink/renderer/platform/scheduler/public/thread_scheduler.h
[modify] https://crrev.com/c1ee639a707d712bd40c4c704a6ddd21f6846b7a/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler.cc

Project Member

Comment 26 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06d3b4517b9c527cf598ed3c6e2fb08456629acd

commit 06d3b4517b9c527cf598ed3c6e2fb08456629acd
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri May 18 14:33:56 2018

Move WebThreadScheduler::{Add,Remove}TaskObserver() to ThreadScheduler.

Those functions are not used by any Chromium (non-Blink) code, thus they
should not be exposed via Web interfaces.

This patch moves the functions to ThreadScheduler, which is the right
home for this kind of functions. As WebThreadScheduler and
ThreadScheduler's interfaces are implemented by the same concrete
class, the amount of the code changes are kept minimum.

Bug: 826203
Change-Id: Ifcbad156a7e3a2788294681ca544afdcba7faabd
Reviewed-on: https://chromium-review.googlesource.com/1065555
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559886}
[modify] https://crrev.com/06d3b4517b9c527cf598ed3c6e2fb08456629acd/third_party/blink/public/platform/scheduler/test/fake_renderer_scheduler.h
[modify] https://crrev.com/06d3b4517b9c527cf598ed3c6e2fb08456629acd/third_party/blink/public/platform/scheduler/web_thread_scheduler.h
[modify] https://crrev.com/06d3b4517b9c527cf598ed3c6e2fb08456629acd/third_party/blink/renderer/core/dom/idle_deadline_test.cc
[modify] https://crrev.com/06d3b4517b9c527cf598ed3c6e2fb08456629acd/third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
[modify] https://crrev.com/06d3b4517b9c527cf598ed3c6e2fb08456629acd/third_party/blink/renderer/platform/scheduler/public/thread_scheduler.h
[modify] https://crrev.com/06d3b4517b9c527cf598ed3c6e2fb08456629acd/third_party/blink/renderer/platform/scheduler/test/fake_renderer_scheduler.cc

Project Member

Comment 27 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fedbfc9af7dad212139bfd927838b1e42b9c2829

commit fedbfc9af7dad212139bfd927838b1e42b9c2829
Author: Yuta Kitamura <yutak@chromium.org>
Date: Wed May 23 07:47:45 2018

Remove redundant functions from WebThreadScheduler.

This patch removes CanExceedIdleDeadlineIfRequired() and
ShouldYieldForHighPriorityWork() from WebMainThreadScheduler. Those
functions are not meant to be exposed to Chromium via Web interfaces,
and ThreadScheduler is the proper home for them.

ThreadScheduler already has the declarations of the same functions,
so at this point the declarations in WebThreadScheduler are just
redundant -- we just need to remove them and we are good.

Bug: 826203
Change-Id: Iaef204c07d51088a21be9f34e03074c3eb8454d9
Reviewed-on: https://chromium-review.googlesource.com/1067278
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560997}
[modify] https://crrev.com/fedbfc9af7dad212139bfd927838b1e42b9c2829/third_party/blink/public/platform/scheduler/test/fake_renderer_scheduler.h
[modify] https://crrev.com/fedbfc9af7dad212139bfd927838b1e42b9c2829/third_party/blink/public/platform/scheduler/test/mock_renderer_scheduler.h
[modify] https://crrev.com/fedbfc9af7dad212139bfd927838b1e42b9c2829/third_party/blink/public/platform/scheduler/web_thread_scheduler.h
[modify] https://crrev.com/fedbfc9af7dad212139bfd927838b1e42b9c2829/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/fedbfc9af7dad212139bfd927838b1e42b9c2829/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
[modify] https://crrev.com/fedbfc9af7dad212139bfd927838b1e42b9c2829/third_party/blink/renderer/platform/scheduler/public/non_main_thread_scheduler.h
[modify] https://crrev.com/fedbfc9af7dad212139bfd927838b1e42b9c2829/third_party/blink/renderer/platform/scheduler/test/fake_renderer_scheduler.cc

Project Member

Comment 28 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/deb91bb2d0ef0182334d48b6fc27f5af07034665

commit deb91bb2d0ef0182334d48b6fc27f5af07034665
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue May 29 05:53:20 2018

Merge WebMainThreadScheduler into WebThreadScheduler.

The class hierarchy between WebThreadScheduler and WebMainThread-
Scheduler has been an issue because it creates a complex class hierarchy
in implementation classes.

This patch merge those classes into one and simplify the relationship.
The new virtual member functions added to WebThreadScheduler only works
for a scheduler created on the main thread. The caller is aware of
which scheduler it's calling, so this is OK.

TBR=kinuko@chromium.org,jrummell@chromium.org

Bug: 826203
Change-Id: I90f3aa9b4718575778f210298320fc1f3448646c
Reviewed-on: https://chromium-review.googlesource.com/1074916
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562347}
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/public/test/render_view_test.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/public/test/render_view_test.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/dom_storage/dom_storage_cached_area.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/dom_storage/dom_storage_cached_area.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/dom_storage/dom_storage_cached_area_unittest.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/dom_storage/local_storage_cached_area.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/dom_storage/local_storage_cached_area.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/dom_storage/local_storage_cached_area_unittest.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/dom_storage/local_storage_cached_areas.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/dom_storage/local_storage_cached_areas.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/gpu/compositor_dependencies.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/input/main_thread_event_queue.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/input/main_thread_event_queue.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/input/main_thread_event_queue_task.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/input/widget_input_handler_impl.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/input/widget_input_handler_manager.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/input/widget_input_handler_manager.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/render_thread_impl.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/render_thread_impl_browsertest.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/render_widget.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/renderer/renderer_main.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/test/fake_compositor_dependencies.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/test/fake_compositor_dependencies.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/test/layouttest_support.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/test/test_blink_web_unit_test_support.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/media/blink/run_all_unittests.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/third_party/blink/public/platform/scheduler/test/fake_renderer_scheduler.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/third_party/blink/public/platform/scheduler/test/mock_renderer_scheduler.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/third_party/blink/public/platform/scheduler/test/renderer_scheduler_test_support.h
[delete] https://crrev.com/09f54d5191ed8ca075da3934f9bc8a4c6cc65e70/third_party/blink/public/platform/scheduler/web_main_thread_scheduler.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/third_party/blink/public/platform/scheduler/web_thread_scheduler.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_test.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/third_party/blink/renderer/core/loader/navigation_scheduler.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/third_party/blink/renderer/core/scheduler/throttling_test.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/third_party/blink/renderer/platform/scheduler/common/thread_scheduler_impl.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/third_party/blink/renderer/platform/scheduler/common/web_thread_scheduler.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/third_party/blink/renderer/platform/scheduler/main_thread/user_model.h
[delete] https://crrev.com/09f54d5191ed8ca075da3934f9bc8a4c6cc65e70/third_party/blink/renderer/platform/scheduler/main_thread/web_main_thread_scheduler.cc
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/third_party/blink/renderer/platform/scheduler/public/thread_scheduler.h
[modify] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/third_party/blink/renderer/platform/scheduler/test/renderer_scheduler_test_support.cc

Project Member

Comment 29 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bec4e50aefb747902f07572a8efc2b9d7c496e60

commit bec4e50aefb747902f07572a8efc2b9d7c496e60
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu May 31 14:25:28 2018

Rename NonMainThreadScheduler to NonMainThreadSchedulerImpl.

The class does not contain anything that should be exposed to Blink.
Hence, the header file for this class should not belong to platform/
scheduler/public.

This patch moves the header to platform/scheduler/worker/, and rename
the class to NonMainThreadSchedulerImpl, so it can be recognized as
a class for scheduler-internal implementation.

Bug: 826203
Change-Id: Ic69f38b857f60271e89220d5ae1dec0cd8ca7299
Reviewed-on: https://chromium-review.googlesource.com/1078129
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563219}
[modify] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/core/dom/idle_deadline_test.cc
[modify] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
[modify] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/platform/scheduler/child/webthread_base.cc
[modify] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc
[modify] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.h
[modify] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/platform/scheduler/child/worker_task_queue.cc
[modify] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/platform/scheduler/child/worker_task_queue.h
[modify] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/platform/scheduler/public/thread_scheduler.h
[modify] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.cc
[modify] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.h
[delete] https://crrev.com/d7df96d788fd687a7c2ab2af0fb57d5d2206cc71/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler.cc
[modify] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_helper.cc
[modify] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_helper.h
[add] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_impl.cc
[rename] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_impl.h
[modify] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc
[modify] https://crrev.com/bec4e50aefb747902f07572a8efc2b9d7c496e60/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h

Project Member

Comment 30 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22c0396ff6222a7e98ce918e50efbfffa6f991be

commit 22c0396ff6222a7e98ce918e50efbfffa6f991be
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Jun 04 06:14:27 2018

Move MetricsHelper and its children to the new directories.

This patch moves files for MetricsHelper, WorkerMetricsHelper, and
CompositorMetricsHelper to the directories designated by the new
scheduler architecture.

Bug: 826203
Change-Id: I8ca04d9585a5284859f4bcac323d0b45ead57d7e
Reviewed-on: https://chromium-review.googlesource.com/1082062
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564003}
[modify] https://crrev.com/22c0396ff6222a7e98ce918e50efbfffa6f991be/third_party/blink/renderer/platform/scheduler/BUILD.gn
[rename] https://crrev.com/22c0396ff6222a7e98ce918e50efbfffa6f991be/third_party/blink/renderer/platform/scheduler/common/metrics_helper.cc
[rename] https://crrev.com/22c0396ff6222a7e98ce918e50efbfffa6f991be/third_party/blink/renderer/platform/scheduler/common/metrics_helper.h
[rename] https://crrev.com/22c0396ff6222a7e98ce918e50efbfffa6f991be/third_party/blink/renderer/platform/scheduler/common/metrics_helper_unittest.cc
[modify] https://crrev.com/22c0396ff6222a7e98ce918e50efbfffa6f991be/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper.h
[rename] https://crrev.com/22c0396ff6222a7e98ce918e50efbfffa6f991be/third_party/blink/renderer/platform/scheduler/worker/compositor_metrics_helper.cc
[rename] https://crrev.com/22c0396ff6222a7e98ce918e50efbfffa6f991be/third_party/blink/renderer/platform/scheduler/worker/compositor_metrics_helper.h
[modify] https://crrev.com/22c0396ff6222a7e98ce918e50efbfffa6f991be/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.h
[rename] https://crrev.com/22c0396ff6222a7e98ce918e50efbfffa6f991be/third_party/blink/renderer/platform/scheduler/worker/worker_metrics_helper.cc
[rename] https://crrev.com/22c0396ff6222a7e98ce918e50efbfffa6f991be/third_party/blink/renderer/platform/scheduler/worker/worker_metrics_helper.h
[modify] https://crrev.com/22c0396ff6222a7e98ce918e50efbfffa6f991be/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h

Project Member

Comment 31 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f355f667c9ec1f618568af2e60d755f74cefe903

commit f355f667c9ec1f618568af2e60d755f74cefe903
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Jun 04 08:38:15 2018

Rename and move WorkerTaskQueue.

The WorkerTaskQueue is actually for NonMainThreadScheduler, so it is
renamed to NonMainThreadTaskQueue. At the same time, the relevant files
are moved from scheduler/child/ to scheduler/worker/, which is the new
directory for worker-related files designated by the on-going scheduler
refactoring.

Bug: 826203
Change-Id: I3043ea9e182159978f94ff1bc8ef1af62a2029b0
Reviewed-on: https://chromium-review.googlesource.com/1082059
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564025}
[modify] https://crrev.com/f355f667c9ec1f618568af2e60d755f74cefe903/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/f355f667c9ec1f618568af2e60d755f74cefe903/third_party/blink/renderer/platform/scheduler/child/idle_helper_unittest.cc
[modify] https://crrev.com/f355f667c9ec1f618568af2e60d755f74cefe903/third_party/blink/renderer/platform/scheduler/common/scheduler_helper_unittest.cc
[modify] https://crrev.com/f355f667c9ec1f618568af2e60d755f74cefe903/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain_unittest.cc
[modify] https://crrev.com/f355f667c9ec1f618568af2e60d755f74cefe903/third_party/blink/renderer/platform/scheduler/worker/compositor_metrics_helper.cc
[modify] https://crrev.com/f355f667c9ec1f618568af2e60d755f74cefe903/third_party/blink/renderer/platform/scheduler/worker/compositor_metrics_helper.h
[modify] https://crrev.com/f355f667c9ec1f618568af2e60d755f74cefe903/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.cc
[modify] https://crrev.com/f355f667c9ec1f618568af2e60d755f74cefe903/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.h
[modify] https://crrev.com/f355f667c9ec1f618568af2e60d755f74cefe903/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_helper.cc
[modify] https://crrev.com/f355f667c9ec1f618568af2e60d755f74cefe903/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_helper.h
[modify] https://crrev.com/f355f667c9ec1f618568af2e60d755f74cefe903/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_impl.cc
[modify] https://crrev.com/f355f667c9ec1f618568af2e60d755f74cefe903/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_impl.h
[rename] https://crrev.com/f355f667c9ec1f618568af2e60d755f74cefe903/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_task_queue.cc
[rename] https://crrev.com/f355f667c9ec1f618568af2e60d755f74cefe903/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_task_queue.h
[modify] https://crrev.com/f355f667c9ec1f618568af2e60d755f74cefe903/third_party/blink/renderer/platform/scheduler/worker/worker_metrics_helper.cc
[modify] https://crrev.com/f355f667c9ec1f618568af2e60d755f74cefe903/third_party/blink/renderer/platform/scheduler/worker/worker_metrics_helper.h
[modify] https://crrev.com/f355f667c9ec1f618568af2e60d755f74cefe903/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc
[modify] https://crrev.com/f355f667c9ec1f618568af2e60d755f74cefe903/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h

Project Member

Comment 32 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1310f4cfacc91c35a1a20a12180b06e6098dfcd4

commit 1310f4cfacc91c35a1a20a12180b06e6098dfcd4
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Jun 04 09:56:54 2018

Move WorkerScheduler(Proxy) from scheduler/child/.

This patch moves files for WorkerScheduler and WorkerSchedulerProxy
from scheduler/child/ to the directories designated by the new
scheduler architecture plan. Out of those files, worker_thread.h is
used by Blink, so it is moved to scheduler/public/. Other files
go to scheduler/worker/.

Bug: 826203
Change-Id: I7c594979ceb25be8cca11b89f2cf2d3e05b1232b
Reviewed-on: https://chromium-review.googlesource.com/1082187
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564043}
[modify] https://crrev.com/1310f4cfacc91c35a1a20a12180b06e6098dfcd4/third_party/blink/renderer/core/loader/empty_clients.cc
[modify] https://crrev.com/1310f4cfacc91c35a1a20a12180b06e6098dfcd4/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h
[modify] https://crrev.com/1310f4cfacc91c35a1a20a12180b06e6098dfcd4/third_party/blink/renderer/core/workers/worker_thread.cc
[modify] https://crrev.com/1310f4cfacc91c35a1a20a12180b06e6098dfcd4/third_party/blink/renderer/core/workers/worker_thread.h
[modify] https://crrev.com/1310f4cfacc91c35a1a20a12180b06e6098dfcd4/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/1310f4cfacc91c35a1a20a12180b06e6098dfcd4/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc
[modify] https://crrev.com/1310f4cfacc91c35a1a20a12180b06e6098dfcd4/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/1310f4cfacc91c35a1a20a12180b06e6098dfcd4/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.h
[rename] https://crrev.com/1310f4cfacc91c35a1a20a12180b06e6098dfcd4/third_party/blink/renderer/platform/scheduler/public/worker_scheduler.h
[modify] https://crrev.com/1310f4cfacc91c35a1a20a12180b06e6098dfcd4/third_party/blink/renderer/platform/scheduler/test/fake_frame_scheduler.h
[rename] https://crrev.com/1310f4cfacc91c35a1a20a12180b06e6098dfcd4/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler.cc
[rename] https://crrev.com/1310f4cfacc91c35a1a20a12180b06e6098dfcd4/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_proxy.cc
[rename] https://crrev.com/1310f4cfacc91c35a1a20a12180b06e6098dfcd4/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_proxy.h
[rename] https://crrev.com/1310f4cfacc91c35a1a20a12180b06e6098dfcd4/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_proxy_unittest.cc
[rename] https://crrev.com/1310f4cfacc91c35a1a20a12180b06e6098dfcd4/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_unittest.cc
[modify] https://crrev.com/1310f4cfacc91c35a1a20a12180b06e6098dfcd4/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc

Project Member

Comment 33 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38cde10530353a0088ea0db847979e686cc9bb1b

commit 38cde10530353a0088ea0db847979e686cc9bb1b
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue Jun 05 07:28:26 2018

Move common scheduler classes from child/ to common/.

This patch moves CancelableClosureHoler, IdleCanceledDelayedTaskSweeper
and IdleHelper from scheduler/child/ to scheduler/common/. The child/
directory is now obsolete. These classes are for both main thread and
non-main thread schedulers, so they should be used to common/.

Bug: 826203
Change-Id: I967f922084c59b191ae127209e10127c17e9bbc7
Reviewed-on: https://chromium-review.googlesource.com/1084400
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564393}
[modify] https://crrev.com/38cde10530353a0088ea0db847979e686cc9bb1b/third_party/blink/renderer/platform/scheduler/BUILD.gn
[rename] https://crrev.com/38cde10530353a0088ea0db847979e686cc9bb1b/third_party/blink/renderer/platform/scheduler/common/cancelable_closure_holder.cc
[rename] https://crrev.com/38cde10530353a0088ea0db847979e686cc9bb1b/third_party/blink/renderer/platform/scheduler/common/cancelable_closure_holder.h
[rename] https://crrev.com/38cde10530353a0088ea0db847979e686cc9bb1b/third_party/blink/renderer/platform/scheduler/common/idle_canceled_delayed_task_sweeper.cc
[rename] https://crrev.com/38cde10530353a0088ea0db847979e686cc9bb1b/third_party/blink/renderer/platform/scheduler/common/idle_canceled_delayed_task_sweeper.h
[rename] https://crrev.com/38cde10530353a0088ea0db847979e686cc9bb1b/third_party/blink/renderer/platform/scheduler/common/idle_canceled_delayed_task_sweeper_unittest.cc
[rename] https://crrev.com/38cde10530353a0088ea0db847979e686cc9bb1b/third_party/blink/renderer/platform/scheduler/common/idle_helper.cc
[rename] https://crrev.com/38cde10530353a0088ea0db847979e686cc9bb1b/third_party/blink/renderer/platform/scheduler/common/idle_helper.h
[rename] https://crrev.com/38cde10530353a0088ea0db847979e686cc9bb1b/third_party/blink/renderer/platform/scheduler/common/idle_helper_unittest.cc
[modify] https://crrev.com/38cde10530353a0088ea0db847979e686cc9bb1b/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler.h
[modify] https://crrev.com/38cde10530353a0088ea0db847979e686cc9bb1b/third_party/blink/renderer/platform/scheduler/main_thread/deadline_task_runner.h
[modify] https://crrev.com/38cde10530353a0088ea0db847979e686cc9bb1b/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/38cde10530353a0088ea0db847979e686cc9bb1b/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h

Project Member

Comment 34 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36de615f81a60ad96f64d6d5c83a7db4af04df94

commit 36de615f81a60ad96f64d6d5c83a7db4af04df94
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue Jun 05 09:28:52 2018

Move PageVisibilityState from child/ to main_thread/.

This patch moves the files for PageVisibilityState from scheduler/child/
to scheduler/main_thread/, as this enum is only used in the main thread
scheduler. There were stale #includes in workers implementation, but
they are no longer used, so they are removed.

At the same time, the content of default_params.h is merged into
page_visibility_state.h, since the header only contains one constant
of type PageVisiblityState, and it seems not used for other purposes.

Bug: 826203
Change-Id: Iea1a141802c4dbffba22000daaaf1bbce1b214ac
Reviewed-on: https://chromium-review.googlesource.com/1084575
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564418}
[modify] https://crrev.com/36de615f81a60ad96f64d6d5c83a7db4af04df94/third_party/blink/renderer/platform/scheduler/BUILD.gn
[delete] https://crrev.com/b6b2fbe67a6ac774639bc007a3739026cd508472/third_party/blink/renderer/platform/scheduler/child/default_params.h
[delete] https://crrev.com/b6b2fbe67a6ac774639bc007a3739026cd508472/third_party/blink/renderer/platform/scheduler/child/page_visibility_state.h
[modify] https://crrev.com/36de615f81a60ad96f64d6d5c83a7db4af04df94/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/36de615f81a60ad96f64d6d5c83a7db4af04df94/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.h
[modify] https://crrev.com/36de615f81a60ad96f64d6d5c83a7db4af04df94/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc
[modify] https://crrev.com/36de615f81a60ad96f64d6d5c83a7db4af04df94/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.h
[rename] https://crrev.com/36de615f81a60ad96f64d6d5c83a7db4af04df94/third_party/blink/renderer/platform/scheduler/main_thread/page_visibility_state.cc
[add] https://crrev.com/36de615f81a60ad96f64d6d5c83a7db4af04df94/third_party/blink/renderer/platform/scheduler/main_thread/page_visibility_state.h
[modify] https://crrev.com/36de615f81a60ad96f64d6d5c83a7db4af04df94/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_proxy.h
[modify] https://crrev.com/36de615f81a60ad96f64d6d5c83a7db4af04df94/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc

Project Member

Comment 35 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16f38267b585c55732220f3ed58627e5fe496001

commit 16f38267b585c55732220f3ed58627e5fe496001
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Jun 11 06:55:14 2018

Remove PostIdleTask() from WebThreadBase.

The function is only used in a test, and no production code does not
rely on it. So it can be removed entirely. This simplifies the
implementation of each subclass of WebThreadBase.

Bug: 826203
Change-Id: I746a61b324d63fd189b8b8b6cbe496760dedad0e
Reviewed-on: https://chromium-review.googlesource.com/1092221
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565935}
[modify] https://crrev.com/16f38267b585c55732220f3ed58627e5fe496001/third_party/blink/public/platform/scheduler/child/webthread_base.h
[modify] https://crrev.com/16f38267b585c55732220f3ed58627e5fe496001/third_party/blink/renderer/platform/scheduler/child/webthread_base.cc
[modify] https://crrev.com/16f38267b585c55732220f3ed58627e5fe496001/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc
[modify] https://crrev.com/16f38267b585c55732220f3ed58627e5fe496001/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.h
[modify] https://crrev.com/16f38267b585c55732220f3ed58627e5fe496001/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc
[modify] https://crrev.com/16f38267b585c55732220f3ed58627e5fe496001/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.cc
[modify] https://crrev.com/16f38267b585c55732220f3ed58627e5fe496001/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.h
[modify] https://crrev.com/16f38267b585c55732220f3ed58627e5fe496001/third_party/blink/renderer/platform/scheduler/utility/webthread_impl_for_utility_thread.cc
[modify] https://crrev.com/16f38267b585c55732220f3ed58627e5fe496001/third_party/blink/renderer/platform/scheduler/utility/webthread_impl_for_utility_thread.h

Project Member

Comment 36 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/588611ac26084199b4e293c17dfe47e19c4a3b24

commit 588611ac26084199b4e293c17dfe47e19c4a3b24
Author: Yuta Kitamura <yutak@chromium.org>
Date: Wed Aug 01 08:54:02 2018

Pass main thread WebThread to Platform::Initialize().

The main thread's WebThread is currently owned by each embedder, but we
plan to have it owned by Platform and eventually stop exposing WebThread
to non-Blink directories.

Currently, Platform::CurrentThread() is used for two purposes: (1) to
obtain the pointer to the main thread WebThread object, and (2) to
return the current thread's WebThread object in thread-local storage.
This patch gets rid of (1) and move it to Platform::Initialize()'s
argument, so we can easily shift the ownership of WebThread in the
future.

TBR=eroman@chromium.org,kinuko@chromium.org,dalecurtis@chromium.org,jcivelli@chromium.org

Bug: 826203
Change-Id: I93608b13f6b84a47112865da486647afc46ab039
Reviewed-on: https://chromium-review.googlesource.com/1154854
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579733}
[modify] https://crrev.com/588611ac26084199b4e293c17dfe47e19c4a3b24/components/webcrypto/fuzzer_support.cc
[modify] https://crrev.com/588611ac26084199b4e293c17dfe47e19c4a3b24/content/ppapi_plugin/ppapi_thread.cc
[modify] https://crrev.com/588611ac26084199b4e293c17dfe47e19c4a3b24/content/public/test/render_view_test.cc
[modify] https://crrev.com/588611ac26084199b4e293c17dfe47e19c4a3b24/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/588611ac26084199b4e293c17dfe47e19c4a3b24/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/588611ac26084199b4e293c17dfe47e19c4a3b24/content/utility/utility_thread_impl.cc
[modify] https://crrev.com/588611ac26084199b4e293c17dfe47e19c4a3b24/media/blink/run_all_unittests.cc
[modify] https://crrev.com/588611ac26084199b4e293c17dfe47e19c4a3b24/services/data_decoder/image_decoder_impl_unittest.cc
[modify] https://crrev.com/588611ac26084199b4e293c17dfe47e19c4a3b24/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/588611ac26084199b4e293c17dfe47e19c4a3b24/third_party/blink/public/web/blink.h
[modify] https://crrev.com/588611ac26084199b4e293c17dfe47e19c4a3b24/third_party/blink/renderer/controller/blink_initializer.cc
[modify] https://crrev.com/588611ac26084199b4e293c17dfe47e19c4a3b24/third_party/blink/renderer/platform/exported/platform.cc
[modify] https://crrev.com/588611ac26084199b4e293c17dfe47e19c4a3b24/third_party/blink/renderer/platform/testing/image_decode_bench.cc
[modify] https://crrev.com/588611ac26084199b4e293c17dfe47e19c4a3b24/tools/v8_context_snapshot/v8_context_snapshot_generator.cc

Project Member

Comment 37 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/840ab30ddf08c31b478f95bea457005a15b1f426

commit 840ab30ddf08c31b478f95bea457005a15b1f426
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue Aug 07 04:52:31 2018

Let Platform own main thread in simple use cases.

Currently, the main thread WebThread is owned by the embedder. We'd
like to shift the ownership to Platform, so that we can stop exposing
WebThread to embedders.

As a first step, this patch introduces a new initialization method
Platform::CreateMainThreadAndInitialize(), which is parallel to
Platform::Initialize(). It is targeted to tests or other use cases
which only require a simple execution environment of Blink. Currently,
each embedder implements its own WebThread, but I'd like to unify
those and remove them from non-Blink code eventually.

The new CreateMainThreadAndInitialize() lets Platform own the main
thread WebThread object, unlike Initialize(). Currently, Platform
needs to handle two different cases: main thread owned or not owned,
but this is only temporary, and they will eventually converge to the
"owned" case.

As a test bed, v8_context_snapshot_generator is migrated to the
new initialization method.

Bug: 826203
Change-Id: I14436509f420a5d73f2ce64722f41da5756fa45b
Reviewed-on: https://chromium-review.googlesource.com/1163560
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581136}
[modify] https://crrev.com/840ab30ddf08c31b478f95bea457005a15b1f426/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/840ab30ddf08c31b478f95bea457005a15b1f426/third_party/blink/public/web/blink.h
[modify] https://crrev.com/840ab30ddf08c31b478f95bea457005a15b1f426/third_party/blink/renderer/controller/blink_initializer.cc
[modify] https://crrev.com/840ab30ddf08c31b478f95bea457005a15b1f426/third_party/blink/renderer/platform/exported/platform.cc
[modify] https://crrev.com/840ab30ddf08c31b478f95bea457005a15b1f426/tools/v8_context_snapshot/v8_context_snapshot_generator.cc

Project Member

Comment 38 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/092a8aa67d157dc68a1368d36a642d0d485f571e

commit 092a8aa67d157dc68a1368d36a642d0d485f571e
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue Aug 14 10:33:44 2018

Add Platform test helper allowing custom scheduler.

This patch adds a new test utility for Blink platform. It's called
TestingPlatformSupportWithCustomScheduler, and is a natural extension
of TestingPlatformSupport.

The new utility removes the need of writing custom Platform and
WebThread in tests. Essentially, the objective of this CL is to shift
the responsibility of writing custom WebThread from each test to
platform/testing. Two affected tests are rewritten to use it.

Bug: 826203
Change-Id: I41160fe50286adc3acb09dbd128d654c356d4355
Reviewed-on: https://chromium-review.googlesource.com/1170702
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582883}
[modify] https://crrev.com/092a8aa67d157dc68a1368d36a642d0d485f571e/third_party/blink/renderer/core/dom/idle_deadline_test.cc
[modify] https://crrev.com/092a8aa67d157dc68a1368d36a642d0d485f571e/third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
[modify] https://crrev.com/092a8aa67d157dc68a1368d36a642d0d485f571e/third_party/blink/renderer/platform/BUILD.gn
[add] https://crrev.com/092a8aa67d157dc68a1368d36a642d0d485f571e/third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.cc
[add] https://crrev.com/092a8aa67d157dc68a1368d36a642d0d485f571e/third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.h

Project Member

Comment 39 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/154c384eee687aaa068ad91ea51a0750b3c0fb44

commit 154c384eee687aaa068ad91ea51a0750b3c0fb44
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Aug 17 12:27:46 2018

Simplify initialization of utility thread.

Utility thread is a thread for utilities that make use of Blink.
Currently, the WebThread object for that thread is defined as
WebThreadImplForUtilityThread, but we can remove it if we initialize
Blink with blink::CreateMainThreadAndInitialize(), because the
utility thread does not require multi-thread nor other complex
functionalities.

UtilityBlinkPlatformImpl inherits from BlinkPlatformImpl, which is
a base class for blink::Platform defined in content/. This patch
makes it directly inherit from blink::Platform, since the utility
thread does not require functions defined in BlinkPlatformImpl --
BlinkPlatformImpl's functions are basically for full-fledged browser,
and we don't need them in the utility thread.

Bug: 826203
Change-Id: I57af86931af176ef5d1bd08d0f0ceb5e60d9d65b
Reviewed-on: https://chromium-review.googlesource.com/1175746
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584030}
[modify] https://crrev.com/154c384eee687aaa068ad91ea51a0750b3c0fb44/content/utility/BUILD.gn
[delete] https://crrev.com/9cfff7e247fc4eb1d4ffbef2eb8093a496812baa/content/utility/utility_blink_platform_impl.cc
[delete] https://crrev.com/9cfff7e247fc4eb1d4ffbef2eb8093a496812baa/content/utility/utility_blink_platform_impl.h
[modify] https://crrev.com/154c384eee687aaa068ad91ea51a0750b3c0fb44/content/utility/utility_blink_platform_with_sandbox_support_impl.h
[modify] https://crrev.com/154c384eee687aaa068ad91ea51a0750b3c0fb44/content/utility/utility_thread_impl.cc
[modify] https://crrev.com/154c384eee687aaa068ad91ea51a0750b3c0fb44/content/utility/utility_thread_impl.h
[modify] https://crrev.com/154c384eee687aaa068ad91ea51a0750b3c0fb44/services/data_decoder/image_decoder_impl_unittest.cc
[modify] https://crrev.com/154c384eee687aaa068ad91ea51a0750b3c0fb44/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/154c384eee687aaa068ad91ea51a0750b3c0fb44/third_party/blink/public/platform/scheduler/child/webthread_base.h
[modify] https://crrev.com/154c384eee687aaa068ad91ea51a0750b3c0fb44/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/154c384eee687aaa068ad91ea51a0750b3c0fb44/third_party/blink/renderer/platform/scheduler/child/webthread_base.cc
[delete] https://crrev.com/9cfff7e247fc4eb1d4ffbef2eb8093a496812baa/third_party/blink/renderer/platform/scheduler/utility/webthread_impl_for_utility_thread.cc
[delete] https://crrev.com/9cfff7e247fc4eb1d4ffbef2eb8093a496812baa/third_party/blink/renderer/platform/scheduler/utility/webthread_impl_for_utility_thread.h

Project Member

Comment 40 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3fdd9ceeda5917e86d019f597742296ae6f1026

commit c3fdd9ceeda5917e86d019f597742296ae6f1026
Author: Yuta Kitamura <yutak@chromium.org>
Date: Wed Aug 22 16:47:01 2018

Add DefaultThreadScheduler.

DefaultThreadScheduler is an instance of ThreadScheduler that is used
as the scheduler for the default thread, which is automatically
assigned to a thread that does not have specific scheduling
requirements. The default scheduler only implements a minimum amount
of functionalities so most of Blink functions could run.

SingleThreadedWebThread is now renamed to DefaultMainThread, because
it can be actually used as a main thread for multi-threaded Blink
Platform.

This patch enables more miscellaneous embedders to run Blink on
the default thread. They will be converted in follow-up patches.

Bug: 826203
Change-Id: I91d38bd17e10b376f3463e3cf013a51bb7797321
Reviewed-on: https://chromium-review.googlesource.com/1181014
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585081}
[modify] https://crrev.com/c3fdd9ceeda5917e86d019f597742296ae6f1026/third_party/blink/renderer/platform/exported/platform.cc
[modify] https://crrev.com/c3fdd9ceeda5917e86d019f597742296ae6f1026/third_party/blink/renderer/platform/scheduler/BUILD.gn
[add] https://crrev.com/c3fdd9ceeda5917e86d019f597742296ae6f1026/third_party/blink/renderer/platform/scheduler/common/simple_thread_scheduler.cc
[add] https://crrev.com/c3fdd9ceeda5917e86d019f597742296ae6f1026/third_party/blink/renderer/platform/scheduler/common/simple_thread_scheduler.h
[modify] https://crrev.com/c3fdd9ceeda5917e86d019f597742296ae6f1026/third_party/blink/renderer/platform/wtf/functional.h

Project Member

Comment 41 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dd9bf7c3cb249483c13480869f9cc6a364e5c94

commit 7dd9bf7c3cb249483c13480869f9cc6a364e5c94
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue Sep 11 02:31:59 2018

Fix compilation of image_decode_bench.

This binary was broken by me but left unnoticed because no bot executes
it. This test is simple and CreateMainThreadAndInitialize() would
suffice.

Bug: 826203
Change-Id: Icdf9e3941be862abbedc20086ee909447c28645f
Reviewed-on: https://chromium-review.googlesource.com/1206753
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590176}
[modify] https://crrev.com/7dd9bf7c3cb249483c13480869f9cc6a364e5c94/third_party/blink/renderer/platform/testing/image_decode_bench.cc

Project Member

Comment 42 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cc31c083bcd396f5b1fc09f324532af5b73dc89

commit 5cc31c083bcd396f5b1fc09f324532af5b73dc89
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue Sep 11 03:36:10 2018

Use SimpleThread and SimpleThreadScheduler in PpapiBlinkPlatform.

This CL lets PpapiThread use CreateMainThreadAndInitialize() so the
Platform class can create the main thread on behalf.

Previously, the code does not create an WebThread instance for the main
thread(!), and PpapiBlinkPlatform::CurrentThread() actually returns
nullptr on the main thread(!). This is because BlinkPlatformImpl::
CurrentThread() only cares about non-main threads created with
CreateThread(). This CL fixes this issue.

Bug: 826203
Change-Id: Icc1319e70da2d7c2a3ccaee0adb140df80cd496d
Reviewed-on: https://chromium-review.googlesource.com/1186019
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590188}
[modify] https://crrev.com/5cc31c083bcd396f5b1fc09f324532af5b73dc89/content/child/blink_platform_impl.cc
[modify] https://crrev.com/5cc31c083bcd396f5b1fc09f324532af5b73dc89/content/child/blink_platform_impl.h
[modify] https://crrev.com/5cc31c083bcd396f5b1fc09f324532af5b73dc89/content/ppapi_plugin/ppapi_blink_platform_impl.cc
[modify] https://crrev.com/5cc31c083bcd396f5b1fc09f324532af5b73dc89/content/ppapi_plugin/ppapi_blink_platform_impl.h
[modify] https://crrev.com/5cc31c083bcd396f5b1fc09f324532af5b73dc89/content/ppapi_plugin/ppapi_thread.cc
[modify] https://crrev.com/5cc31c083bcd396f5b1fc09f324532af5b73dc89/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/5cc31c083bcd396f5b1fc09f324532af5b73dc89/third_party/blink/renderer/platform/exported/platform.cc

Project Member

Comment 43 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7769feaf4594253ea7b0479269b7e8d359221f1f

commit 7769feaf4594253ea7b0479269b7e8d359221f1f
Author: Yuta Kitamura <yutak@chromium.org>
Date: Wed Sep 19 11:47:23 2018

Pass WebThreadScheduler to Platform::Initialize() instead of WebThread.

This CL changes the interface of Platform::Initialize() so each embedder just
needs to pass a WebThreadScheduler for the main thread. This simplifies the
Blink initialization and reduces the necessity of WebThread in content/ and
elsewhere.

Some dirty workaround is necessary to deal with the issue on blink_platform_
unittests. This test suite does not set up a global task environment; instead,
each test sets up one in its test fixture. This does not work well with how
SimpleMainThread works. See comments in the CL for details.

Bug: 826203
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id527762b9329ae15acfa90e64576573b992189c6
Reviewed-on: https://chromium-review.googlesource.com/1206171
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592368}
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/content/public/test/render_view_test.cc
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/content/public/test/render_view_test.h
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/content/test/test_blink_web_unit_test_support.h
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/media/blink/run_all_unittests.cc
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/third_party/blink/public/platform/web_thread.h
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/third_party/blink/public/web/blink.h
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/third_party/blink/renderer/controller/blink_initializer.cc
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/third_party/blink/renderer/platform/bindings/parkable_string_manager.cc
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/third_party/blink/renderer/platform/bindings/parkable_string_test.cc
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/third_party/blink/renderer/platform/blob/blob_bytes_provider_test.cc
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/third_party/blink/renderer/platform/blob/blob_data_test.cc
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/third_party/blink/renderer/platform/exported/platform.cc
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image_test.cc
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/third_party/blink/renderer/platform/scheduler/common/simple_thread_scheduler.cc
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/third_party/blink/renderer/platform/scheduler/common/simple_thread_scheduler.h
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/7769feaf4594253ea7b0479269b7e8d359221f1f/third_party/blink/renderer/platform/testing/testing_platform_support.h

Project Member

Comment 44 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a

commit 477a39d0c8a66b1b7d2e889c77298a0f65a61c0a
Author: Yuta Kitamura <yutak@chromium.org>
Date: Wed Sep 26 04:53:19 2018

Move thread-local store for WebThreads to Platform.

This CL moves the thread-local storage for Blink threads currently
stored in content::BlinkPlatformImpl to Platform, so that //content's
dependency to WebThread could be reduced further.

The responsibility of creating a physical thread (i.e. base::Thread)
is now shifted to Platform::CreateThread(). Platform also manages
the thread-local storage of WebThreads, making it possible for Platform
to implement CurrentThread() itself.

Platform::CreateThread() and CurrentThread() are no longer virtual;
now they are concrete functions implemented in Platform. It's a bit
unfortunate to have a fat implementation in Platform like this,
because Platform should be a pure interface to embedders. Eventually
we would like to move them to somewhere in platform/.

Bug: 826203
Change-Id: I4406c2f964f0e41e59ef367269b000e81eeb53aa
Reviewed-on: https://chromium-review.googlesource.com/1238094
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594221}
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/content/child/blink_platform_impl.cc
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/content/child/blink_platform_impl.h
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/content/ppapi_plugin/ppapi_blink_platform_impl.cc
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/content/ppapi_plugin/ppapi_blink_platform_impl.h
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/content/test/test_blink_web_unit_test_support.h
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/third_party/blink/public/platform/scheduler/child/webthread_base.h
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/third_party/blink/renderer/modules/animationworklet/animation_worklet_thread_test.cc
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/third_party/blink/renderer/modules/webaudio/audio_context_autoplay_test.cc
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/third_party/blink/renderer/modules/webaudio/audio_context_test.cc
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/third_party/blink/renderer/platform/exported/platform.cc
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/third_party/blink/renderer/platform/testing/testing_platform_support.h
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.cc
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.h
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc
[modify] https://crrev.com/477a39d0c8a66b1b7d2e889c77298a0f65a61c0a/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h

Project Member

Comment 45 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e256bfc6ebc191fa82ac64a28bf67e4ead1ffed

commit 4e256bfc6ebc191fa82ac64a28bf67e4ead1ffed
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu Sep 27 06:32:35 2018

Move compositor thread to Platform.

This CL moves the ownership of the compositor thread from RenderThread-
Impl to Platform in order to reduce //content's dependency to
WebThread.

Now Platform::CompositorThread() is a concrete member function, and
the compositor thread is initialized by Platform::Initialize-
CompositorThread(). Some components of //content require the task
runner of the compositor thread, so RenderThreadImpl::
compositor_task_runner() is still available.

Bug: 826203
Change-Id: I6fe71835d7b7671d8781744ec62561242c6be29f
Reviewed-on: https://chromium-review.googlesource.com/1245039
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594611}
[modify] https://crrev.com/4e256bfc6ebc191fa82ac64a28bf67e4ead1ffed/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/4e256bfc6ebc191fa82ac64a28bf67e4ead1ffed/content/renderer/render_thread_impl.h
[modify] https://crrev.com/4e256bfc6ebc191fa82ac64a28bf67e4ead1ffed/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/4e256bfc6ebc191fa82ac64a28bf67e4ead1ffed/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/4e256bfc6ebc191fa82ac64a28bf67e4ead1ffed/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/4e256bfc6ebc191fa82ac64a28bf67e4ead1ffed/third_party/blink/renderer/platform/exported/platform.cc
[modify] https://crrev.com/4e256bfc6ebc191fa82ac64a28bf67e4ead1ffed/third_party/blink/renderer/platform/scheduler/child/webthread_base.cc

Project Member

Comment 46 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/006f6e699eb2aa217234101edd2330b836596d00

commit 006f6e699eb2aa217234101edd2330b836596d00
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu Sep 27 07:51:22 2018

Remove const qualifier from WebThread::Scheduler().

This function returns a mutable pointer, thus it does not make sense to
have this function const-qualified.

Bug: 826203
Change-Id: I7ea049c9a86b79db7bab5e26bf16b0499d71a08d
Reviewed-on: https://chromium-review.googlesource.com/1247643
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594626}
[modify] https://crrev.com/006f6e699eb2aa217234101edd2330b836596d00/third_party/blink/public/platform/web_thread.h
[modify] https://crrev.com/006f6e699eb2aa217234101edd2330b836596d00/third_party/blink/renderer/platform/exported/platform.cc
[modify] https://crrev.com/006f6e699eb2aa217234101edd2330b836596d00/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc
[modify] https://crrev.com/006f6e699eb2aa217234101edd2330b836596d00/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.h
[modify] https://crrev.com/006f6e699eb2aa217234101edd2330b836596d00/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.cc
[modify] https://crrev.com/006f6e699eb2aa217234101edd2330b836596d00/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.h
[modify] https://crrev.com/006f6e699eb2aa217234101edd2330b836596d00/third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.cc

Project Member

Comment 47 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88c843775504c8beb480aae0f62c02791ecbb108

commit 88c843775504c8beb480aae0f62c02791ecbb108
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Sep 28 12:33:54 2018

Move most of compositor thread's initialization to Platform.

This CL moves most of the actual work of initializing compositor thread
from RenderThreadImpl to Platform. This further reduces //content's
dependency to WebThread.

A new virtual function is introduced to Platform so we can change the
thread priority of the created compositor thread on Linux, where we need
to talk to the browser process to change the thread priority.

Additionally, a new function Platform::CompositorThreadTaskRunner() is
introduced, because RenderThreadImpl needs to post tasks to the
compositor thread after the thread is initialized.

Bug: 826203
Change-Id: Ic80e6452cdfe8af25ae2b277125687854859d106
Reviewed-on: https://chromium-review.googlesource.com/1249424
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595063}
[modify] https://crrev.com/88c843775504c8beb480aae0f62c02791ecbb108/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/88c843775504c8beb480aae0f62c02791ecbb108/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/88c843775504c8beb480aae0f62c02791ecbb108/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/88c843775504c8beb480aae0f62c02791ecbb108/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/88c843775504c8beb480aae0f62c02791ecbb108/third_party/blink/renderer/platform/exported/platform.cc

Project Member

Comment 48 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9147ab6539b8a0b2a46e4e3f03129e9813f6ee7

commit f9147ab6539b8a0b2a46e4e3f03129e9813f6ee7
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Sep 28 12:48:20 2018

Remove stray forward declaration of WebThread.

Bug: 826203
Change-Id: I0d8a2ad46df93e3bf50b71a34b4abb315844a84e
Reviewed-on: https://chromium-review.googlesource.com/1250522
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595064}
[modify] https://crrev.com/f9147ab6539b8a0b2a46e4e3f03129e9813f6ee7/content/shell/renderer/layout_test/blink_test_runner.cc

Project Member

Comment 49 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5baea4261803130bbe7c08914eb7db311dacaa52

commit 5baea4261803130bbe7c08914eb7db311dacaa52
Author: Yuta Kitamura <yutak@chromium.org>
Date: Wed Oct 03 09:31:59 2018

Remove #includes of web_thread.h outside Blink.

Now, (almost) nobody uses blink::WebThread in non-Blink code. This CL
removes unused #include of web_thread.h in those files.

Note that two files related to testing were still using WebThread
indirectly. They call Platform()->MainThread()->GetTaskRunner() to
obtain a task runner. These calls were replaced with scheduler::
GetSingleThreadTaskRunnerForTesting().

Bug: 826203
Change-Id: I954eb67e99f76bd992f0bcdd73498cfdccba0726
Reviewed-on: https://chromium-review.googlesource.com/c/1255747
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596164}
[modify] https://crrev.com/5baea4261803130bbe7c08914eb7db311dacaa52/content/renderer/loader/web_url_request_util.cc
[modify] https://crrev.com/5baea4261803130bbe7c08914eb7db311dacaa52/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/5baea4261803130bbe7c08914eb7db311dacaa52/content/renderer/render_widget.cc
[modify] https://crrev.com/5baea4261803130bbe7c08914eb7db311dacaa52/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/5baea4261803130bbe7c08914eb7db311dacaa52/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/5baea4261803130bbe7c08914eb7db311dacaa52/content/shell/test_runner/BUILD.gn
[modify] https://crrev.com/5baea4261803130bbe7c08914eb7db311dacaa52/content/shell/test_runner/test_plugin.cc
[modify] https://crrev.com/5baea4261803130bbe7c08914eb7db311dacaa52/media/blink/run_all_unittests.cc
[modify] https://crrev.com/5baea4261803130bbe7c08914eb7db311dacaa52/tools/v8_context_snapshot/v8_context_snapshot_generator.cc

Project Member

Comment 50 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d9ef5ec1bc8954afd42162dd3c235580855b118

commit 0d9ef5ec1bc8954afd42162dd3c235580855b118
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Oct 05 05:25:15 2018

Rename WebThread to Thread, and don't expose it to //content.

This CL moves web_thread.h to blink/renderer/platform/scheduler/public
and renames WebThread to Thread, so this class can only be referred from
Blink.

All the existing #include lines are rewritten, but references to
WebThread in Blink are not renamed yet. The rename will happen in later
CLs. To make the migration easier, temporary aliases of old names are
added.

Bug: 826203
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3cc9d209fd0c53c8a6362321661a361602f12dd3
Reviewed-on: https://chromium-review.googlesource.com/c/1257473
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597001}
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/public/platform/scheduler/child/webthread_base.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/public/platform/scheduler/test/mock_renderer_scheduler.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/public/platform/scheduler/web_thread_scheduler.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/bindings/core/v8/rejected_promises.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/bindings/core/v8/script_promise_resolver_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/bindings/core/v8/script_streamer_thread.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/bindings/core/v8/script_streamer_thread.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/bindings/core/v8/v8_idle_task_runner.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/controller/blink_initializer.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/css/threaded/multi_threaded_test_util.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/dom/presentation_attribute_style.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/exported/web_associated_url_loader_impl_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/exported/web_plugin_container_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/frame/frame_serializer_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/frame/frame_test_helpers.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/frame/performance_monitor.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/frame/root_frame_viewport_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/html/canvas/canvas_font_cache.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/html/parser/html_document_parser.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/html/parser/html_parser_scheduler.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/html/track/vtt/vtt_region.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/imagebitmap/image_bitmap_factories.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/inspector/inspector_emulation_agent.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/inspector/inspector_trace_events.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/inspector/worker_inspector_controller.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/layout/layout_text.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/loader/long_task_detector.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/loader/long_task_detector.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/page/page_overlay_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/scheduler/throttling_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/script/script_runner.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/scroll/scroll_animator_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/scroll/scrollbar_test_suite.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/testing/null_execution_context.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/timing/worker_performance.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/workers/parent_execution_context_task_runners.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/workers/worker_backing_thread.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/workers/worker_thread.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/core/xmlhttprequest/xml_http_request_progress_event_throttle.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/modules/presentation/presentation_availability_state.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/modules/sensor/sensor_proxy_inspector_impl.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/modules/service_worker/service_worker_installed_scripts_manager_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/modules/service_worker/thread_safe_script_container_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/modules/service_worker/wait_until_observer.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/modules/storage/storage_controller.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/modules/webaudio/async_audio_decoder.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/modules/webaudio/audio_context_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/modules/webaudio/deferred_task_handler.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/modules/webaudio/offline_audio_destination_node.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/audio/DEPS
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/audio/audio_destination.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/audio/hrtf_database_loader.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/audio/push_pull_fifo_multithread_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/audio/push_pull_fifo_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/audio/reverb_convolver.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/audio/reverb_convolver.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/bindings/parkable_string_manager.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/bindings/v8_per_isolate_data.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/blob/DEPS
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/blob/blob_bytes_provider.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/exported/platform.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/fonts/DEPS
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/fonts/mac/font_cache_mac.mm
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/graphics/animation_worklet_mutator_dispatcher_impl.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/graphics/animation_worklet_mutator_dispatcher_impl_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/graphics/canvas_resource.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/graphics/deferred_image_decoder_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/graphics/image_frame_generator_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/graphics/mailbox_texture_holder.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/heap/DEPS
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/heap/gc_task_runner.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/heap/heap_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/heap/thread_state.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/loader/fetch/memory_cache.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/loader/fetch/raw_resource.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/loader/fetch/raw_resource_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/loader/fetch/resource_response_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/memory_coordinator.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/memory_coordinator.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/network/network_state_notifier_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/scheduler/BUILD.gn
[rename] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/scheduler/common/thread.cc
[rename] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/scheduler/public/thread.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/scheduler/public/thread_scheduler.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/scheduler/test/fake_renderer_scheduler.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/testing/unit_test_helpers.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/timer_test.cc
[modify] https://crrev.com/0d9ef5ec1bc8954afd42162dd3c235580855b118/third_party/blink/renderer/platform/web_thread_supporting_gc.h

Project Member

Comment 51 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/625d998496348a053dd112fc5b6c09364633882e

commit 625d998496348a053dd112fc5b6c09364633882e
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu Oct 11 09:04:06 2018

Rename WebThread to Thread in the entire code base.

The class is no longer exposed to //content and others. This CL rewrites
all the occurrences of the old name in the entire code base, and removes
the temoprary aliases.

Bug: 826203
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I98ef06a8cd87e168216257eb76ac8bad1c662ceb
Reviewed-on: https://chromium-review.googlesource.com/c/1261455
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598703}
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/public/platform/scheduler/child/webthread_base.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/public/platform/scheduler/test/fake_renderer_scheduler.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/public/platform/scheduler/test/mock_renderer_scheduler.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/public/platform/scheduler/web_thread_scheduler.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/bindings/core/v8/dom_wrapper_world_test.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/bindings/core/v8/script_streamer_thread.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/bindings/core/v8/script_streamer_thread.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/controller/blink_initializer.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/css/threaded/multi_threaded_test_util.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/dom/idle_deadline_test.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/fetch/data_consumer_handle_test_util.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/fetch/data_consumer_handle_test_util.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/html/canvas/canvas_font_cache.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/inspector/worker_inspector_controller.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/workers/dedicated_worker_test.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/workers/dedicated_worker_thread.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/workers/experimental/thread_pool.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/workers/shared_worker_thread.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/workers/threaded_worklet_test.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/workers/worker_backing_thread.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/workers/worker_backing_thread.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/workers/worker_thread.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/workers/worker_thread_test_helper.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/core/workers/worklet_thread_holder.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/modules/animationworklet/animation_worklet_thread.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/modules/service_worker/service_worker_installed_scripts_manager_test.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/modules/service_worker/service_worker_thread.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/modules/service_worker/thread_safe_script_container_test.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/modules/service_worker/web_embedded_worker_impl_test.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/modules/webaudio/audio_worklet_thread.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/modules/webaudio/offline_audio_destination_node.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/modules/webaudio/offline_audio_destination_node.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/modules/webdatabase/database_thread.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/audio/hrtf_database_loader.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/audio/hrtf_database_loader.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/audio/push_pull_fifo_multithread_test.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/audio/reverb_convolver.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/audio/reverb_convolver.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/exported/platform.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/graphics/animation_worklet_mutator_dispatcher_impl_test.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/graphics/deferred_image_decoder_test.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/graphics/image_frame_generator_test.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/graphics/mailbox_texture_holder.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/heap/gc_task_runner.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/heap/heap_test.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/heap/thread_state.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/loader/fetch/resource_response_test.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/memory_coordinator.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/memory_coordinator.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/scheduler/child/webthread_base.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/scheduler/common/simple_thread_scheduler.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/scheduler/common/simple_thread_scheduler.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/scheduler/common/web_thread_scheduler.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/scheduler/public/thread.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/scheduler/public/thread_scheduler.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/scheduler/test/fake_renderer_scheduler.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_impl.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_impl.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/web_thread_supporting_gc.cc
[modify] https://crrev.com/625d998496348a053dd112fc5b6c09364633882e/third_party/blink/renderer/platform/web_thread_supporting_gc.h

Project Member

Comment 52 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9deeac4682dc2c2a45fdf483c376c75011a09241

commit 9deeac4682dc2c2a45fdf483c376c75011a09241
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Oct 12 07:47:14 2018

Move thread-related functionalities in Platform to Thread.

This CL moves the most of implementation for Thread in Platform to
Thread, so the Platform would contain less implementation (ideally,
Platform should be a pure interface to embedders).

Previously the global state of threads was stored in Platform, and
this CL moves it to Thread. Now the thread-local storage for Blink
threads and the main and compositor thread objects are stored as
the global variable in thread.cc. This way, the threads state is
completely separated from Platform. Old threading functions in
Platform are deprecated now, and they will be migrated to Thread ones
later.

Due to those changes, some test utilities need to be updated. As the
state of threads is not stored in Platform, the tests that need to
override their main thread have to do that by themselves. To
facilitate this, two new utility classes, ScopedMainThreadOverrider
and ScopedSchedulerOverrider, are introduced, and TestingPlatform-
SupportWithCustomScheduler is removed in favor of the new utilities.

Bug: 826203
Change-Id: Ieb702dc85b7ffd75991055038f1165c2bfd7d058
Reviewed-on: https://chromium-review.googlesource.com/c/1273115
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599133}
[modify] https://crrev.com/9deeac4682dc2c2a45fdf483c376c75011a09241/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/9deeac4682dc2c2a45fdf483c376c75011a09241/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/9deeac4682dc2c2a45fdf483c376c75011a09241/third_party/blink/renderer/core/dom/idle_deadline_test.cc
[modify] https://crrev.com/9deeac4682dc2c2a45fdf483c376c75011a09241/third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
[modify] https://crrev.com/9deeac4682dc2c2a45fdf483c376c75011a09241/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/9deeac4682dc2c2a45fdf483c376c75011a09241/third_party/blink/renderer/platform/exported/platform.cc
[modify] https://crrev.com/9deeac4682dc2c2a45fdf483c376c75011a09241/third_party/blink/renderer/platform/scheduler/common/thread.cc
[modify] https://crrev.com/9deeac4682dc2c2a45fdf483c376c75011a09241/third_party/blink/renderer/platform/scheduler/public/thread.h
[add] https://crrev.com/9deeac4682dc2c2a45fdf483c376c75011a09241/third_party/blink/renderer/platform/testing/scoped_main_thread_overrider.cc
[add] https://crrev.com/9deeac4682dc2c2a45fdf483c376c75011a09241/third_party/blink/renderer/platform/testing/scoped_main_thread_overrider.h
[add] https://crrev.com/9deeac4682dc2c2a45fdf483c376c75011a09241/third_party/blink/renderer/platform/testing/scoped_scheduler_overrider.cc
[add] https://crrev.com/9deeac4682dc2c2a45fdf483c376c75011a09241/third_party/blink/renderer/platform/testing/scoped_scheduler_overrider.h
[modify] https://crrev.com/9deeac4682dc2c2a45fdf483c376c75011a09241/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[delete] https://crrev.com/68084907a40caccccb72dd14c0ad3139b97747f7/third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.cc
[delete] https://crrev.com/68084907a40caccccb72dd14c0ad3139b97747f7/third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.h
[modify] https://crrev.com/9deeac4682dc2c2a45fdf483c376c75011a09241/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc
[modify] https://crrev.com/9deeac4682dc2c2a45fdf483c376c75011a09241/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h

Project Member

Comment 53 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c56690c375a47ba4822e689acb3f6998c96791f9

commit c56690c375a47ba4822e689acb3f6998c96791f9
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Oct 22 10:52:12 2018

Merge WebThreadBase into Thread.

This CL melds WebThreadBase's implementation into Thread, and removes
WebThreadBase. Now WebThreadImpl* classes directly inherit from Thread.
This is part of WebThread refactoring effort.

The new implementation uses WTF::HashMap instead of std::map to store
the mapping of TaskObservers. TaskObserverAdapters are stored in
std::unique_ptr, so we don't need manual new/delete calls. Eventually,
we will migrate to base::MessageLoop::TaskObserver instead of Blink's
custom TaskObserver, which would eliminate this mapping object.

Thread::IsCurrentThread() is now implemented in terms of its thread-
local storage for Blink threads, just because we already have that
knowledge ourselves.

Also, {Add,Remove}Task{,Time}Observer() are simplified. Now the
internal versions of those functions are removed, and TaskObserver
functions are now non-virtual.

Bug: 826203
Change-Id: I5aa56c152543af8f0e0270db86aa0f51d619b4d5
Reviewed-on: https://chromium-review.googlesource.com/c/1283015
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601521}
[modify] https://crrev.com/c56690c375a47ba4822e689acb3f6998c96791f9/content/child/blink_platform_impl.cc
[modify] https://crrev.com/c56690c375a47ba4822e689acb3f6998c96791f9/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/c56690c375a47ba4822e689acb3f6998c96791f9/third_party/blink/public/BUILD.gn
[delete] https://crrev.com/32463438c420d2887617acec90ec57b4946b8884/third_party/blink/public/platform/scheduler/child/webthread_base.h
[modify] https://crrev.com/c56690c375a47ba4822e689acb3f6998c96791f9/third_party/blink/renderer/platform/exported/platform.cc
[modify] https://crrev.com/c56690c375a47ba4822e689acb3f6998c96791f9/third_party/blink/renderer/platform/scheduler/BUILD.gn
[delete] https://crrev.com/32463438c420d2887617acec90ec57b4946b8884/third_party/blink/renderer/platform/scheduler/child/webthread_base.cc
[modify] https://crrev.com/c56690c375a47ba4822e689acb3f6998c96791f9/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc
[modify] https://crrev.com/c56690c375a47ba4822e689acb3f6998c96791f9/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.h
[modify] https://crrev.com/c56690c375a47ba4822e689acb3f6998c96791f9/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc
[modify] https://crrev.com/c56690c375a47ba4822e689acb3f6998c96791f9/third_party/blink/renderer/platform/scheduler/common/thread.cc
[modify] https://crrev.com/c56690c375a47ba4822e689acb3f6998c96791f9/third_party/blink/renderer/platform/scheduler/public/thread.h
[modify] https://crrev.com/c56690c375a47ba4822e689acb3f6998c96791f9/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.cc
[modify] https://crrev.com/c56690c375a47ba4822e689acb3f6998c96791f9/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.h
[modify] https://crrev.com/c56690c375a47ba4822e689acb3f6998c96791f9/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
[modify] https://crrev.com/c56690c375a47ba4822e689acb3f6998c96791f9/third_party/blink/renderer/platform/testing/scoped_scheduler_overrider.cc
[modify] https://crrev.com/c56690c375a47ba4822e689acb3f6998c96791f9/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc

This last commit seems to have leaked wtf out into the world outside renderer which is wrong.

third_party/blink/renderer/platform/scheduler/public/thread.h which is a public (outside Blink) header started using third_party/blink/renderer/platform/wtf/hash_map.h which is blink internal code.

Not sure what it should use instead. std::unordered_map?
Yeah, public/ should use std::unordered_map as long as the code is guarded with INSIDE_BLINK.

Project Member

Comment 56 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b003fe6aeea58c44090da18797adeadc59f867e

commit 3b003fe6aeea58c44090da18797adeadc59f867e
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue Oct 23 15:03:48 2018

Rename WebThreadImplForRendererScheduler to MainThread.

This is part of ongoing refactoring on WebThread classes.

The new name is... so concise!

Bug: 826203
Change-Id: I3352f7688b7c7e689463dbac8debdd8c3c8c604c
Reviewed-on: https://chromium-review.googlesource.com/c/1295631
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601950}
[modify] https://crrev.com/3b003fe6aeea58c44090da18797adeadc59f867e/third_party/blink/renderer/platform/scheduler/BUILD.gn
[add] https://crrev.com/3b003fe6aeea58c44090da18797adeadc59f867e/third_party/blink/renderer/platform/scheduler/main_thread/main_thread.cc
[rename] https://crrev.com/3b003fe6aeea58c44090da18797adeadc59f867e/third_party/blink/renderer/platform/scheduler/main_thread/main_thread.h
[modify] https://crrev.com/3b003fe6aeea58c44090da18797adeadc59f867e/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[rename] https://crrev.com/3b003fe6aeea58c44090da18797adeadc59f867e/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_unittest.cc
[delete] https://crrev.com/b3ee872274aba63ff3b49712b554fe329c4e7e83/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.cc

Project Member

Comment 57 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18a8607ecd59e5507a259b06fe189680254ca24d

commit 18a8607ecd59e5507a259b06fe189680254ca24d
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue Oct 23 15:15:11 2018

Rename WebThreadImplForWorkerScheduler to WorkerThread.

This is part of refactoring on WebThread classes.

Bug: 826203
Change-Id: I9c2d86e7009aaa9a1053d662d114d8f00536d795
Reviewed-on: https://chromium-review.googlesource.com/c/1295761
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601952}
[modify] https://crrev.com/18a8607ecd59e5507a259b06fe189680254ca24d/third_party/blink/renderer/core/workers/worker_thread.cc
[modify] https://crrev.com/18a8607ecd59e5507a259b06fe189680254ca24d/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/18a8607ecd59e5507a259b06fe189680254ca24d/third_party/blink/renderer/platform/scheduler/common/thread.cc
[modify] https://crrev.com/18a8607ecd59e5507a259b06fe189680254ca24d/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_proxy_unittest.cc
[rename] https://crrev.com/18a8607ecd59e5507a259b06fe189680254ca24d/third_party/blink/renderer/platform/scheduler/worker/worker_thread.cc
[rename] https://crrev.com/18a8607ecd59e5507a259b06fe189680254ca24d/third_party/blink/renderer/platform/scheduler/worker/worker_thread.h
[rename] https://crrev.com/18a8607ecd59e5507a259b06fe189680254ca24d/third_party/blink/renderer/platform/scheduler/worker/worker_thread_unittest.cc

Project Member

Comment 58 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d133f2ce1ec9deaf918b150a7ebdf1b084479673

commit d133f2ce1ec9deaf918b150a7ebdf1b084479673
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu Oct 25 10:33:16 2018

Make Thread::TaskObserver an alias to base::MessageLoop's.

This is a simple refactoring that changes the type of the task observer
used in Blink. We still keep the type alias Thread::TaskObserver,
as we don't want to expose base::MessageLoop to Blink.

This CL also updates audit_non_blink_usage.py to allow base::
PendingTask in Blink.

Bug: 826203
Change-Id: I6ac75469abf92d171628dbaa14c330a344129f8b
Reviewed-on: https://chromium-review.googlesource.com/c/1295617
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602663}
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/controller/blink_initializer.cc
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/core/dom/idle_deadline_test.cc
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.h
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/core/html/canvas/canvas_font_cache.cc
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/core/html/canvas/canvas_font_cache.h
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/core/inspector/worker_inspector_controller.cc
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/core/inspector/worker_inspector_controller.h
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/core/workers/worker_thread.cc
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/core/workers/worker_thread.h
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.h
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/platform/heap/gc_task_runner.h
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/platform/scheduler/common/thread.cc
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_unittest.cc
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/platform/scheduler/public/thread.h
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/renderer/platform/scheduler/worker/worker_thread_unittest.cc
[modify] https://crrev.com/d133f2ce1ec9deaf918b150a7ebdf1b084479673/third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py

Project Member

Comment 59 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80c41c89a955099c33f3f0287c6c35e8735fd2a8

commit 80c41c89a955099c33f3f0287c6c35e8735fd2a8
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu Oct 25 10:38:37 2018

Move CompositorThread to a dedicated header.

This CL renames WebThreadForCompositor to CompositorThread, and moves
its definition to dedicated header and implementation files. This makes
it easier to locate its declaration.

Bug: 826203
Change-Id: I9ac8a48b22849adc1ae938f52827e665a96712ba
Reviewed-on: https://chromium-review.googlesource.com/c/1298825
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602665}
[modify] https://crrev.com/80c41c89a955099c33f3f0287c6c35e8735fd2a8/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/80c41c89a955099c33f3f0287c6c35e8735fd2a8/third_party/blink/renderer/platform/scheduler/common/thread.cc
[add] https://crrev.com/80c41c89a955099c33f3f0287c6c35e8735fd2a8/third_party/blink/renderer/platform/scheduler/worker/compositor_thread.cc
[add] https://crrev.com/80c41c89a955099c33f3f0287c6c35e8735fd2a8/third_party/blink/renderer/platform/scheduler/worker/compositor_thread.h

Project Member

Comment 60 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/548902a5c197b94b9cc55e72d518292fd434c4fa

commit 548902a5c197b94b9cc55e72d518292fd434c4fa
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Oct 26 07:05:16 2018

Spin off TaskObserver into a dedicated header.

This CL moves the definition of MessageLoopCurrent::TaskObserver to
an individual header task/task_observer.h.

The motivation of this change comes from crrev.com/c/1295617.
MessageLoop is going away soon(-ish?), and Blink doesn't want to depend
on base::MessageLoop. It makes more sense to have TaskObserver in a
stand-alone header, given this current situation.

This CL does not touch any use sites of TaskObserver. The alias
MessageLoop::TaskObserver is still available, pending future mass
replacements.

Bug: 826203
Change-Id: I9e17bae3586e29cb76b23f5e247307760dac9a1f
Reviewed-on: https://chromium-review.googlesource.com/c/1298944
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603015}
[modify] https://crrev.com/548902a5c197b94b9cc55e72d518292fd434c4fa/base/BUILD.gn
[modify] https://crrev.com/548902a5c197b94b9cc55e72d518292fd434c4fa/base/message_loop/message_loop.h
[modify] https://crrev.com/548902a5c197b94b9cc55e72d518292fd434c4fa/base/message_loop/message_loop_current.h
[add] https://crrev.com/548902a5c197b94b9cc55e72d518292fd434c4fa/base/task/task_observer.h

Project Member

Comment 61 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/928e83a1536b47c59c48bdd7c6c04d231b2f8988

commit 928e83a1536b47c59c48bdd7c6c04d231b2f8988
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Oct 29 07:40:57 2018

Move the rest of files in renderer/ to main_thread/.

The directory structure for Blink scheduler is changing, and those files
should live in scheduler/main_thread/.

Bug: 826203
Change-Id: Iff32a4b8d53788e096d86cd6bef74da7978d1c44
Reviewed-on: https://chromium-review.googlesource.com/c/1301694
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603433}
[modify] https://crrev.com/928e83a1536b47c59c48bdd7c6c04d231b2f8988/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc
[modify] https://crrev.com/928e83a1536b47c59c48bdd7c6c04d231b2f8988/third_party/blink/renderer/platform/scheduler/BUILD.gn
[rename] https://crrev.com/928e83a1536b47c59c48bdd7c6c04d231b2f8988/third_party/blink/renderer/platform/scheduler/main_thread/frame_status.cc
[modify] https://crrev.com/928e83a1536b47c59c48bdd7c6c04d231b2f8988/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper.h
[rename] https://crrev.com/928e83a1536b47c59c48bdd7c6c04d231b2f8988/third_party/blink/renderer/platform/scheduler/main_thread/web_scoped_virtual_time_pauser.cc
[rename] https://crrev.com/928e83a1536b47c59c48bdd7c6c04d231b2f8988/third_party/blink/renderer/platform/scheduler/public/frame_status.h
[delete] https://crrev.com/ac04838679d7ecbdfad91a613b05a9d31e734708/third_party/blink/renderer/platform/scheduler/renderer/DEPS
[modify] https://crrev.com/928e83a1536b47c59c48bdd7c6c04d231b2f8988/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_proxy.h
[modify] https://crrev.com/928e83a1536b47c59c48bdd7c6c04d231b2f8988/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h

Project Member

Comment 62 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f59ad55600587daaa95f89f8a6e95074487e75bc

commit f59ad55600587daaa95f89f8a6e95074487e75bc
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Oct 29 08:45:59 2018

Move the rest of files in child/ to common/.

The directory structure for Blink scheduler is changing. Those files are
thread-neutral utilities, so they should go to scheduler/common/.

Bug: 826203
Change-Id: I9c1fa854af7cd11c36060fc0ba8ee19ed3404a6f
Reviewed-on: https://chromium-review.googlesource.com/c/1301699
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603440}
[modify] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/BUILD.gn
[delete] https://crrev.com/7541b56dd3d7472c4c6e57a07e96a12bfd0df6df/third_party/blink/renderer/platform/scheduler/child/DEPS
[delete] https://crrev.com/7541b56dd3d7472c4c6e57a07e96a12bfd0df6df/third_party/blink/renderer/platform/scheduler/child/OWNERS
[rename] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/common/features.cc
[rename] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/common/features.h
[modify] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/common/metrics_helper.cc
[rename] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/common/pollable_thread_safe_flag.cc
[rename] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/common/pollable_thread_safe_flag.h
[rename] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/common/process_state.cc
[rename] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/common/process_state.h
[rename] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/common/single_thread_idle_task_runner.cc
[modify] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
[modify] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/main_thread/prioritize_compositing_after_input_experiment.cc
[modify] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.cc
[modify] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler_unittest.cc
[modify] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/worker/worker_metrics_helper.cc
[modify] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc
[modify] https://crrev.com/f59ad55600587daaa95f89f8a6e95074487e75bc/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler_unittest.cc

Project Member

Comment 63 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30db604e9913b7c0dfa09398d8e0538ec3abecec

commit 30db604e9913b7c0dfa09398d8e0538ec3abecec
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Oct 29 12:40:53 2018

Move files in util/ to common/.

The directory structure for Blink scheduler is changing. The new
convention deprecates util/ and the files in util/ should go to
common/ now. Headers used by non-scheduler code are moved to
public/.

Bug: 826203
Change-Id: I617deec92f3d34fc0bc82e3211bdd223e90339be
Reviewed-on: https://chromium-review.googlesource.com/c/1301578
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603471}
[modify] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/core/inspector/inspector_emulation_agent.cc
[modify] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc
[modify] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/BUILD.gn
[rename] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/common/thread_cpu_throttler.cc
[rename] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/common/thread_load_tracker.cc
[rename] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/common/thread_load_tracker.h
[rename] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/common/thread_load_tracker_unittest.cc
[modify] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/common/throttling/cpu_time_budget_pool.h
[modify] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler.h
[modify] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/common/throttling/wake_up_budget_pool.cc
[rename] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/common/tracing_helper.cc
[rename] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/common/tracing_helper.h
[rename] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/common/tracing_helper_unittest.cc
[modify] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/common/web_thread_scheduler.cc
[modify] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.h
[modify] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/main_thread/frame_task_queue_controller.cc
[modify] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper.h
[modify] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.h
[rename] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/public/aggregated_metric_reporter.h
[rename] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/public/thread_cpu_throttler.h
[modify] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_impl.h
[modify] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/worker/worker_metrics_helper.h
[modify] https://crrev.com/30db604e9913b7c0dfa09398d8e0538ec3abecec/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h

Project Member

Comment 64 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/085dd3755b1ee516be421135b8464bf6a6d6a975

commit 085dd3755b1ee516be421135b8464bf6a6d6a975
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Nov 02 10:13:18 2018

Use ThreadScheduler::Current() in core/.

This CL replaces the occurrences of "Platform::Current()
->CurrentThread()->Scheduler()" with "ThreadScheduler::Current()"
which has the same meaning.

Bug: 826203
Change-Id: I53ef4f8682620b217d8cb6158a3a3106ae75eb06
Reviewed-on: https://chromium-review.googlesource.com/c/1314080
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604876}
[modify] https://crrev.com/085dd3755b1ee516be421135b8464bf6a6d6a975/third_party/blink/renderer/core/dom/idle_deadline.cc
[modify] https://crrev.com/085dd3755b1ee516be421135b8464bf6a6d6a975/third_party/blink/renderer/core/dom/scripted_idle_task_controller.cc
[modify] https://crrev.com/085dd3755b1ee516be421135b8464bf6a6d6a975/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/085dd3755b1ee516be421135b8464bf6a6d6a975/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.cc
[modify] https://crrev.com/085dd3755b1ee516be421135b8464bf6a6d6a975/third_party/blink/renderer/core/html/parser/html_parser_scheduler.cc
[modify] https://crrev.com/085dd3755b1ee516be421135b8464bf6a6d6a975/third_party/blink/renderer/core/inspector/thread_debugger.cc
[modify] https://crrev.com/085dd3755b1ee516be421135b8464bf6a6d6a975/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/085dd3755b1ee516be421135b8464bf6a6d6a975/third_party/blink/renderer/core/page/scoped_page_pauser.cc
[modify] https://crrev.com/085dd3755b1ee516be421135b8464bf6a6d6a975/third_party/blink/renderer/core/scheduler/throttling_test.cc
[modify] https://crrev.com/085dd3755b1ee516be421135b8464bf6a6d6a975/third_party/blink/renderer/core/scroll/scroll_animator_mac.mm
[modify] https://crrev.com/085dd3755b1ee516be421135b8464bf6a6d6a975/third_party/blink/renderer/core/scroll/scrollable_area.cc
[modify] https://crrev.com/085dd3755b1ee516be421135b8464bf6a6d6a975/third_party/blink/renderer/core/svg/graphics/svg_image_chrome_client.cc
[modify] https://crrev.com/085dd3755b1ee516be421135b8464bf6a6d6a975/third_party/blink/renderer/core/timing/window_performance.cc

Project Member

Comment 65 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d92e9e2a19a0c49115cab107e073d5f7d8cc156

commit 7d92e9e2a19a0c49115cab107e073d5f7d8cc156
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Nov 05 07:06:41 2018

Use ThreadScheduler::Current() in bindings/.

This CL replaces the occurrences of "Platform::Current()
->CurrentThread()->Scheduler()" with "ThreadScheduler::Current()"
which has the same meaning.

Also, this CL simplifies the code that assumes Thread::Scheduler()
can be null, which is no longer true.

Bug: 826203
Change-Id: I994db5b3be6e5e0f29cfe346dac15b49ca40394e
Reviewed-on: https://chromium-review.googlesource.com/c/1314079
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605271}
[modify] https://crrev.com/7d92e9e2a19a0c49115cab107e073d5f7d8cc156/third_party/blink/renderer/bindings/core/v8/v8_gc_for_context_dispose.cc
[modify] https://crrev.com/7d92e9e2a19a0c49115cab107e073d5f7d8cc156/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc

Project Member

Comment 66 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5784428aeecddba5108ea95d969090e306bf3099

commit 5784428aeecddba5108ea95d969090e306bf3099
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Nov 05 07:25:10 2018

Move IdleTaskRunner() from WebThreadScheduler to ThreadSchedulerImpl.

The virtual function IdleTaskRunner() defined in WebThreadScheduler is
not used by anybody except the scheduler internal code, so it should be
defined in ThreadSchedulerImpl instead. Along with that function, the
header for SingleThreadIdleTaskRunner is moved to scheduler/common, as
it's only used in combination with IdleTaskRunner().

SingleThreadIdleTaskRunner uses base::RefCountedThreadSafe which is
banned, but this can't be replaced with WTF::ThreadSafeRefCounted,
because MainThreadSchedulerImpl having a SingleThreadIdleTaskRunner
is instantiated before PartitionAlloc is initialized. The presubmit
script is modified so it would allow the usage of base::RefCounted
just for this file.

Bug: 826203
Change-Id: I2ddcbe9a9a1af6bce5cd87e9d097be86641703fe
Reviewed-on: https://chromium-review.googlesource.com/c/1306951
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605273}
[modify] https://crrev.com/5784428aeecddba5108ea95d969090e306bf3099/content/renderer/input/main_thread_event_queue.h
[modify] https://crrev.com/5784428aeecddba5108ea95d969090e306bf3099/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/5784428aeecddba5108ea95d969090e306bf3099/third_party/blink/public/platform/scheduler/test/fake_renderer_scheduler.h
[modify] https://crrev.com/5784428aeecddba5108ea95d969090e306bf3099/third_party/blink/public/platform/scheduler/test/mock_renderer_scheduler.h
[modify] https://crrev.com/5784428aeecddba5108ea95d969090e306bf3099/third_party/blink/public/platform/scheduler/web_thread_scheduler.h
[modify] https://crrev.com/5784428aeecddba5108ea95d969090e306bf3099/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/5784428aeecddba5108ea95d969090e306bf3099/third_party/blink/renderer/platform/scheduler/common/idle_canceled_delayed_task_sweeper.h
[modify] https://crrev.com/5784428aeecddba5108ea95d969090e306bf3099/third_party/blink/renderer/platform/scheduler/common/idle_helper.h
[modify] https://crrev.com/5784428aeecddba5108ea95d969090e306bf3099/third_party/blink/renderer/platform/scheduler/common/single_thread_idle_task_runner.cc
[rename] https://crrev.com/5784428aeecddba5108ea95d969090e306bf3099/third_party/blink/renderer/platform/scheduler/common/single_thread_idle_task_runner.h
[modify] https://crrev.com/5784428aeecddba5108ea95d969090e306bf3099/third_party/blink/renderer/platform/scheduler/common/thread_scheduler_impl.h
[modify] https://crrev.com/5784428aeecddba5108ea95d969090e306bf3099/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/5784428aeecddba5108ea95d969090e306bf3099/third_party/blink/renderer/platform/scheduler/test/fake_renderer_scheduler.cc
[modify] https://crrev.com/5784428aeecddba5108ea95d969090e306bf3099/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.h
[modify] https://crrev.com/5784428aeecddba5108ea95d969090e306bf3099/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_impl.h
[modify] https://crrev.com/5784428aeecddba5108ea95d969090e306bf3099/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h
[modify] https://crrev.com/5784428aeecddba5108ea95d969090e306bf3099/third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py

Project Member

Comment 67 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef055860c03c5b0be3d90a7cf84193c0c5c3f6b1

commit ef055860c03c5b0be3d90a7cf84193c0c5c3f6b1
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Nov 05 07:34:03 2018

Use ThreadScheduler::Current() in platform/.

This CL replaces the occurrences of "Platform::Current()
->CurrentThread()->Scheduler()" with "ThreadScheduler::Current()"
which has the same meaning.

Also, this CL simplifies the code that assumes Platform::CurrentThread()
or Thread::Scheduler() can return null, which is no longer true.

Bug: 826203
Change-Id: I0a59ef17be978d3a4d8b229dc19069aeb0a4c2f1
Reviewed-on: https://chromium-review.googlesource.com/c/1314084
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605275}
[modify] https://crrev.com/ef055860c03c5b0be3d90a7cf84193c0c5c3f6b1/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.cc
[modify] https://crrev.com/ef055860c03c5b0be3d90a7cf84193c0c5c3f6b1/third_party/blink/renderer/platform/graphics/begin_frame_provider.cc
[modify] https://crrev.com/ef055860c03c5b0be3d90a7cf84193c0c5c3f6b1/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/ef055860c03c5b0be3d90a7cf84193c0c5c3f6b1/third_party/blink/renderer/platform/heap/thread_state.cc
[modify] https://crrev.com/ef055860c03c5b0be3d90a7cf84193c0c5c3f6b1/third_party/blink/renderer/platform/scheduler/public/thread_scheduler.h
[modify] https://crrev.com/ef055860c03c5b0be3d90a7cf84193c0c5c3f6b1/third_party/blink/renderer/platform/timer.cc

Project Member

Comment 68 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1485506bb2f3e14c9129071dc14967d8819c0985

commit 1485506bb2f3e14c9129071dc14967d8819c0985
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue Nov 06 04:45:24 2018

Use Thread::Current()/MainThread() in core/.

This CL simplifies lengthy function calls via Platform::Current() that
obtain the current thread and the main thread by using Thread::Current()
and Thread::MainThread().

Bug: 826203
Change-Id: I18a106751518e361aecfb6e82152359c1b00f3d1
Reviewed-on: https://chromium-review.googlesource.com/c/1319129
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605595}
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/exported/web_associated_url_loader_impl.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/fetch/data_consumer_handle_test_util.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/frame/frame_test_helpers.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/frame/performance_monitor.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator_test.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/html/canvas/canvas_font_cache.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/html/track/vtt/vtt_region.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/imagebitmap/image_bitmap_factories.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/inspector/inspector_performance_agent.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/loader/idleness_detector.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/loader/interactive_detector_test.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/loader/link_loader_test.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/loader/long_task_detector.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/loader/long_task_detector_test.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/loader/resource/image_resource.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/script/module_map_test.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/testing/null_execution_context.cc
[modify] https://crrev.com/1485506bb2f3e14c9129071dc14967d8819c0985/third_party/blink/renderer/core/workers/parent_execution_context_task_runners.cc

Project Member

Comment 69 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc7a25ffa792162a254a96e8aa60dc33be696017

commit bc7a25ffa792162a254a96e8aa60dc33be696017
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue Nov 06 05:27:02 2018

Use Thread::Current()/MainThread() in bindings/ and controller/.

This CL simplifies lengthy function calls via Platform::Current() that
obtain the current thread and the main thread by using Thread::Current()
and Thread::MainThread().

Also now-redundant null checks for those functions are removed.

Bug: 826203
Change-Id: Iedfd7f09b5334dc84fa921cdca84ca39ad9b3af9
Reviewed-on: https://chromium-review.googlesource.com/c/1318773
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605600}
[modify] https://crrev.com/bc7a25ffa792162a254a96e8aa60dc33be696017/third_party/blink/renderer/bindings/core/v8/dom_wrapper_world_test.cc
[modify] https://crrev.com/bc7a25ffa792162a254a96e8aa60dc33be696017/third_party/blink/renderer/controller/blink_initializer.cc
[modify] https://crrev.com/bc7a25ffa792162a254a96e8aa60dc33be696017/third_party/blink/renderer/controller/blink_leak_detector.cc
[modify] https://crrev.com/bc7a25ffa792162a254a96e8aa60dc33be696017/third_party/blink/renderer/controller/oom_intervention_impl.cc

Project Member

Comment 70 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/081f13905a0e46efd20b3cac697610f97ecfd54b

commit 081f13905a0e46efd20b3cac697610f97ecfd54b
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue Nov 06 08:29:13 2018

Use Thread::Current()/MainThread() in modules/.

This CL simplifies lengthy function calls via Platform::Current() that
obtain the current thread and the main thread by using Thread::Current()
and Thread::MainThread().

Bug: 826203
Change-Id: I36300b006e48a90c64f0a55579bfc22195da320b
Reviewed-on: https://chromium-review.googlesource.com/c/1319217
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605631}
[modify] https://crrev.com/081f13905a0e46efd20b3cac697610f97ecfd54b/third_party/blink/renderer/modules/background_fetch/background_fetch_icon_loader.cc
[modify] https://crrev.com/081f13905a0e46efd20b3cac697610f97ecfd54b/third_party/blink/renderer/modules/media_controls/media_controls_orientation_lock_delegate_test.cc
[modify] https://crrev.com/081f13905a0e46efd20b3cac697610f97ecfd54b/third_party/blink/renderer/modules/presentation/presentation_availability_state.cc
[modify] https://crrev.com/081f13905a0e46efd20b3cac697610f97ecfd54b/third_party/blink/renderer/modules/sensor/sensor_proxy_inspector_impl.cc
[modify] https://crrev.com/081f13905a0e46efd20b3cac697610f97ecfd54b/third_party/blink/renderer/modules/service_worker/wait_until_observer.cc
[modify] https://crrev.com/081f13905a0e46efd20b3cac697610f97ecfd54b/third_party/blink/renderer/modules/storage/storage_controller.cc
[modify] https://crrev.com/081f13905a0e46efd20b3cac697610f97ecfd54b/third_party/blink/renderer/modules/webgl/webgl_query.cc
[modify] https://crrev.com/081f13905a0e46efd20b3cac697610f97ecfd54b/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/081f13905a0e46efd20b3cac697610f97ecfd54b/third_party/blink/renderer/modules/webgl/webgl_sync.cc

Project Member

Comment 71 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09894d87cd98c47bef175d207c92050f7c1b87b6

commit 09894d87cd98c47bef175d207c92050f7c1b87b6
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu Nov 08 06:25:55 2018

Remove usage of FakeRendererScheduler that's not necessary.

In some tests, FakeRendererScheduler is used to obtain the IPC task
runner. However, FakeRendererScheduler::IPCTaskRunner() just returns
nullptr, and there's no real point in using FakeRendererScheduler in
those tests.

This CL removes those unnecessary FakeRendererSchedulers, and passes
nullptr to the arguments where an IPC task runner is expected.

This CL is part of the refactoring of WebThreadScheduler.

Bug: 826203
Change-Id: Ie6800829b3f30cf19a1c2212e58e4cab505df80b
Reviewed-on: https://chromium-review.googlesource.com/c/1319224
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606367}
[add] https://crrev.com/09894d87cd98c47bef175d207c92050f7c1b87b6/third_party/blink/renderer/modules/storage/DEPS
[modify] https://crrev.com/09894d87cd98c47bef175d207c92050f7c1b87b6/third_party/blink/renderer/modules/storage/cached_storage_area_test.cc
[modify] https://crrev.com/09894d87cd98c47bef175d207c92050f7c1b87b6/third_party/blink/renderer/modules/storage/storage_controller_test.cc
[modify] https://crrev.com/09894d87cd98c47bef175d207c92050f7c1b87b6/third_party/blink/renderer/modules/storage/storage_namespace_test.cc

Project Member

Comment 72 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33b9939f1bfde02efde86e94a972d102bd6033fb

commit 33b9939f1bfde02efde86e94a972d102bd6033fb
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu Nov 08 08:00:14 2018

Use Thread::Current()/MainThread()/CompositorThread() in platform/.

This CL simplifies lengthy function calls via Platform::Current() that
obtain the current, main or compositor thread by using Thread::
Current(), Thread::MainThread() or Thread::CompositorThread().

Bug: 826203
Change-Id: I791712e02848b8792204b598fc7fa19114ae36cd
Reviewed-on: https://chromium-review.googlesource.com/c/1319395
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606379}
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/bindings/parkable_string.cc
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/bindings/parkable_string_manager.cc
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/bindings/v8_per_isolate_data.cc
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/blob/blob_bytes_provider.cc
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/exported/platform.cc
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/fonts/mac/font_cache_mac.mm
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.cc
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/graphics/animation_worklet_mutator_dispatcher_impl.cc
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context.cc
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/graphics/mailbox_texture_holder.cc
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/graphics/unaccelerated_static_bitmap_image.cc
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/loader/fetch/memory_cache.cc
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/scheduler/common/thread_scheduler.cc
[modify] https://crrev.com/33b9939f1bfde02efde86e94a972d102bd6033fb/third_party/blink/renderer/platform/testing/unit_test_helpers.cc

Project Member

Comment 73 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43b3797098e29007bfd3c7eb1872f544dde8d247

commit 43b3797098e29007bfd3c7eb1872f544dde8d247
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Nov 09 06:19:36 2018

Rename FakeRendererScheduler to WebFakeThreadScheduler.

FakeRendererScheduler is a fake for WebThreadScheduler (formerly
known as RendererScheduler), which is public to //content and other
files outside Blink. This CL renames its now-obsolete class name.

Bug: 826203
Tbr: sky@chromium.org
Change-Id: I371bdccd22dc57536193486d72da1cced0d752c0
Reviewed-on: https://chromium-review.googlesource.com/c/1319228
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606752}
[modify] https://crrev.com/43b3797098e29007bfd3c7eb1872f544dde8d247/content/renderer/dom_storage/dom_storage_cached_area_unittest.cc
[modify] https://crrev.com/43b3797098e29007bfd3c7eb1872f544dde8d247/content/renderer/dom_storage/local_storage_cached_area_unittest.cc
[modify] https://crrev.com/43b3797098e29007bfd3c7eb1872f544dde8d247/content/renderer/dom_storage/local_storage_cached_areas_unittest.cc
[modify] https://crrev.com/43b3797098e29007bfd3c7eb1872f544dde8d247/content/renderer/gpu/layer_tree_view_unittest.cc
[modify] https://crrev.com/43b3797098e29007bfd3c7eb1872f544dde8d247/content/test/fake_compositor_dependencies.cc
[modify] https://crrev.com/43b3797098e29007bfd3c7eb1872f544dde8d247/content/test/fake_compositor_dependencies.h
[modify] https://crrev.com/43b3797098e29007bfd3c7eb1872f544dde8d247/third_party/blink/public/BUILD.gn
[rename] https://crrev.com/43b3797098e29007bfd3c7eb1872f544dde8d247/third_party/blink/public/platform/scheduler/test/web_fake_thread_scheduler.h
[modify] https://crrev.com/43b3797098e29007bfd3c7eb1872f544dde8d247/third_party/blink/renderer/core/frame/frame_test_helpers.cc
[modify] https://crrev.com/43b3797098e29007bfd3c7eb1872f544dde8d247/third_party/blink/renderer/core/frame/frame_test_helpers.h
[modify] https://crrev.com/43b3797098e29007bfd3c7eb1872f544dde8d247/third_party/blink/renderer/platform/scheduler/BUILD.gn
[delete] https://crrev.com/cca1ac2ce53e420cdc7ef2575a6ef91e29b7a99e/third_party/blink/renderer/platform/scheduler/test/fake_renderer_scheduler.cc
[add] https://crrev.com/43b3797098e29007bfd3c7eb1872f544dde8d247/third_party/blink/renderer/platform/scheduler/test/web_fake_thread_scheduler.cc

Project Member

Comment 74 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7e03360529041aea4b7ac59d0bd3e1d6b3c6f33

commit b7e03360529041aea4b7ac59d0bd3e1d6b3c6f33
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Nov 12 07:26:43 2018

Rename MockRendererScheduler to WebMockThreadScheduler.

This CL renames the class MockRendererScheduler which is the mock of
WebThreadScheduler, formerly named RendererScheduler, so it would match
the current name of its parent class and follow the naming convention
for Blink public classes (starting with "Web").

Bug: 826203
Change-Id: Ibda5282749e1379b053ff27bb03b9140fa124f37
Reviewed-on: https://chromium-review.googlesource.com/c/1328547
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607160}
[modify] https://crrev.com/b7e03360529041aea4b7ac59d0bd3e1d6b3c6f33/content/renderer/input/main_thread_event_queue_unittest.cc
[modify] https://crrev.com/b7e03360529041aea4b7ac59d0bd3e1d6b3c6f33/third_party/blink/public/BUILD.gn
[rename] https://crrev.com/b7e03360529041aea4b7ac59d0bd3e1d6b3c6f33/third_party/blink/public/platform/scheduler/test/web_mock_thread_scheduler.h

Project Member

Comment 75 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63593507613af6f5bdeb38102d421e5193317bd5

commit 63593507613af6f5bdeb38102d421e5193317bd5
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Nov 12 09:27:13 2018

Rename RendererProcessType to WebRendererProcessType.

This enum is exposed to //content and other non-Blink code, so its name
should start with "Web".

Bug: 826203
Tbr: creis@chromium.org
Change-Id: I9fc9aa50ef276dae7ecd64a3bd299590893b19a8
Reviewed-on: https://chromium-review.googlesource.com/c/1328549
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607175}
[modify] https://crrev.com/63593507613af6f5bdeb38102d421e5193317bd5/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/63593507613af6f5bdeb38102d421e5193317bd5/content/public/renderer/render_thread.h
[modify] https://crrev.com/63593507613af6f5bdeb38102d421e5193317bd5/content/public/test/mock_render_thread.cc
[modify] https://crrev.com/63593507613af6f5bdeb38102d421e5193317bd5/content/public/test/mock_render_thread.h
[modify] https://crrev.com/63593507613af6f5bdeb38102d421e5193317bd5/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/63593507613af6f5bdeb38102d421e5193317bd5/content/renderer/render_thread_impl.h
[modify] https://crrev.com/63593507613af6f5bdeb38102d421e5193317bd5/third_party/blink/public/BUILD.gn
[delete] https://crrev.com/b5df98acb727410d0ff8f0a75946e52580213947/third_party/blink/public/platform/scheduler/renderer_process_type.h
[modify] https://crrev.com/63593507613af6f5bdeb38102d421e5193317bd5/third_party/blink/public/platform/scheduler/test/web_fake_thread_scheduler.h
[modify] https://crrev.com/63593507613af6f5bdeb38102d421e5193317bd5/third_party/blink/public/platform/scheduler/test/web_mock_thread_scheduler.h
[add] https://crrev.com/63593507613af6f5bdeb38102d421e5193317bd5/third_party/blink/public/platform/scheduler/web_renderer_process_type.h
[modify] https://crrev.com/63593507613af6f5bdeb38102d421e5193317bd5/third_party/blink/public/platform/scheduler/web_thread_scheduler.h
[modify] https://crrev.com/63593507613af6f5bdeb38102d421e5193317bd5/third_party/blink/renderer/platform/scheduler/common/web_thread_scheduler.cc
[modify] https://crrev.com/63593507613af6f5bdeb38102d421e5193317bd5/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper.cc
[modify] https://crrev.com/63593507613af6f5bdeb38102d421e5193317bd5/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/63593507613af6f5bdeb38102d421e5193317bd5/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/63593507613af6f5bdeb38102d421e5193317bd5/third_party/blink/renderer/platform/scheduler/test/web_fake_thread_scheduler.cc

Project Member

Comment 76 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56accd7d081d586b0a2721c4dca6f8663a2ab20f

commit 56accd7d081d586b0a2721c4dca6f8663a2ab20f
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Nov 16 11:37:17 2018

Move contents of web_task_runner.h to platform/scheduler/.

This moves functions defined in web_task_runner.h to two different
headers in platform/scheduler/public: post_cancellable_task.h and
post_cross_thread_task.h. The header web_task_runner.h remains in
the same place, just having the forwarding #include statements, so
the existing code wouldn't break.

Minor adjustments are made to the moved code, like: (1) using
PLATFORM_EXPORT rather than BLINK_PLATFORM_EXPORT, (2) using
base::TimeDelta instead of WTF::TimeDelta, and (3) revising comments.

web_task_runner_test.cc is also moved, and is simply renamed to
post_cancellable_task_unittest.cc because it only contains tests for
PostCancellableTask().

Bug: 826203
Change-Id: I1fa4f35d278975fbca1a7c27fecf37342b0c76c8
Reviewed-on: https://chromium-review.googlesource.com/c/1339503
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608732}
[modify] https://crrev.com/56accd7d081d586b0a2721c4dca6f8663a2ab20f/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/56accd7d081d586b0a2721c4dca6f8663a2ab20f/third_party/blink/renderer/platform/cross_thread_functional.h
[modify] https://crrev.com/56accd7d081d586b0a2721c4dca6f8663a2ab20f/third_party/blink/renderer/platform/scheduler/BUILD.gn
[rename] https://crrev.com/56accd7d081d586b0a2721c4dca6f8663a2ab20f/third_party/blink/renderer/platform/scheduler/common/post_cancellable_task.cc
[rename] https://crrev.com/56accd7d081d586b0a2721c4dca6f8663a2ab20f/third_party/blink/renderer/platform/scheduler/common/post_cancellable_task_unittest.cc
[add] https://crrev.com/56accd7d081d586b0a2721c4dca6f8663a2ab20f/third_party/blink/renderer/platform/scheduler/common/post_cross_thread_task.cc
[add] https://crrev.com/56accd7d081d586b0a2721c4dca6f8663a2ab20f/third_party/blink/renderer/platform/scheduler/public/post_cancellable_task.h
[add] https://crrev.com/56accd7d081d586b0a2721c4dca6f8663a2ab20f/third_party/blink/renderer/platform/scheduler/public/post_cross_thread_task.h
[modify] https://crrev.com/56accd7d081d586b0a2721c4dca6f8663a2ab20f/third_party/blink/renderer/platform/web_task_runner.h

Project Member

Comment 77 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7153e7e51e9016d2e392b635a9ebbb84f32bf72

commit b7153e7e51e9016d2e392b635a9ebbb84f32bf72
Author: Yuta Kitamura <yutak@chromium.org>
Date: Wed Nov 28 12:06:45 2018

Remove includes of web_task_runner.h in modules/.

This CL rewrites #include lines of web_task_runner.h, which is now
deprecated. Instead of web_task_runner.h, new include lines of
post_cancellable_task.h and/or post_cross_thread_task.h are inserted,
depending on what's used in each file.

This CL only touches #include lines and nothing else.

Bug: 826203
Change-Id: I931acf1f18af1bc34f4e13b6914f2a054671f1d2
Reviewed-on: https://chromium-review.googlesource.com/c/1351204
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611662}
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_list_element.h
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/media_controls/media_controls_orientation_lock_delegate.h
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.cc
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.cc
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/peerconnection/adapters/quic_stream_host.cc
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/peerconnection/adapters/quic_stream_proxy.cc
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.cc
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_proxy.cc
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/sensor/sensor.h
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/service_worker/service_worker_installed_scripts_manager_test.cc
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/service_worker/thread_safe_script_container_test.cc
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/storage/storage_controller_test.cc
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/storage/storage_namespace_test.cc
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/webaudio/async_audio_decoder.cc
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/webaudio/audio_scheduled_source_node.cc
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/webaudio/deferred_task_handler.cc
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/webaudio/script_processor_node.cc
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/webdatabase/database.cc
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/webgl/webgl_query.h
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/webgl/webgl_sync.h
[modify] https://crrev.com/b7153e7e51e9016d2e392b635a9ebbb84f32bf72/third_party/blink/renderer/modules/webgl/webgl_timer_query_ext.h

Project Member

Comment 78 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf

commit 0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu Nov 29 08:32:41 2018

Remove includes of web_task_runner.h in core/.

This CL rewrites #include lines of web_task_runner.h, which is now
deprecated. Instead of web_task_runner.h, new include lines of
post_cancellable_task.h and/or post_cross_thread_task.h are inserted,
depending on what's used in each file.

This CL only touches #include lines and nothing else.

Bug: 826203
Change-Id: I3b4ae2d9e62966acac0400bd0c802fef3b3aecf9
Reviewed-on: https://chromium-review.googlesource.com/c/1351206
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612102}
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/css/threaded/multi_threaded_test_util.h
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/frame/platform_event_controller.h
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/frame/reporting_observer.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/html/forms/file_chooser.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/html/html_details_element.h
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/html/html_source_element.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/html/html_source_element.h
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/html/media/html_media_element.h
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/html/parser/background_html_parser.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/html/parser/html_parser_scheduler.h
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/inspector/devtools_session.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/inspector/inspector_task_runner.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/loader/interactive_detector_test.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/loader/long_task_detector_test.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/loader/navigation_scheduler.h
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/loader/resource/font_resource.h
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/mojo/mojo_watcher.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/scroll/scroll_animator_mac.h
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/svg/animation/svg_smil_element.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/svg/svg_style_element.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/workers/dedicated_worker_object_proxy.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/workers/threaded_object_proxy_base.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/workers/threaded_worklet_messaging_proxy.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/workers/worker_thread.h
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.h
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_list_element.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/modules/media_controls/elements/media_control_popup_menu_element.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/modules/media_controls/media_controls_media_event_listener.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/modules/media_controls/media_download_in_product_help_manager.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/modules/quota/deprecated_storage_quota.cc
[modify] https://crrev.com/0d1c5131d27d3c2e91be5c41358e38aab2c9b3bf/third_party/blink/renderer/modules/webdatabase/database_tracker.cc

Project Member

Comment 79 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90efe16b1503518a436e1838aaf130f84c01397c

commit 90efe16b1503518a436e1838aaf130f84c01397c
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu Nov 29 10:09:49 2018

Remove includes of web_task_runner.h in platform/ and elsewhere.

This CL rewrites #include lines of web_task_runner.h, which is now
deprecated. Instead of web_task_runner.h, new include lines of
post_cancellable_task.h and/or post_cross_thread_task.h are inserted,
depending on what's used in each file.

This CL only touches #include lines and nothing else.

Bug: 826203
Change-Id: Ic69f1c44af50d2ad39cee4d8bc42d8b37cb9b528
Reviewed-on: https://chromium-review.googlesource.com/c/1351207
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612124}
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/bindings/core/v8/script_promise_resolver.h
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/bindings/core/v8/script_streamer_thread.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/controller/oom_intervention_impl.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/core/dom/scripted_task_queue.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/core/html/forms/mock_file_chooser.h
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/core/imagebitmap/image_bitmap_factories.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/core/intersection_observer/intersection_observer_controller.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/core/loader/subresource_filter.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/core/workers/worklet_module_responses_map.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/core/workers/worklet_module_tree_client.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/modules/background_fetch/background_fetch_icon_loader.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/modules/bluetooth/bluetooth.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/modules/clipboard/clipboard_promise.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/modules/credentialmanager/public_key_credential.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/modules/filesystem/file_system_file_handle.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/modules/filesystem/file_writer_sync.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/modules/media_controls/media_controls_rotate_to_fullscreen_delegate.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/modules/payments/payment_instruments.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/modules/payments/payment_request.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/modules/picture_in_picture/document_picture_in_picture.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/modules/presentation/presentation_connection.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/modules/webaudio/audio_worklet_node.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/modules/webmidi/midi_port.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/modules/websockets/dom_websocket.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/modules/xr/xr.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/audio/audio_destination.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/audio/hrtf_database_loader.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/audio/push_pull_fifo_multithread_test.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/audio/reverb_convolver.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/bindings/parkable_string.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/blob/blob_bytes_provider.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/blob/blob_data.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/exported/platform.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/graphics/animation_worklet_mutator_dispatcher_impl.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/graphics/begin_frame_provider.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/graphics/deferred_image_decoder_test.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/graphics/image_frame_generator_test.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/graphics/mailbox_texture_holder.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/graphics/offscreen_canvas_placeholder.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/graphics/unaccelerated_static_bitmap_image.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/heap/heap_test.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/loader/fetch/resource.h
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/loader/fetch/resource_response_test.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/memory_coordinator.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/network/network_state_notifier.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/scheduler/common/thread.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/scheduler/worker/worker_thread_unittest.cc
[modify] https://crrev.com/90efe16b1503518a436e1838aaf130f84c01397c/third_party/blink/renderer/platform/web_thread_supporting_gc.h

Project Member

Comment 80 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bb21a688b9887bc25510072af98538ea0f512bc

commit 4bb21a688b9887bc25510072af98538ea0f512bc
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Nov 30 07:07:10 2018

Remove deprecated web_task_runner.h.

It's unused as of now.

Bug: 826203
Change-Id: I8e54a8234cb83c1ac871768a62fb2224be9ba0d0
Reviewed-on: https://chromium-review.googlesource.com/c/1356461
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612591}
[modify] https://crrev.com/4bb21a688b9887bc25510072af98538ea0f512bc/third_party/blink/renderer/platform/BUILD.gn
[delete] https://crrev.com/603262a695ae728ae4a58ab638127b4aa50ef26a/third_party/blink/renderer/platform/web_task_runner.h

Sign in to add a comment