New issue
Advanced search Search tips

Issue 826194 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 824797



Sign in to add a comment

Implement WebRTC Operations queue

Project Member Reported by hta@chromium.org, Mar 27 2018

Issue description

The WebRTC specification specifies that certain asynchronoous operations (createOffer, setLocalDescription, setRemoteDescription) are performed in sequence even if they are called in succession without waiting for promises to resolve.

This affects, among other things, state checking - we can't check if the connection is in the proper state for a call until the previous operations have completed.


 

Comment 1 by hta@chromium.org, Mar 27 2018

Blocking: 824797
Components: Blink>WebRTC>PeerConnection
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa899fbec22552953410519f10a39ff826f32d7b

commit aa899fbec22552953410519f10a39ff826f32d7b
Author: Harald Alvestrand <hta@chromium.org>
Date: Tue Mar 27 20:18:41 2018

Remove checks for state in setLocalDescription

Proper state checking requires the operations queue,
so disabling for now.

Bug: 826194
Change-Id: I48b27834f93e3d01665dcb3c96ddd94ef0589944
Reviewed-on: https://chromium-review.googlesource.com/980945
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546231}
[modify] https://crrev.com/aa899fbec22552953410519f10a39ff826f32d7b/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-pranswer-expected.txt
[modify] https://crrev.com/aa899fbec22552953410519f10a39ff826f32d7b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

Status: Available (was: Untriaged)

Sign in to add a comment