New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826192 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Add a flag to toggle between G and magnifying glass

Project Member Reported by gambard@chromium.org, Mar 27 2018

Issue description

The flag should be search-icon-toggle.
 
Labels: -Type-Bug Type-Task
Cc: pschaffner@chromium.org
Would it make sense to add a colored G option while we are at it?
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca4f14df5be1004cd58e50e3089dbcde422fe823

commit ca4f14df5be1004cd58e50e3089dbcde422fe823
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Mar 27 13:54:50 2018

Add a switch for the bottom toolbar search icons

This CL adds a switch allowing the choose which icon to use for the
search button in the bottom toolbar.

Bug:  826192 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I363822bd9fa94606bf5422b0664febc91b81e03e
Reviewed-on: https://chromium-review.googlesource.com/980935
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546099}
[modify] https://crrev.com/ca4f14df5be1004cd58e50e3089dbcde422fe823/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/ca4f14df5be1004cd58e50e3089dbcde422fe823/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/ca4f14df5be1004cd58e50e3089dbcde422fe823/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/ca4f14df5be1004cd58e50e3089dbcde422fe823/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm
[modify] https://crrev.com/ca4f14df5be1004cd58e50e3089dbcde422fe823/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view.mm
[modify] https://crrev.com/ca4f14df5be1004cd58e50e3089dbcde422fe823/ios/chrome/browser/ui/toolbar/public/toolbar_controller_base_feature.h
[modify] https://crrev.com/ca4f14df5be1004cd58e50e3089dbcde422fe823/ios/chrome/browser/ui/toolbar/public/toolbar_controller_base_feature.mm

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/bd1a43500178a5e7b746973ff0d7bd0481a517e3

commit bd1a43500178a5e7b746973ff0d7bd0481a517e3
Author: Gauthier Ambard <gambard@google.com>
Date: Tue Mar 27 17:02:39 2018

Status: Fixed (was: Assigned)
Is this CL still relevant?

Sign in to add a comment