New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 826185 link

Starred by 2 users
Status: Assigned
Owner:
joelhockey@chromium.org
Cc:
█ sashab@chromium.org
weifangsun@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove GRIT <imports> from the Files app

Project Member Reported by sashab@chromium.org, Mar 27 2018 
Remove GRIT imports from the files app, replacing them with regular <script> includes instead.

GRIT imports are deprecated, and this will improve the debuggability of the files app, since the scripts are not combined before running.

Comment 1 by sashab@chromium.org, May 31 2018

Cc: weifangsun@chromium.org sashab@chromium.org
Labels: M-70
Yayy, I forgot we filed a bug for this! \o/

I think this would also help debugging/developer environment, since (correct me if I'm wrong) if we use <script> tags and update the .js, we can just reload the file manager and it will see the changes immediately (no need to rebuild the pak file)?

If so, I'm increasing this to P-2 for M70, since this would help our development workflow *a lot*.

Comment 2 Deleted

Comment 3 Deleted

Comment 4 by slangley@chromium.org, Sep 10

Labels: -M-70 M-71

Comment 5 by slangley@chromium.org, Oct 4

Labels: -M-71
Does not seem to be milestone specific.

Comment 6 by joelhockey@chromium.org, Nov 2 

Exploratory CL done in https://chromium-review.googlesource.com/c/chromium/src/+/1282504.

This change caused a reduction in startup performance of about 200ms, so it is unlikely that we will make a change such as this without also making other changes for how the JS is loaded.
►

Sign in to add a comment