New issue
Advanced search Search tips

Issue 826150 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

chromedriver_py_tests failing on chromium.mac/Mac10.12 Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Mar 27 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of benwells@google.com

chromedriver_py_tests failing on chromium.mac/Mac10.12 Tests

Builders failed on: 
- Mac10.12 Tests: 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests


 
Cc: johnchen@chromium.org
+johnchen who i think is a chromedriver owner

This is failing flakily but quite regularaly, with different tests failing:

https://ci.chromium.org/buildbot/chromium.mac/Mac10.12%20Tests/11609 testEmulateNetworkConditionsName failed

https://ci.chromium.org/buildbot/chromium.mac/Mac10.12%20Tests/11607 testCloseWindow failed

https://ci.chromium.org/buildbot/chromium.mac/Mac10.12%20Tests/11603 testDeviceMetricsWithStandardWidth failed
 Issue 826149  has been merged into this issue.
Owner: johnchen@chromium.org
Status: Assigned (was: Available)
Looking into this.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79347f0c9d80284eac40e275f9a1e66dd6df372b

commit 79347f0c9d80284eac40e275f9a1e66dd6df372b
Author: John Chen <johnchen@chromium.org>
Date: Wed Mar 28 13:52:58 2018

[ChromeDriver] Additional WebSocket logging

Add additional logging for the WebSocket connection between
ChromeDriver and DevTools, to help investigate test issues found
on build bots.

Bug:  826150 
Change-Id: I60b425239cc5d39b49d373b5a1f346b2ba71b50a
Reviewed-on: https://chromium-review.googlesource.com/982268
Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546473}
[modify] https://crrev.com/79347f0c9d80284eac40e275f9a1e66dd6df372b/chrome/test/chromedriver/logging.cc
[modify] https://crrev.com/79347f0c9d80284eac40e275f9a1e66dd6df372b/chrome/test/chromedriver/net/websocket.cc
[modify] https://crrev.com/79347f0c9d80284eac40e275f9a1e66dd6df372b/chrome/test/chromedriver/server/server.py

Labels: -Sheriff-Chromium
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/321205bc6a1c53fd42658d648298fed314de7e4f

commit 321205bc6a1c53fd42658d648298fed314de7e4f
Author: John Chen <johnchen@chromium.org>
Date: Fri Apr 27 20:19:58 2018

[ChromeDriver] Retry connection to DevTools

Add retries while making connection to DevTools.

Bug:  826150 
Change-Id: I43b708eabdf2202ed14b41cd43677f814b02079d
Reviewed-on: https://chromium-review.googlesource.com/1026153
Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554483}
[modify] https://crrev.com/321205bc6a1c53fd42658d648298fed314de7e4f/chrome/test/chromedriver/net/sync_websocket_impl.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/057b1dafd3b76121e5dae927d7df800fa2c7d42a

commit 057b1dafd3b76121e5dae927d7df800fa2c7d42a
Author: John Chen <johnchen@chromium.org>
Date: Mon Apr 30 15:55:51 2018

[ChromeDriver] Adjust DevTools connection retry

Adjust when to retry while connecting to DevTools. The retry timeout
now starts at 1 second, with exponential backoff, up to 16 seconds.

Bug:  826150 
Change-Id: Ia8dfdd27ab88ac6f466555a943810242188604d6
Reviewed-on: https://chromium-review.googlesource.com/1034385
Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554766}
[modify] https://crrev.com/057b1dafd3b76121e5dae927d7df800fa2c7d42a/chrome/test/chromedriver/net/sync_websocket_impl.cc

 Issue 819366  has been merged into this issue.
Components: Tests>WebDriver
Status: Fixed (was: Assigned)
No more flakiness of this test was observed after CL 554483.

Sign in to add a comment