New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 826138 link

Starred by 1 user
Status: Fixed
Owner:
charliea@chromium.org
Closed: Apr 2018
Cc:
█ nednguyen@chromium.org
mythria@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Remove the Telemetry 'Mobile' disabling test condition

Project Member Reported by charliea@chromium.org, Mar 27 2018 
mythria@ noticed in https://docs.google.com/a/google.com/document/d/1q5fTGpKDPvA2m2SMy2XcIwAr10K4i6tsSh-M-umPfTI/edit?disco=AAAABuEQHro that there was a 'Mobile' category, and was confused as to whether it's the same as Android. I'd never noticed it before, but the code (https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/story/expectations.py?type=cs&q=mobile+f:expectations.py&sq=package:chromium&l=310) suggests that they're exactly the same.

I'm going to go ahead and just remove 'Mobile'.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f112b3bfc9b0ce77a6bb6b5e03c2cde328b480c

commit 8f112b3bfc9b0ce77a6bb6b5e03c2cde328b480c
Author: Charlie Andrews <charliea@chromium.org>
Date: Mon Apr 02 16:47:13 2018

Delete the 'Mobile' disabling condition from expectations.config

In all instances, I replaced it with it Android, which is functionally
equivalent.

Bug:  826138 
Change-Id: I1b4c8a0adfc9c24542cd75d165fee0efac8089c3
Reviewed-on: https://chromium-review.googlesource.com/981497
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547449}
[modify] https://crrev.com/8f112b3bfc9b0ce77a6bb6b5e03c2cde328b480c/tools/perf/expectations.config

Comment 2 by charliea@chromium.org, Apr 2 2018

Status: Fixed (was: Assigned)

Comment 3 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 4 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry
►

Sign in to add a comment