Separate testing of FidoRequestHandler logic from its implementing classes |
||
Issue descriptionCreate a new test file to isolate testing the logic of FidoRequestManager.
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7ab0df5f35730347abeb4a8f5d1d8e549de367c commit f7ab0df5f35730347abeb4a8f5d1d8e549de367c Author: Jun Choi <hongjunchoi@chromium.org> Date: Thu Apr 05 21:48:16 2018 Separate testing of FidoRequestHandler Create separate unit test to separate logic of FidoRequestHandler and MakeCredentialHandler. Unit test for FidoRequestHandler should only test two things. 1) At most one response from multiple authenticators should be passed to the relying party. 2) Second, cancel operation should be invoked to authenticators that error out. Bug: 826132 Change-Id: I785c53a39dc64d7974e57aeb87bc0baaecd7b4e8 Reviewed-on: https://chromium-review.googlesource.com/982558 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#548567} [modify] https://crrev.com/f7ab0df5f35730347abeb4a8f5d1d8e549de367c/device/BUILD.gn [modify] https://crrev.com/f7ab0df5f35730347abeb4a8f5d1d8e549de367c/device/fido/fido_request_handler.h [modify] https://crrev.com/f7ab0df5f35730347abeb4a8f5d1d8e549de367c/device/fido/fido_request_handler_unittest.cc [modify] https://crrev.com/f7ab0df5f35730347abeb4a8f5d1d8e549de367c/device/fido/get_assertion_handler_unittest.cc [add] https://crrev.com/f7ab0df5f35730347abeb4a8f5d1d8e549de367c/device/fido/make_credential_handler_unittest.cc [modify] https://crrev.com/f7ab0df5f35730347abeb4a8f5d1d8e549de367c/device/fido/mock_fido_device.cc [modify] https://crrev.com/f7ab0df5f35730347abeb4a8f5d1d8e549de367c/device/fido/mock_fido_device.h
,
Apr 11 2018
Ah, fixed the summary with correct class name. Thank you! |
||
►
Sign in to add a comment |
||
Comment 1 by engedy@chromium.org
, Mar 31 2018Status: Started (was: Assigned)