New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 826104 link

Starred by 1 user
Status: Fixed
Owner:
█ iannucci@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Cc:
bpastene@chromium.org
no...@chromium.org
vadimsh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CIPD bundled recipes should be installed with copy mode to avoid weird paths

Project Member Reported by iannucci@chromium.org, Mar 27 2018 
example: https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8950960102014369312%2F%2B%2Fsteps%2Fbot_update%2F0%2Fstdout

Currently the bundles are installed with symlink mode, and sometimes paths inside the bundle get 'realpath'd, leading to paths like:

  /b/swarming/w/ir/.cipd/pkgs/11/19776e1f7a14ffb6433e3955cf8a1da2ff4c014c/depot_tools/gclient_eval.py

which aren't harmful, but they're certainly odd-looking. Since we always blow away /b/swarming/w/ir/ on every task, there's no potential benefit to installing in symlink mode anyway.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f659d8da4de25f313941427704bdca5d3ce0033f

commit f659d8da4de25f313941427704bdca5d3ce0033f
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Mar 28 18:13:37 2018

[recipe-bundler] Use copy mode to avoid extra symlink paths.

R=bpastene@chromium.org, nodir@chromium.org, vadimsh@chromium.org

Bug:  826104 
Change-Id: I53ed7b08ec95dc0ebd69b1482d728d545fb5c5bc
Reviewed-on: https://chromium-review.googlesource.com/981677
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/f659d8da4de25f313941427704bdca5d3ce0033f/go/src/infra/tools/recipe_bundler/cmd_bundle.go
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 28 2018

Labels: merge-merged-config
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/88a8f565f2a57941c8928422afc1c7b6738d74e0

commit 88a8f565f2a57941c8928422afc1c7b6738d74e0
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Mar 28 23:53:13 2018
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/e562bb1be0d83c9830b2221e87daa846ff38aaab

commit e562bb1be0d83c9830b2221e87daa846ff38aaab
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Mar 29 00:03:02 2018

[README.md] Small tweaks to get a new commit

TBR=nodir@chromium.org

Bug:  826104 
Change-Id: Ie718697625d3b7b31774847a101fa68f674fa2ef
Reviewed-on: https://chromium-review.googlesource.com/985124
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/e562bb1be0d83c9830b2221e87daa846ff38aaab/scripts/slave/README.md

Comment 4 by iannucci@chromium.org, Mar 29 2018

Status: Fixed (was: Started)
►

Sign in to add a comment