New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826101 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Compile failure on linux-chromeos-dbg

Project Member Reported by afakhry@chromium.org, Mar 27 2018

Issue description

Build Link: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/4899

[1749/12136] SOLINK ./libash.so
FAILED: libash.so libash.so.TOC 
python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --sofile="./libash.so" --tocfile="./libash.so.TOC" --output="./libash.so"  -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--no-as-needed -lpthread -Wl,--as-needed -fuse-ld=gold -B../../third_party/binutils/Linux_x64/Release/bin -Wl,--threads -Wl,--thread-count=4 -Wl,--icf=all -m64 -Werror -Wl,--gdb-index -Wl,--fatal-warnings -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -o "./libash.so" -Wl,-soname="libash.so" @"./libash.so.rsp"
obj/ash/ash/ash_assistant_controller.o:ash_assistant_controller.cc:function ash::AshAssistantController::SetAssistant(mojo::InterfacePtr<chromeos::assistant::mojom::Assistant>): error: undefined reference to 'chromeos::assistant::mojom::AssistantProxy::AddAssistantEventSubscriber(mojo::InterfacePtr<chromeos::assistant::mojom::AssistantEventSubscriber>)'
obj/ash/ash/ash_assistant_controller.o:ash_assistant_controller.cc:function chromeos::assistant::mojom::AssistantEventSubscriberStub<mojo::RawPtrImplRefTraits<chromeos::assistant::mojom::AssistantEventSubscriber> >::Accept(mojo::Message*): error: undefined reference to 'chromeos::assistant::mojom::AssistantEventSubscriberStubDispatch::Accept(chromeos::assistant::mojom::AssistantEventSubscriber*, mojo::Message*)'
obj/ash/ash/ash_assistant_controller.o:ash_assistant_controller.cc:function chromeos::assistant::mojom::AssistantEventSubscriberStub<mojo::RawPtrImplRefTraits<chromeos::assistant::mojom::AssistantEventSubscriber> >::AcceptWithResponder(mojo::Message*, std::__1::unique_ptr<mojo::MessageReceiverWithStatus, std::__1::default_delete<mojo::MessageReceiverWithStatus> >): error: undefined reference to 'chromeos::assistant::mojom::AssistantEventSubscriberStubDispatch::AcceptWithResponder(chromeos::assistant::mojom::AssistantEventSubscriber*, mojo::Message*, std::__1::unique_ptr<mojo::MessageReceiverWithStatus, std::__1::default_delete<mojo::MessageReceiverWithStatus> >)'
../../buildtools/third_party/libc++/trunk/include/memory:3925: error: undefined reference to 'chromeos::assistant::mojom::AssistantEventSubscriber::Name_'
obj/ash/ash/ash_assistant_controller.o:ash_assistant_controller.cc:function chromeos::assistant::mojom::AssistantEventSubscriberRequestValidator::AssistantEventSubscriberRequestValidator(): error: undefined reference to 'vtable for chromeos::assistant::mojom::AssistantEventSubscriberRequestValidator'
../../third_party/binutils/Linux_x64/Release/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function
obj/ash/ash/ash_assistant_controller.o:ash_assistant_controller.cc:function mojo::internal::InterfacePtrState<chromeos::assistant::mojom::Assistant>::ConfigureProxyIfNecessary(): error: undefined reference to 'chromeos::assistant::mojom::Assistant::Name_'
obj/ash/ash/ash_assistant_controller.o:ash_assistant_controller.cc:function mojo::internal::InterfacePtrState<chromeos::assistant::mojom::Assistant>::ConfigureProxyIfNecessary(): error: undefined reference to 'chromeos::assistant::mojom::AssistantProxy::AssistantProxy(mojo::MessageReceiverWithResponder*)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Blame CL: https://chromium-review.googlesource.com/c/chromium/src/+/973551
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae7ce2710f11dd78c2f787b888d2cc19b912bf49

commit ae7ce2710f11dd78c2f787b888d2cc19b912bf49
Author: Ahmed Fakhry <afakhry@chromium.org>
Date: Tue Mar 27 01:14:44 2018

Revert "Adds AshAssistantController."

This reverts commit 6dbf08b3b1bf9d985f7c0be9abfcd97113382dc6.

Reason for revert: Compile failure on linux-chromeos-dbg
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/4899

BUG= 826101 

Original change's description:
> Adds AshAssistantController.
> 
> Bug: b:76028606
> Change-Id: Iafdafed688333035f67067b3f60c9b35c99a8276
> Reviewed-on: https://chromium-review.googlesource.com/973551
> Commit-Queue: David Black <dmblack@google.com>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Reviewed-by: Muyuan Li <muyuanli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545908}

TBR=xiyuan@chromium.org,dcheng@chromium.org,xiaohuic@chromium.org,dmblack@google.com,muyuanli@chromium.org

Change-Id: Ic33bb5e3efcec6547469999fd42e662529275942
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:76028606
Reviewed-on: https://chromium-review.googlesource.com/981464
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545918}
[modify] https://crrev.com/ae7ce2710f11dd78c2f787b888d2cc19b912bf49/ash/BUILD.gn
[modify] https://crrev.com/ae7ce2710f11dd78c2f787b888d2cc19b912bf49/ash/DEPS
[delete] https://crrev.com/c9c24eadb4e404cafb0d489184b8c02903e38302/ash/assistant/ash_assistant_controller.cc
[delete] https://crrev.com/c9c24eadb4e404cafb0d489184b8c02903e38302/ash/assistant/ash_assistant_controller.h
[modify] https://crrev.com/ae7ce2710f11dd78c2f787b888d2cc19b912bf49/ash/manifest.json
[modify] https://crrev.com/ae7ce2710f11dd78c2f787b888d2cc19b912bf49/ash/mojo_interface_factory.cc
[modify] https://crrev.com/ae7ce2710f11dd78c2f787b888d2cc19b912bf49/ash/public/interfaces/BUILD.gn
[delete] https://crrev.com/c9c24eadb4e404cafb0d489184b8c02903e38302/ash/public/interfaces/ash_assistant_controller.mojom
[modify] https://crrev.com/ae7ce2710f11dd78c2f787b888d2cc19b912bf49/ash/shell.cc
[modify] https://crrev.com/ae7ce2710f11dd78c2f787b888d2cc19b912bf49/ash/shell.h
[modify] https://crrev.com/ae7ce2710f11dd78c2f787b888d2cc19b912bf49/chromeos/services/assistant/public/mojom/assistant.mojom
[modify] https://crrev.com/ae7ce2710f11dd78c2f787b888d2cc19b912bf49/chromeos/services/assistant/service.cc

Comment 2 by dmblack@google.com, Apr 2 2018

Status: WontFix (was: Assigned)
Offending CL was rolled back.

Sign in to add a comment