New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826094 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature



Sign in to add a comment

Add search functionality to Passwords settings screen

Project Member Reported by eugene...@chromium.org, Mar 27 2018

Issue description

Steps to reproduce: 
1.) Open settings
2.) Tap passwords

Observed behavior: 
There is no search bar

Expected behavior: 
The list of passwords can be very long and search feature can be useful

 
Cc: ioanap@chromium.org
Status: Available (was: Untriaged)

Comment 2 by noyau@chromium.org, Jun 20 2018

Labels: -Pri-3 Pri-1

Comment 3 by battre@chromium.org, Jun 20 2018

Owner: noyau@chromium.org
Status: Assigned (was: Available)

Comment 4 by battre@chromium.org, Jun 20 2018

Cc: noyau@chromium.org
Labels: -Pri-1 Pri-3
Owner: ----
Status: Available (was: Assigned)
Misunderstood the priority change as a plan to work on this.

Resetting to P3 as this currently not a high priority for the password manager team.
Cc: mard...@chromium.org battre@chromium.org
With autogenerated passwords, my list contains hundreds of entries, which are not even alphabetically orderer. As it is the UI is completely unusable for me. So if I want to use my Chrome autogenerated password in native app (quite common case BTW), I have to load passwords.google.com, pass 2 factor authentication and cut and paste the password. 

In Safari the experience of using autogenerated passwords is seamless.

Comment 6 by battre@chromium.org, Jun 20 2018

Cc: nepper@chromium.org
Are autogenerated passwords in any way different than typed passwords (i.e. are you pointing to a bug that we generate more than one password per site) or is the generation feature just the reason for storing more credentials as you don't reuse and memorize them anymore?

I am surprised that the credentials are not alphabetically ordered. They are on my version of Bling (67.0.396.87). They are ordered by eTLD+1 so that www.facebook.com and m.facebook.com appear next to each other - in the section of sites starting with "F".
Correct. I remember all my typed passwords, so I don't need to look them up. Autogenerated passwords are great, but they are unique for each site, hence I have a lot of them and of course can not remember those passwords.

Attaching screenshot for ordering issue (seems like I have correct eTLD+1 order). FWIW, fixing ordering would be a great improvement in UX for me. 
IMG_5897.PNG
78.7 KB View Download

Comment 8 by battre@chromium.org, Jun 20 2018

What would you consider "fixed ordering"? The current order is so that "login.google.com" appears under "G" and not under "L". I think this is WAI.

We considered a change such that the part before the eTLD+1 would be in gray and the eTLD+1 would be black (i.e. <gray>riverterrace</gray><black>.activebuilding.com</block>). That should greatly improve visual scan-ability.

Unfortunately we haven't been able to find the resources to do that on any platform, yet.
By "fixing ordering" I meant that riverterrace.activebuilding.com should be somewhere in the bottom. "riverterrace" is the name of the apartment complex which should be used for ordering, activebuilding.com is just a hosting service (like appspot.com).

<gray>riverterrace</gray><black>.activebuilding.com</block> would not help me with searching my password for "riverterrace" website.
Cc: eugene...@chromium.org
I don't see a way of moving riverterrace.activebuilding.com to r while keeping 
- fahrkarten.bahn.de at b
- secure.booking.com at b
- secure01c.chase.com at c
- online.citi.com at c
- onlinebanking.huntington.com at h
- accounts.intuit.com at i
...

I think that the riverterrace case is the exception, not the norm.

I agree that searching would address this to a certain degree but we don't have to resources to fix that at the moment. In case you want to take a stab at it: We have approved mocks go/bofpb, a UI precedent in the browsing history view, and I think the code lives at ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
Cc: -noyau@chromium.org pinkerton@chromium.org
Thanks for the comments. Mardini, Pink is this something that Chrome for iOS team should work on? 
Eugene: We should see if we have bandwidth to work on it and how it fits with the rest of our priorities in Q3. I believe the Password Manager team might be considering spending some cycles for iOS in Q4 and if that is the case, this should be a top priority then.
Owner: djean@chromium.org
Status: Started (was: Available)
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edef68dce9a844f295d73e2d80d0f6c80787afb8

commit edef68dce9a844f295d73e2d80d0f6c80787afb8
Author: David Jean <djean@google.com>
Date: Fri Aug 24 08:00:34 2018

[ios] Added deleteAllItemsFromSection to list_model

Added a function to remove all items from a section, so that only
that section can be regenerated dynamically.

Bug:  826094 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia873e56b0bbb8d9527b719d665ed536dddf83d41
Reviewed-on: https://chromium-review.googlesource.com/1186401
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585750}
[modify] https://crrev.com/edef68dce9a844f295d73e2d80d0f6c80787afb8/ios/chrome/browser/ui/list_model/list_model.h
[modify] https://crrev.com/edef68dce9a844f295d73e2d80d0f6c80787afb8/ios/chrome/browser/ui/list_model/list_model.mm
[modify] https://crrev.com/edef68dce9a844f295d73e2d80d0f6c80787afb8/ios/chrome/browser/ui/list_model/list_model_unittest.mm

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6699fd7e7d593041b0120bfe7fdc43f389cc9767

commit 6699fd7e7d593041b0120bfe7fdc43f389cc9767
Author: David Jean <djean@google.com>
Date: Tue Aug 28 13:41:17 2018

[ios] Added a search cell to settings catalog

On the way to adding saved passwords search in settings.

Bug:  826094 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5fcbd2dcbe7ea0378b963d1948c782499f691dae
Reviewed-on: https://chromium-review.googlesource.com/1186413
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586677}
[modify] https://crrev.com/6699fd7e7d593041b0120bfe7fdc43f389cc9767/ios/chrome/browser/ui/settings/cells/BUILD.gn
[add] https://crrev.com/6699fd7e7d593041b0120bfe7fdc43f389cc9767/ios/chrome/browser/ui/settings/cells/settings_search_item.h
[add] https://crrev.com/6699fd7e7d593041b0120bfe7fdc43f389cc9767/ios/chrome/browser/ui/settings/cells/settings_search_item.mm
[modify] https://crrev.com/6699fd7e7d593041b0120bfe7fdc43f389cc9767/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68a13dcb5811bac06b724c3d413ea12105863a34

commit 68a13dcb5811bac06b724c3d413ea12105863a34
Author: David Jean <djean@google.com>
Date: Wed Aug 29 06:35:30 2018

[ios] Added searching of saved passwords

In action:
https://drive.google.com/open?id=1UaDr9ownqqq49THLuSjgYoSXtf80BfPX

Bug:  826094 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I847dd0100b61f8bdbeaec41f71ce1c67c6954344
Reviewed-on: https://chromium-review.googlesource.com/1186420
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587026}
[modify] https://crrev.com/68a13dcb5811bac06b724c3d413ea12105863a34/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/68a13dcb5811bac06b724c3d413ea12105863a34/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
[modify] https://crrev.com/68a13dcb5811bac06b724c3d413ea12105863a34/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller_unittest.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on 71.0.3542.0 Canary, iPhone X  iOS 11.4.1, iPhone 7 iOS 12.0 beta#12
Search functionality is added to Passwords settings screen.

https://drive.google.com/file/d/12ni3rQLM8ti6j4u01v_45xv8EaQJI2vO/view

Sign in to add a comment