New issue
Advanced search Search tips

Issue 826091 link

Starred by 1 user
Status: Fixed
Owner:
taku...@chromium.org
Closed: May 2018
Cc:
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 754101


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

Implement MRUI and MRDialogController for Harmony Cast dialog

Project Member Reported by taku...@chromium.org, Mar 27 2018 
The two classes have implementations for the WebUI Cast dialog. We will factor out parts that can be shared between the WebUI and Views implementations, and have subclasses for WebUI and Views.

MRViewsUI will be responsible for providing the dialog UI with sink/route information, and forwarding route requests from the UI to Media Router.

MRDialogControllerViewsImpl will be responsible for opening and closing the Views dialog.

Comment 1 by taku...@chromium.org, Mar 27 2018

Blocking: 754101
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96dfb4b4bb30db12771c00d483fa63d7a9a00f97

commit 96dfb4b4bb30db12771c00d483fa63d7a9a00f97
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Fri Mar 30 16:47:06 2018

Move files from c/b/ui/webui/media_router to c/b/ui/media_router

Move files that will be shared by the WebUI and Views implementations
of the Cast dialog.
Also add an OWNERS file to c/b/ui/media_router.

Bug:  826091 
Change-Id: I5e59457703c5e358d227d618ef57a3d9bfe4eb06
Reviewed-on: https://chromium-review.googlesource.com/986832
Reviewed-by: Adam Parker <amp@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547189}
[modify] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/media/router/media_router_metrics.h
[modify] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/media/router/media_router_metrics_unittest.cc
[modify] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/media_router/OWNERS
[rename] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/media_router/cast_modes_with_media_sources.cc
[rename] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/media_router/cast_modes_with_media_sources.h
[rename] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/media_router/cast_modes_with_media_sources_unittest.cc
[rename] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/media_router/media_cast_mode.cc
[rename] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/media_router/media_cast_mode.h
[rename] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/media_router/media_cast_mode_unittest.cc
[rename] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/media_router/media_router_file_dialog.cc
[rename] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/media_router/media_router_file_dialog.h
[rename] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/media_router/media_router_file_dialog_unittest.cc
[rename] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/media_router/media_sink_with_cast_modes.cc
[rename] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/media_router/media_sink_with_cast_modes.h
[rename] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/media_router/query_result_manager.cc
[rename] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/media_router/query_result_manager.h
[rename] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/media_router/query_result_manager_unittest.cc
[modify] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h
[modify] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/test/BUILD.gn
[modify] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/test/media_router/media_router_integration_browsertest.cc
[modify] https://crrev.com/96dfb4b4bb30db12771c00d483fa63d7a9a00f97/chrome/test/media_router/media_router_integration_browsertest.h
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f88469345efc3399265bc460040b0dc3596409e

commit 2f88469345efc3399265bc460040b0dc3596409e
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Thu Apr 05 02:11:07 2018

Add a MediaRouterDialogController for Views dialog

- Add MRDialogControllerViewsImpl stub
- Rename MRDialogControllerImpl to MRDialogControllerWebUIImpl
- Factor out parts that are common across WebUI and Views into
  MRDialogControllerImplBase
- MediaRouterDialogControllerImplBase::GetOrCreateForWebContents() is
  implemented in two places: mrdc_views_impl.cc for builds with Views,
  mrdc_webui_impl.cc for builds without.

Bug:  826091 
Change-Id: I276d46ba870b837c5b35f48a4921a3df356aa565
Reviewed-on: https://chromium-review.googlesource.com/990572
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Adam Parker <amp@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548290}
[modify] https://crrev.com/2f88469345efc3399265bc460040b0dc3596409e/chrome/browser/media/router/media_router_dialog_controller.cc
[modify] https://crrev.com/2f88469345efc3399265bc460040b0dc3596409e/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/2f88469345efc3399265bc460040b0dc3596409e/chrome/browser/ui/media_router/media_router_dialog_controller_impl_base.cc
[add] https://crrev.com/2f88469345efc3399265bc460040b0dc3596409e/chrome/browser/ui/media_router/media_router_dialog_controller_impl_base.h
[modify] https://crrev.com/2f88469345efc3399265bc460040b0dc3596409e/chrome/browser/ui/toolbar/media_router_action.cc
[modify] https://crrev.com/2f88469345efc3399265bc460040b0dc3596409e/chrome/browser/ui/toolbar/media_router_action.h
[modify] https://crrev.com/2f88469345efc3399265bc460040b0dc3596409e/chrome/browser/ui/toolbar/media_router_action_unittest.cc
[add] https://crrev.com/2f88469345efc3399265bc460040b0dc3596409e/chrome/browser/ui/views/media_router/media_router_dialog_controller_views.cc
[add] https://crrev.com/2f88469345efc3399265bc460040b0dc3596409e/chrome/browser/ui/views/media_router/media_router_dialog_controller_views.h
[modify] https://crrev.com/2f88469345efc3399265bc460040b0dc3596409e/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
[delete] https://crrev.com/c9597eb12cda23f8fa84c0e3fbaa6f22918a7f63/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.h
[rename] https://crrev.com/2f88469345efc3399265bc460040b0dc3596409e/chrome/browser/ui/webui/media_router/media_router_dialog_controller_webui_impl.cc
[add] https://crrev.com/2f88469345efc3399265bc460040b0dc3596409e/chrome/browser/ui/webui/media_router/media_router_dialog_controller_webui_impl.h
[rename] https://crrev.com/2f88469345efc3399265bc460040b0dc3596409e/chrome/browser/ui/webui/media_router/media_router_dialog_controller_webui_impl_browsertest.cc
[rename] https://crrev.com/2f88469345efc3399265bc460040b0dc3596409e/chrome/browser/ui/webui/media_router/media_router_dialog_controller_webui_impl_unittest.cc
[modify] https://crrev.com/2f88469345efc3399265bc460040b0dc3596409e/chrome/test/BUILD.gn
[modify] https://crrev.com/2f88469345efc3399265bc460040b0dc3596409e/chrome/test/media_router/media_router_integration_browsertest.cc
[modify] https://crrev.com/2f88469345efc3399265bc460040b0dc3596409e/chrome/test/media_router/media_router_integration_browsertest.h
Project Member

Comment 4 by bugdroid1@chromium.org, May 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72d48c21cd27e541f1e80f6c69982fcdaaa6133e

commit 72d48c21cd27e541f1e80f6c69982fcdaaa6133e
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Tue May 01 02:52:24 2018

Add MRUIBase and MRViewsUI

- Factor out parts of MediaRouterUI that will be shared with the Views
  implementation of the Cast dialog into MRUIBase
- Add a stub MRViewsUI class, which (in a future patch) will be
  responsible for notifying the Views dialog of sink/route updates
- Have MRUI and MRViewsUI subclass MRUIBase

Bug:  826091 
Change-Id: Id162dd1ab7b0722489f9a61f680e4f5e4de86a36
Reviewed-on: https://chromium-review.googlesource.com/994275
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554980}
[modify] https://crrev.com/72d48c21cd27e541f1e80f6c69982fcdaaa6133e/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/72d48c21cd27e541f1e80f6c69982fcdaaa6133e/chrome/browser/ui/media_router/media_router_ui_base.cc
[add] https://crrev.com/72d48c21cd27e541f1e80f6c69982fcdaaa6133e/chrome/browser/ui/media_router/media_router_ui_base.h
[add] https://crrev.com/72d48c21cd27e541f1e80f6c69982fcdaaa6133e/chrome/browser/ui/media_router/media_router_ui_helper.cc
[add] https://crrev.com/72d48c21cd27e541f1e80f6c69982fcdaaa6133e/chrome/browser/ui/media_router/media_router_ui_helper.h
[add] https://crrev.com/72d48c21cd27e541f1e80f6c69982fcdaaa6133e/chrome/browser/ui/media_router/media_router_ui_helper_unittest.cc
[add] https://crrev.com/72d48c21cd27e541f1e80f6c69982fcdaaa6133e/chrome/browser/ui/views/media_router/media_router_views_ui.cc
[add] https://crrev.com/72d48c21cd27e541f1e80f6c69982fcdaaa6133e/chrome/browser/ui/views/media_router/media_router_views_ui.h
[modify] https://crrev.com/72d48c21cd27e541f1e80f6c69982fcdaaa6133e/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/72d48c21cd27e541f1e80f6c69982fcdaaa6133e/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/72d48c21cd27e541f1e80f6c69982fcdaaa6133e/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/72d48c21cd27e541f1e80f6c69982fcdaaa6133e/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
[modify] https://crrev.com/72d48c21cd27e541f1e80f6c69982fcdaaa6133e/chrome/test/BUILD.gn
Project Member

Comment 5 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca6c2430020fce00c74323bcb91c6bbaf66993e7

commit ca6c2430020fce00c74323bcb91c6bbaf66993e7
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Fri May 11 21:06:22 2018

Show the Harmony Cast Dialog

This CL enables the most basic functionalities: showing and hiding the
dialog, showing sinks and their statuses (no throbber support yet), and
starting and stopping tab mirroring. The dialog is still behind the
ViewsCastDialog feature flag.

- MRDialogControllerViews instantiates MRViewsUI and CastDialogView
  when a dialog is requested, and destroys them when the dialog is
  closed.
- MRViewsUI sends CastDialogModel to CastDialogView whenever sinks or
  routes are updated. It also sends route requests from CastDialogView
  to MediaRouter.

This CL depends on crrev.com/c/1020231.

Bug:  826091 
Change-Id: I14ed4811dd7ccdf0144c64b6f079c06d7fc0aa6e
Reviewed-on: https://chromium-review.googlesource.com/1037907
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558017}
[modify] https://crrev.com/ca6c2430020fce00c74323bcb91c6bbaf66993e7/chrome/browser/media/router/media_router_dialog_controller.cc
[modify] https://crrev.com/ca6c2430020fce00c74323bcb91c6bbaf66993e7/chrome/browser/ui/media_router/media_router_dialog_controller_impl_base.cc
[modify] https://crrev.com/ca6c2430020fce00c74323bcb91c6bbaf66993e7/chrome/browser/ui/media_router/media_router_dialog_controller_impl_base.h
[modify] https://crrev.com/ca6c2430020fce00c74323bcb91c6bbaf66993e7/chrome/browser/ui/media_router/media_router_ui_base.cc
[modify] https://crrev.com/ca6c2430020fce00c74323bcb91c6bbaf66993e7/chrome/browser/ui/media_router/media_router_ui_base.h
[modify] https://crrev.com/ca6c2430020fce00c74323bcb91c6bbaf66993e7/chrome/browser/ui/views/media_router/cast_dialog_view.cc
[modify] https://crrev.com/ca6c2430020fce00c74323bcb91c6bbaf66993e7/chrome/browser/ui/views/media_router/media_router_dialog_controller_views.cc
[modify] https://crrev.com/ca6c2430020fce00c74323bcb91c6bbaf66993e7/chrome/browser/ui/views/media_router/media_router_dialog_controller_views.h
[modify] https://crrev.com/ca6c2430020fce00c74323bcb91c6bbaf66993e7/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
[modify] https://crrev.com/ca6c2430020fce00c74323bcb91c6bbaf66993e7/chrome/browser/ui/views/media_router/media_router_views_ui.cc
[modify] https://crrev.com/ca6c2430020fce00c74323bcb91c6bbaf66993e7/chrome/browser/ui/views/media_router/media_router_views_ui.h
[add] https://crrev.com/ca6c2430020fce00c74323bcb91c6bbaf66993e7/chrome/browser/ui/views/media_router/media_router_views_ui_unittest.cc
[modify] https://crrev.com/ca6c2430020fce00c74323bcb91c6bbaf66993e7/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/ca6c2430020fce00c74323bcb91c6bbaf66993e7/chrome/test/BUILD.gn

Comment 6 by taku...@chromium.org, May 14 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment