New issue
Advanced search Search tips

Issue 826090 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 14
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove code for Drive apps

Project Member Reported by satorux@chromium.org, Mar 27 2018

Issue description

DriveAppRegistry and related should be removed as the code is no longer used. More context:  crbug.com/794724#c10 


 

Comment 1 by sashab@chromium.org, Apr 19 2018

Labels: CrOSFilesFeature-DriveSync
Issue 767625 has been merged into this issue.
Owner: sa...@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14b989f308f4c8edc93192745b2b206592f8ccc5

commit 14b989f308f4c8edc93192745b2b206592f8ccc5
Author: Sam McNally <sammc@chromium.org>
Date: Fri Sep 14 06:17:00 2018

Remove Drive app support.

Bug:  826090 
Tbr: tzik@chromium.org
Change-Id: I987999c5a0256609bde868e891f520611d008317
Reviewed-on: https://chromium-review.googlesource.com/1220872
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591294}
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/chromeos/drive/drive_integration_service.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/chromeos/drive/drive_integration_service.h
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/chromeos/drive/file_system_util.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/chromeos/drive/file_system_util.h
[delete] https://crrev.com/7ad39081f5640b164aab32551b2121adc620f7d6/chrome/browser/chromeos/drive/file_task_executor.cc
[delete] https://crrev.com/7ad39081f5640b164aab32551b2121adc620f7d6/chrome/browser/chromeos/drive/file_task_executor.h
[delete] https://crrev.com/7ad39081f5640b164aab32551b2121adc620f7d6/chrome/browser/chromeos/drive/file_task_executor_unittest.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/chromeos/file_manager/file_tasks.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/chromeos/file_manager/file_tasks.h
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/chromeos/file_manager/file_tasks_browsertest.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/chromeos/file_manager/file_tasks_unittest.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/chromeos/file_manager/open_util.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/resources/chromeos/drive_internals.html
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/resources/chromeos/drive_internals.js
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.h
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/chrome/test/BUILD.gn
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/components/drive/BUILD.gn
[delete] https://crrev.com/7ad39081f5640b164aab32551b2121adc620f7d6/components/drive/drive_app_registry.cc
[delete] https://crrev.com/7ad39081f5640b164aab32551b2121adc620f7d6/components/drive/drive_app_registry.h
[delete] https://crrev.com/7ad39081f5640b164aab32551b2121adc620f7d6/components/drive/drive_app_registry_observer.h
[delete] https://crrev.com/7ad39081f5640b164aab32551b2121adc620f7d6/components/drive/drive_app_registry_unittest.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/components/drive/job_scheduler.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/components/drive/job_scheduler.h
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/components/drive/job_scheduler_unittest.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/components/drive/service/drive_api_service.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/components/drive/service/drive_api_service.h
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/components/drive/service/drive_service_interface.h
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/components/drive/service/dummy_drive_service.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/components/drive/service/dummy_drive_service.h
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/components/drive/service/fake_drive_service.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/components/drive/service/fake_drive_service.h
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/components/drive/service/fake_drive_service_unittest.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/google_apis/drive/drive_api_parser.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/google_apis/drive/drive_api_parser.h
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/google_apis/drive/drive_api_parser_unittest.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/google_apis/drive/drive_api_requests.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/google_apis/drive/drive_api_requests.h
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/google_apis/drive/drive_api_requests_unittest.cc
[modify] https://crrev.com/14b989f308f4c8edc93192745b2b206592f8ccc5/google_apis/drive/drive_common_callbacks.h
[delete] https://crrev.com/7ad39081f5640b164aab32551b2121adc620f7d6/google_apis/test/data/drive/applist.json
[delete] https://crrev.com/7ad39081f5640b164aab32551b2121adc620f7d6/google_apis/test/data/drive/applist_app_template.json
[delete] https://crrev.com/7ad39081f5640b164aab32551b2121adc620f7d6/google_apis/test/data/drive/applist_empty.json

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d0bdb47f5b29ea435a46e7fc11208872313c0d7

commit 6d0bdb47f5b29ea435a46e7fc11208872313c0d7
Author: Sam McNally <sammc@chromium.org>
Date: Fri Sep 21 06:20:27 2018

Remove leftover support for unused Drive API endpoints.

https://crrev.com/591294 removed the code for Drive apps, removing three
API endpoints. The URL generator methods for those endpoints were left
behind. Remove them as well as the option to use the internal endpoint;
no remaining Drive API usage requires using the internal endpoint.

Bug:  826090 
Change-Id: I99a0a60b3b9862d6a399b083d882b9a947cafc78
Reviewed-on: https://chromium-review.googlesource.com/1236617
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593094}
[modify] https://crrev.com/6d0bdb47f5b29ea435a46e7fc11208872313c0d7/components/drive/service/drive_api_service.cc
[modify] https://crrev.com/6d0bdb47f5b29ea435a46e7fc11208872313c0d7/google_apis/drive/drive_api_requests.cc
[modify] https://crrev.com/6d0bdb47f5b29ea435a46e7fc11208872313c0d7/google_apis/drive/drive_api_requests.h
[modify] https://crrev.com/6d0bdb47f5b29ea435a46e7fc11208872313c0d7/google_apis/drive/drive_api_url_generator.cc
[modify] https://crrev.com/6d0bdb47f5b29ea435a46e7fc11208872313c0d7/google_apis/drive/drive_api_url_generator.h
[modify] https://crrev.com/6d0bdb47f5b29ea435a46e7fc11208872313c0d7/google_apis/drive/drive_api_url_generator_unittest.cc

Sign in to add a comment