+better screencast

Deleted: Moving Keyboard.webm 861 KB

	Moving Keyboard.webm 861 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b3d6841cf0897f2824c799098d6c24eaa0ac679

commit 6b3d6841cf0897f2824c799098d6c24eaa0ac679
Author: Blake O'Hare <blakeo@chromium.org>
Date: Thu Apr 05 09:35:17 2018

Floating Keyboard stops propagation of drag handle events

If a touch/mouse event occurs and it is interpreted as a floating
keyboard drag event, do not propagate the event to the javascript
keyboard extension as there is no reason to.

This was causing the drag event to cause the gesture swiping to be
active while dragging the keyboard around, particularly if the keyboard
was bounded to the bottom of the screen and the user's finger is able
to move around on the keys while still moving the keyboard (see
attached bug for repro/video).

Bug:  826078 
Change-Id: I40c859f979d41a5d61e88ff0bd41808dcf3940c2
Reviewed-on: https://chromium-review.googlesource.com/997195
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548374}
[modify] https://crrev.com/6b3d6841cf0897f2824c799098d6c24eaa0ac679/ui/keyboard/container_behavior.h
[modify] https://crrev.com/6b3d6841cf0897f2824c799098d6c24eaa0ac679/ui/keyboard/container_floating_behavior.cc
[modify] https://crrev.com/6b3d6841cf0897f2824c799098d6c24eaa0ac679/ui/keyboard/container_floating_behavior.h
[modify] https://crrev.com/6b3d6841cf0897f2824c799098d6c24eaa0ac679/ui/keyboard/container_full_width_behavior.cc
[modify] https://crrev.com/6b3d6841cf0897f2824c799098d6c24eaa0ac679/ui/keyboard/container_full_width_behavior.h
[modify] https://crrev.com/6b3d6841cf0897f2824c799098d6c24eaa0ac679/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/6b3d6841cf0897f2824c799098d6c24eaa0ac679/ui/keyboard/keyboard_controller.h
[modify] https://crrev.com/6b3d6841cf0897f2824c799098d6c24eaa0ac679/ui/keyboard/keyboard_event_filter.cc
[modify] https://crrev.com/6b3d6841cf0897f2824c799098d6c24eaa0ac679/ui/keyboard/keyboard_event_filter.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35a5292481c4932de395906242f491f46baed743

commit 35a5292481c4932de395906242f491f46baed743
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Wed Apr 11 12:04:57 2018

Revert "Floating Keyboard stops propagation of drag handle events"

This reverts commit 6b3d6841cf0897f2824c799098d6c24eaa0ac679.

Reason for revert: Please refer to  crbug.com/831521  . We need to pass tap events in the drag handle.

Original change's description:
> Floating Keyboard stops propagation of drag handle events
> 
> If a touch/mouse event occurs and it is interpreted as a floating
> keyboard drag event, do not propagate the event to the javascript
> keyboard extension as there is no reason to.
> 
> This was causing the drag event to cause the gesture swiping to be
> active while dragging the keyboard around, particularly if the keyboard
> was bounded to the bottom of the screen and the user's finger is able
> to move around on the keys while still moving the keyboard (see
> attached bug for repro/video).
> 
> Bug:  826078 
> Change-Id: I40c859f979d41a5d61e88ff0bd41808dcf3940c2
> Reviewed-on: https://chromium-review.googlesource.com/997195
> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
> Commit-Queue: Blake O'Hare <blakeo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548374}

TBR=yhanada@chromium.org,blakeo@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  826078 
Bug:  831521 
Change-Id: I9dded92a6e7b2ec1f97ebd169c463686c23d5d7c
Reviewed-on: https://chromium-review.googlesource.com/1006715
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549862}
[modify] https://crrev.com/35a5292481c4932de395906242f491f46baed743/ui/keyboard/container_behavior.h
[modify] https://crrev.com/35a5292481c4932de395906242f491f46baed743/ui/keyboard/container_floating_behavior.cc
[modify] https://crrev.com/35a5292481c4932de395906242f491f46baed743/ui/keyboard/container_floating_behavior.h
[modify] https://crrev.com/35a5292481c4932de395906242f491f46baed743/ui/keyboard/container_full_width_behavior.cc
[modify] https://crrev.com/35a5292481c4932de395906242f491f46baed743/ui/keyboard/container_full_width_behavior.h
[modify] https://crrev.com/35a5292481c4932de395906242f491f46baed743/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/35a5292481c4932de395906242f491f46baed743/ui/keyboard/keyboard_controller.h
[modify] https://crrev.com/35a5292481c4932de395906242f491f46baed743/ui/keyboard/keyboard_event_filter.cc
[modify] https://crrev.com/35a5292481c4932de395906242f491f46baed743/ui/keyboard/keyboard_event_filter.h

Relanded in http://crrev.com/c/1020944

This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Is this a M67-regression, or tied to a feature launching in M-67?  

The floating keyboard is still behind a flag, but it is a regression from 66.

Approving merge to M67 Chrome OS since confirmed as a M67 regression.  Thanks

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba4717ab5fae2a37b2ee8363404b6d7b93df2228

commit ba4717ab5fae2a37b2ee8363404b6d7b93df2228
Author: Blake O'Hare <blakeo@chromium.org>
Date: Tue May 08 02:35:54 2018

Floating Keyboard: Do not propagate drag events to the extension

If a drag event occurs on the drag handle region, do not propagate the
drag event to the keyboard javascript extension. The KeyboardController
is sufficient to move it. The extension move event is sending
conflicting move messages that do not account for multiple displays.

This may be a temporary solution until a more permanent end-to-end
solution can be devised.

BUG= 826078 
TBR=blakeo@chromium.org

Change-Id: Ic0bd6d1c03ea7b08cd0c0b1d5b96314a65fb23e2
Reviewed-on: https://chromium-review.googlesource.com/1049227
Reviewed-by: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#513}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/ba4717ab5fae2a37b2ee8363404b6d7b93df2228/ui/keyboard/container_behavior.h
[modify] https://crrev.com/ba4717ab5fae2a37b2ee8363404b6d7b93df2228/ui/keyboard/container_floating_behavior.cc
[modify] https://crrev.com/ba4717ab5fae2a37b2ee8363404b6d7b93df2228/ui/keyboard/container_floating_behavior.h
[modify] https://crrev.com/ba4717ab5fae2a37b2ee8363404b6d7b93df2228/ui/keyboard/container_full_width_behavior.cc
[modify] https://crrev.com/ba4717ab5fae2a37b2ee8363404b6d7b93df2228/ui/keyboard/container_full_width_behavior.h
[modify] https://crrev.com/ba4717ab5fae2a37b2ee8363404b6d7b93df2228/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/ba4717ab5fae2a37b2ee8363404b6d7b93df2228/ui/keyboard/keyboard_controller.h
[modify] https://crrev.com/ba4717ab5fae2a37b2ee8363404b6d7b93df2228/ui/keyboard/keyboard_event_filter.cc
[modify] https://crrev.com/ba4717ab5fae2a37b2ee8363404b6d7b93df2228/ui/keyboard/keyboard_event_filter.h