New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826062 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Regression] Files app: Offline docs are not accessible when network is disconnected

Project Member Reported by sdantul...@chromium.org, Mar 26 2018

Issue description

Google Chrome	66.0.3359.52 (Official Build) beta (64-bit)
Revision	0
Platform	10452.27.0 (Official Build) beta-channel eve

What steps will reproduce the problem?
(1) Create some Google Docs files using drive.google.com 
(2) Ensure that Offline sync option is enabled
(3) Disconnect internet and open Files app -> Drive -> Offline section
(4) Try to open the recently created gdoc files

What is the expected result?
gdoc files should open without any issue

What happens instead?
New tab page shows up with error message "There is no Internet connection"

Note that there is no issue opening/editing offline docs from webpage docs.google.com/document. Unable to access the docs from Files app only.

Marking the bug as regression since the feature is working fine on M65.
 
Components: -Platform>Apps>FileManager Platform>Apps>FileManager>Drive

Comment 3 by sashab@chromium.org, Mar 27 2018

Cc: noel@chromium.org
Owner: joelhockey@chromium.org
Status: Assigned (was: Untriaged)
Joel - P1 regression, PTAL :) We can merge back a fix if its straightforward.

You can do a bisect using git bisect, I put notes in:
https://docs.google.com/document/d/1TtODxmIsYgSCCwSPYdpsHGGdrwZPASytfytNugrdUcw/edit#heading=h.egp3egyidnkx

Status: Started (was: Assigned)
Cc: jam@chromium.org juliatut...@chromium.org nvers...@yandex-team.ru
I have bisected and found the CL that caused this change is https://chromium-review.googlesource.com/c/chromium/src/+/878327

Batalov, jam@, juliatuttle@, do you have any suggestions on how to fix the cros FileManager?

It looks to be the code at https://cs.chromium.org/chromium/src/chrome/renderer/net/net_error_helper_core.cc?l=888&rcl=b0b7031e882448d2f7db62641926c0ff2ad55445 where previously a reload of the page would cause drive to load the offline page, and now the page is not reloaded.


Cc: -nvers...@yandex-team.ru invers...@yandex-team.ru
fixed email address for Vladislav.

Does anyone have any thoughts on how to fix FileManager / drive offline?  Could we revert the patch as a start?

Comment 7 Deleted

Requested revert in http://crosreview.com/985592

Comment 9 by noel@chromium.org, Apr 5 2018

Polite ping: can reviewers please help answer Joel's questions here?

Comment 10 by noel@chromium.org, Apr 5 2018

OIC, revert #8 had no bug: field, and was landed on
  https://chromium-review.googlesource.com/c/chromium/src/+/985592


Comment 11 by noel@chromium.org, Apr 5 2018

Summary: [Regression] Files app: Offline docs are not accessible when network is disconnected (was: Files app: Offline docs are not accessible when network is disconnected)

Comment 12 by noel@chromium.org, Apr 5 2018

Labels: Merge-Request-66
Project Member

Comment 13 by sheriffbot@chromium.org, Apr 5 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 14 by noel@chromium.org, Apr 5 2018

Merge review: land https://chromium-review.googlesource.com/c/chromium/src/+/985592
on M66 to fix a regression in off-line Google Docs in CrOS. 
Labels: -Merge-Review-66 Merge-Approved-66

Comment 16 by noel@chromium.org, Apr 10 2018

Cc: joelhockey@chromium.org
Owner: noel@chromium.org
Thank you, TODO(noel) merge this change to M66.

Comment 17 by noel@chromium.org, Apr 10 2018

Right, lets add a bug: number to code review #14, it did not have one.

Comment 18 by noel@chromium.org, Apr 10 2018

Correction, forget adding a bug: number, no can do after landing from gerrit UI. 
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 10 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d43a235450079123130771de42f6c359e29bc6c

commit 2d43a235450079123130771de42f6c359e29bc6c
Author: Joel Hockey <joelhockey@chromium.org>
Date: Tue Apr 10 03:55:18 2018

Revert "Fix auto reloading when a renderer is created without network."

This reverts commit b31c30d73957cd74ef289f646a4dc177f2c9ee7e.

Reason for revert: This has caused a regression in chromeos filemanager opening offline docs.  See  http://crbug.com/826062 

Bug:  826062 

Original change's description:
> Fix auto reloading when a renderer is created without network.
> 
> Pass correct status of network to error handler's constructor.
> 
> R=​jam@chromium.org, juliatuttle@chromium.org
> 
> Change-Id: Ie48ab19418c87f20f0b441fbe1ab6d44a503da22
> Reviewed-on: https://chromium-review.googlesource.com/878327
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534685}

TBR=jam@chromium.org,juliatuttle@chromium.org,inverse12@yandex-team.ru

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ia05faf69b8170371d757661203cd14fdec01de01
Reviewed-on: https://chromium-review.googlesource.com/985592
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#546943}(cherry picked from commit 5282c18cd6af03adfb9c1b9b9eaf5424a9e58458)
Reviewed-on: https://chromium-review.googlesource.com/1004274
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#642}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/chrome/renderer/chrome_render_thread_observer.cc
[modify] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/chrome/renderer/chrome_render_thread_observer.h
[modify] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/chrome/renderer/net/net_error_helper.cc
[modify] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/chrome/renderer/net/net_error_helper.h
[modify] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/chrome/renderer/net/net_error_helper_core.cc
[modify] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/chrome/renderer/net/net_error_helper_core.h
[modify] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/chrome/renderer/net/net_error_helper_core_unittest.cc

Comment 20 by noel@chromium.org, Apr 10 2018

Looking at the official build bots for M66, I see red.  Seems patches submitted to the M66 before #19 are the cause.  Waiting for that redness to be cleared by the M66 release managers ... kaibai.

Comment 21 Deleted

Comment 22 by noel@chromium.org, Apr 11 2018

Fix for #20 landed,  crbug.com/828963#c18 

Comment 23 by noel@chromium.org, Apr 11 2018

Owner: joelhockey@chromium.org
Status: Fixed (was: Started)
M66 Beta builders are now green, closing fixed.  Joel to verify fixed if that's ok.
Status: Verified (was: Fixed)
Chrome OS 10575.26.0, 67.0.3396.31

Sign in to add a comment