Issue metadata
Sign in to add a comment
|
[Regression] Files app: Offline docs are not accessible when network is disconnected |
||||||||||||||||||||
Issue descriptionGoogle Chrome 66.0.3359.52 (Official Build) beta (64-bit) Revision 0 Platform 10452.27.0 (Official Build) beta-channel eve What steps will reproduce the problem? (1) Create some Google Docs files using drive.google.com (2) Ensure that Offline sync option is enabled (3) Disconnect internet and open Files app -> Drive -> Offline section (4) Try to open the recently created gdoc files What is the expected result? gdoc files should open without any issue What happens instead? New tab page shows up with error message "There is no Internet connection" Note that there is no issue opening/editing offline docs from webpage docs.google.com/document. Unable to access the docs from Files app only. Marking the bug as regression since the feature is working fine on M65.
,
Mar 26 2018
,
Mar 27 2018
Joel - P1 regression, PTAL :) We can merge back a fix if its straightforward. You can do a bisect using git bisect, I put notes in: https://docs.google.com/document/d/1TtODxmIsYgSCCwSPYdpsHGGdrwZPASytfytNugrdUcw/edit#heading=h.egp3egyidnkx
,
Mar 27 2018
,
Mar 27 2018
I have bisected and found the CL that caused this change is https://chromium-review.googlesource.com/c/chromium/src/+/878327 Batalov, jam@, juliatuttle@, do you have any suggestions on how to fix the cros FileManager? It looks to be the code at https://cs.chromium.org/chromium/src/chrome/renderer/net/net_error_helper_core.cc?l=888&rcl=b0b7031e882448d2f7db62641926c0ff2ad55445 where previously a reload of the page would cause drive to load the offline page, and now the page is not reloaded.
,
Mar 27 2018
fixed email address for Vladislav. Does anyone have any thoughts on how to fix FileManager / drive offline? Could we revert the patch as a start?
,
Mar 29 2018
Requested revert in http://crosreview.com/985592
,
Apr 5 2018
Polite ping: can reviewers please help answer Joel's questions here?
,
Apr 5 2018
OIC, revert #8 had no bug: field, and was landed on https://chromium-review.googlesource.com/c/chromium/src/+/985592
,
Apr 5 2018
,
Apr 5 2018
,
Apr 5 2018
This bug requires manual review: We are only 11 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 5 2018
Merge review: land https://chromium-review.googlesource.com/c/chromium/src/+/985592 on M66 to fix a regression in off-line Google Docs in CrOS.
,
Apr 9 2018
,
Apr 10 2018
Thank you, TODO(noel) merge this change to M66.
,
Apr 10 2018
Right, lets add a bug: number to code review #14, it did not have one.
,
Apr 10 2018
Correction, forget adding a bug: number, no can do after landing from gerrit UI.
,
Apr 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d43a235450079123130771de42f6c359e29bc6c commit 2d43a235450079123130771de42f6c359e29bc6c Author: Joel Hockey <joelhockey@chromium.org> Date: Tue Apr 10 03:55:18 2018 Revert "Fix auto reloading when a renderer is created without network." This reverts commit b31c30d73957cd74ef289f646a4dc177f2c9ee7e. Reason for revert: This has caused a regression in chromeos filemanager opening offline docs. See http://crbug.com/826062 Bug: 826062 Original change's description: > Fix auto reloading when a renderer is created without network. > > Pass correct status of network to error handler's constructor. > > R=jam@chromium.org, juliatuttle@chromium.org > > Change-Id: Ie48ab19418c87f20f0b441fbe1ab6d44a503da22 > Reviewed-on: https://chromium-review.googlesource.com/878327 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Julia Tuttle <juliatuttle@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#534685} TBR=jam@chromium.org,juliatuttle@chromium.org,inverse12@yandex-team.ru # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia05faf69b8170371d757661203cd14fdec01de01 Reviewed-on: https://chromium-review.googlesource.com/985592 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#546943}(cherry picked from commit 5282c18cd6af03adfb9c1b9b9eaf5424a9e58458) Reviewed-on: https://chromium-review.googlesource.com/1004274 Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#642} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/chrome/browser/net/errorpage_browsertest.cc [modify] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/chrome/renderer/chrome_content_renderer_client.cc [modify] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/chrome/renderer/chrome_render_thread_observer.cc [modify] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/chrome/renderer/chrome_render_thread_observer.h [modify] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/chrome/renderer/net/net_error_helper.cc [modify] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/chrome/renderer/net/net_error_helper.h [modify] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/chrome/renderer/net/net_error_helper_core.cc [modify] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/chrome/renderer/net/net_error_helper_core.h [modify] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/chrome/renderer/net/net_error_helper_core_unittest.cc
,
Apr 10 2018
Looking at the official build bots for M66, I see red. Seems patches submitted to the M66 before #19 are the cause. Waiting for that redness to be cleared by the M66 release managers ... kaibai.
,
Apr 11 2018
Fix for #20 landed, crbug.com/828963#c18
,
Apr 11 2018
M66 Beta builders are now green, closing fixed. Joel to verify fixed if that's ok.
,
May 3 2018
Chrome OS 10575.26.0, 67.0.3396.31 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by sdantul...@chromium.org
, Mar 26 2018