New issue
Advanced search Search tips

Issue 826059 link

Starred by 3 users
Status: Fixed
Owner:
steimel@chromium.org
Closed: Apr 2018
Cc:
fbeaufort@chromium.org
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
Modern-Media-Controls


Sign in to add a comment

Local media playback for unsupported media gets height of 1

Project Member Reported by lethalantidote@chromium.org, Mar 26 2018 
Chrome Version: 67.0.3378.0 (Developer Build) (64-bit)
OS: Mac OS X 

What steps will reproduce the problem?
(1) Build unsigned copy of Chromium (or however you need to have mp4 disabled)
(2) Play downloaded MP4
(3)

What is the expected result?
Empty box of the right size

What happens instead?
Box is only at height of 1.

Comment 1 by mlamouri@chromium.org, Mar 27 2018

Components: -Internals>Media>UI Blink>Media>Controls
Labels: -Pri-3 Pri-1

Comment 2 by steimel@chromium.org, Apr 6 2018

Cc: mlamouri@chromium.org fbeaufort@chromium.org
 Issue 829444  has been merged into this issue.

Comment 3 by steimel@chromium.org, Apr 10 2018

Labels: -OS-Mac OS-Windows
Status: Started (was: Assigned)

Comment 4 by steimel@chromium.org, Apr 10 2018

Labels: OS-Android OS-Chrome OS-Linux OS-Mac
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77c104a5421840656d0e6c21f37f72dede922fc4

commit 77c104a5421840656d0e6c21f37f72dede922fc4
Author: Tommy Steimel <steimel@chromium.org>
Date: Thu Apr 19 01:20:50 2018

Prevent unloaded video sizing issues on MediaDocument

This CL removes a unneeded check in layout_video.cc which reduces the
intrinsic height of a video to 1px on MediaDocument.

Bug:  826059 
Change-Id: I539f355d4b46de7efbe183195dc506b60e14e523
Reviewed-on: https://chromium-review.googlesource.com/1005508
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551909}
[modify] https://crrev.com/77c104a5421840656d0e6c21f37f72dede922fc4/third_party/WebKit/LayoutTests/platform/linux/media/media-document-audio-repaint-expected.png
[modify] https://crrev.com/77c104a5421840656d0e6c21f37f72dede922fc4/third_party/WebKit/LayoutTests/platform/linux/media/media-document-audio-repaint-expected.txt
[modify] https://crrev.com/77c104a5421840656d0e6c21f37f72dede922fc4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/media/media-document-audio-repaint-expected.png
[modify] https://crrev.com/77c104a5421840656d0e6c21f37f72dede922fc4/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/media-document-audio-repaint-expected.png
[modify] https://crrev.com/77c104a5421840656d0e6c21f37f72dede922fc4/third_party/WebKit/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.png
[modify] https://crrev.com/77c104a5421840656d0e6c21f37f72dede922fc4/third_party/WebKit/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.txt
[modify] https://crrev.com/77c104a5421840656d0e6c21f37f72dede922fc4/third_party/WebKit/LayoutTests/platform/win/media/media-document-audio-repaint-expected.png
[modify] https://crrev.com/77c104a5421840656d0e6c21f37f72dede922fc4/third_party/WebKit/LayoutTests/platform/win/media/media-document-audio-repaint-expected.txt
[modify] https://crrev.com/77c104a5421840656d0e6c21f37f72dede922fc4/third_party/WebKit/LayoutTests/platform/win7/media/media-document-audio-repaint-expected.png
[modify] https://crrev.com/77c104a5421840656d0e6c21f37f72dede922fc4/third_party/blink/renderer/core/layout/layout_video.cc
[modify] https://crrev.com/77c104a5421840656d0e6c21f37f72dede922fc4/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css

Comment 6 by steimel@chromium.org, Apr 19 2018

Labels: Merge-Request-67
Status: Fixed (was: Started)
Project Member

Comment 7 by sheriffbot@chromium.org, Apr 20 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by gov...@chromium.org, Apr 20 2018 

Pls merge your change to M67 branch 3396 ASAP so we can pick it up for next M67 Dev/Beta release. Thank you.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 20 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9159987b11cd225be28117dd074fdaaf92b1ee96

commit 9159987b11cd225be28117dd074fdaaf92b1ee96
Author: Tommy Steimel <steimel@chromium.org>
Date: Fri Apr 20 17:26:51 2018

Prevent unloaded video sizing issues on MediaDocument

This CL removes a unneeded check in layout_video.cc which reduces the
intrinsic height of a video to 1px on MediaDocument.

Bug:  826059 
Change-Id: I539f355d4b46de7efbe183195dc506b60e14e523
Reviewed-on: https://chromium-review.googlesource.com/1005508
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551909}(cherry picked from commit 77c104a5421840656d0e6c21f37f72dede922fc4)
Reviewed-on: https://chromium-review.googlesource.com/1022150
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#165}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/9159987b11cd225be28117dd074fdaaf92b1ee96/third_party/WebKit/LayoutTests/platform/linux/media/media-document-audio-repaint-expected.png
[modify] https://crrev.com/9159987b11cd225be28117dd074fdaaf92b1ee96/third_party/WebKit/LayoutTests/platform/linux/media/media-document-audio-repaint-expected.txt
[modify] https://crrev.com/9159987b11cd225be28117dd074fdaaf92b1ee96/third_party/WebKit/LayoutTests/platform/mac-mac10.10/media/media-document-audio-repaint-expected.png
[modify] https://crrev.com/9159987b11cd225be28117dd074fdaaf92b1ee96/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/media-document-audio-repaint-expected.png
[modify] https://crrev.com/9159987b11cd225be28117dd074fdaaf92b1ee96/third_party/WebKit/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.png
[modify] https://crrev.com/9159987b11cd225be28117dd074fdaaf92b1ee96/third_party/WebKit/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.txt
[modify] https://crrev.com/9159987b11cd225be28117dd074fdaaf92b1ee96/third_party/WebKit/LayoutTests/platform/win/media/media-document-audio-repaint-expected.png
[modify] https://crrev.com/9159987b11cd225be28117dd074fdaaf92b1ee96/third_party/WebKit/LayoutTests/platform/win/media/media-document-audio-repaint-expected.txt
[modify] https://crrev.com/9159987b11cd225be28117dd074fdaaf92b1ee96/third_party/WebKit/LayoutTests/platform/win7/media/media-document-audio-repaint-expected.png
[modify] https://crrev.com/9159987b11cd225be28117dd074fdaaf92b1ee96/third_party/blink/renderer/core/layout/layout_video.cc
[modify] https://crrev.com/9159987b11cd225be28117dd074fdaaf92b1ee96/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css
►

Sign in to add a comment