New issue
Advanced search Search tips

Issue 826043 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Disallow non-committers from reverting committers' Chrome OS changes

Project Member Reported by derat@chromium.org, Mar 26 2018

Issue description

(forked from  issue 810423 , which only helped with the chromium repo)

We have trouble with random bozos clicking the Revert button on Chrome OS changes, e.g. https://crrev.com/c/976870 and https://crrev.com/c/979492.

Per agable@, "[a workaround] has been deployed, but it doesn't work fully for ChromeOS repos. At the moment, it is hardcoded to only show the Revert and Reland buttons to people who can vote "Code-Review+1", as opposed to people who can vote "Code-Review+[MAX_VALUE]". Since everyone can vote CR+1 in ChromeOS repos, it doesn't hide the buttons there.

Generalizing this behavior is rather non-trivial."
 
Cc: -tandrii@chromium.org

Comment 2 by aga...@chromium.org, Mar 27 2018

Status: Assigned (was: Untriaged)
Owner: ----
Status: Available (was: Assigned)
Unassigning from myself because I'm on sabbatical.

Sign in to add a comment