New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826028 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ChromeAppListModelUpdater::UpdateAppItemFromSyncItem

Project Member Reported by abod...@chromium.org, Mar 26 2018

Issue description

Chrome OS:10452.27.0/ 66.0.3359.52

Steps:
Seen browser crash while pressing Search key.

crash report: https://crash.corp.google.com/browse?stbtiq=5c0b180ee546d4b7

Thread 0 (id: 22133) CRASHED [SIGTRAP @ 0x00000000 ] MAGIC SIGNATURE THREAD
Stack Quality100%Show frame trust levels
0x00005ce72b593d37	(chrome -ordinal.h:304 )	ChromeAppListModelUpdater::UpdateAppItemFromSyncItem(app_list::AppListSyncableService::SyncItem*, bool, bool)
0x00005ce72b58eedd	(chrome -app_list_syncable_service.cc:567 )	app_list::AppListSyncableService::ModelUpdaterDelegate::OnAppListItemAdded(ChromeAppListItem*)
0x00005ce72b593e18	(chrome -chrome_app_list_model_updater.cc:481 )	ChromeAppListModelUpdater::OnFolderCreated(mojo::StructPtr<ash::mojom::AppListItemMetadata>)
0x00005ce72b584290	(chrome -app_list_client_impl.cc:110 )	<name omitted>
0x00005ce72773af12	(chrome -app_list.mojom.cc:4136 )	ash::mojom::AppListClientStubDispatch::Accept(ash::mojom::AppListClient*, mojo::Message*)
0x00005ce728c53fbc	(chrome -interface_endpoint_client.cc:419 )	mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*)
0x00005ce728c59719	(chrome -interface_endpoint_client.cc:306 )	mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*)
0x00005ce72621f5fd	(chrome -multiplex_router.cc:604 )	mojo::internal::MultiplexRouter::Accept(mojo::Message*)
0x00005ce72621f0e3	(chrome -connector.cc:443 )	mojo::Connector::ReadSingleMessage(unsigned int*)
0x00005ce72621f467	(chrome -connector.cc:472 )	mojo::Connector::ReadAllAvailableMessages()
0x00005ce728c65f31	(chrome -callback.h:124 )	mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&)
0x00005ce726211c08	(chrome -callback.h:95 )	base::MessageLoop::RunTask(base::PendingTask*)
0x00005ce726213a04	(chrome -message_loop.cc:403 )	base::MessagePumpLibevent::Run(base::MessagePump::Delegate*)
0x00005ce7287ceb3f	(chrome -run_loop.cc:130 )	ChromeBrowserMainParts::MainMessageLoopRun(int*)
0x00005ce726df40c0	(chrome -browser_main_loop.cc:1052 )	content::BrowserMainLoop::RunMainMessageLoopParts()
0x00005ce726df6fd1	(chrome -browser_main_runner.cc:161 )	content::BrowserMainRunnerImpl::Run()
0x00005ce726dec94d	(chrome -browser_main.cc:46 )	content::BrowserMain(content::MainFunctionParams const&)
0x00005ce7287b3ae6	(chrome -content_main_runner.cc:423 )	content::ContentMainRunnerImpl::Run()
0x00005ce7287bf793	(chrome -main.cc:453 )	service_manager::Main(service_manager::MainParams const&)
0x00005ce72630fcb8	(chrome -content_main.cc:19 )	ChromeMain
0x00007f3ea71de735	(libc-2.23.so -libc-start.c:289 )	__libc_start_main
0x00005ce726304148	(chrome + 0x01092148 )	_start
0x00007ffc0be0e677	
 
Cc: xiy...@chromium.org newcomer@chromium.org
Owner: hejq@chromium.org
Probably from the AppList migration?
Labels: Touch-Friendly-Launcher-Urgent

Comment 3 by xiy...@chromium.org, Mar 30 2018

Dup of issue 824630. However this is from M66. We need to consider whether to merge the fix to M66 before dup there.

Comment 4 by hejq@chromium.org, Apr 2 2018

Labels: Merge-Request-66
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 2 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by cmasso@google.com, Apr 3 2018

Status: Assigned (was: Untriaged)
What cl are you asking merge approval on? Can you request merge approval on the bug attached to the cl that landed? 

Please make sure to add the rationale as to why this cl is critical enough to be merged into M66 at this point in the release cycle.

Comment 7 by cmasso@google.com, Apr 3 2018

Besides, can you add the right OS(s) on this bug?
Labels: OS-Chrome

Comment 9 by hejq@chromium.org, Apr 3 2018

Thanks for replying.

What cl are you asking merge approval on?
https://chromium-review.googlesource.com/c/chromium/src/+/991238

Can you request merge approval on the bug attached to the cl that landed? 
Done. https://bugs.chromium.org/p/chromium/issues/detail?id=824630

Please make sure to add the rationale as to why this cl is critical enough to be merged into M66 at this point in the release cycle.
It's making Chrome crash after a user logs in. Also added to commit message.

Besides, can you add the right OS(s) on this bug?
Done. ChromeOS.
Labels: -Hotlist-Merge-Review -Merge-Review-66

Comment 11 by hejq@chromium.org, Apr 17 2018

Status: Fixed (was: Assigned)
Fixed by crrev.com/c/991238

Sign in to add a comment