New issue
Advanced search Search tips

Issue 826021 link

Starred by 1 user
Status: Started
Owner:
xingliu@chromium.org
Cc:
qin...@chromium.org
dtrainor@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Parse local media metadata and thumbnail

Project Member Reported by xingliu@chromium.org, Mar 26 2018 
Chrome Version: 65.*
OS: Android

Implement code to parse media metadata and get the thumbnail from certain frame of the media file.

Currently we have media parse interface, a mojo service in media_gallery_util. It will call into ffmpeg lib in an utility process. We can try to use this API.

Comment 1 by xingliu@chromium.org, Mar 26 2018 

The bitmap this API returns probably only works for audio file, standard here:

http://id3.org/id3v2.4.0-frames.

Comment 2 by xingliu@chromium.org, Mar 29 2018

Blockedon: 826975

Comment 3 by xingliu@chromium.org, Apr 4 2018 

I have a prototype CL that works on Android for metadata. The json of metadata looks like the following:

chromium: [ERROR:download_media_parser.cc(103)] @@@ OnParseDone , success: 1
04-04 10:48:59.673 10037 10037 E chromium: [ERROR:download_media_parser.cc(105)] @@@, attached_images size: 0
04-04 10:48:59.673 10037 10037 E chromium: [ERROR:download_media_parser.cc(107)] @@@, metadata size: 7
04-04 10:48:59.673 10037 10037 E chromium: [ERROR:download_media_parser.cc(108)] @@@, metadata: {
04-04 10:48:59.673 10037 10037 E chromium:    "attachedImages": [  ],
04-04 10:48:59.673 10037 10037 E chromium:    "duration": 5.568,
04-04 10:48:59.673 10037 10037 E chromium:    "height": 320,
04-04 10:48:59.673 10037 10037 E chromium:    "language": "und",
04-04 10:48:59.673 10037 10037 E chromium:    "mimeType": "video/mp4",
04-04 10:48:59.673 10037 10037 E chromium:    "rawTags": [ {
04-04 10:48:59.673 10037 10037 E chromium:       "tags": {
04-04 10:48:59.673 10037 10037 E chromium:          "compatible_brands": "mp42isomavc1",
04-04 10:48:59.673 10037 10037 E chromium:          "creation_time": "2010-03-20T21:29:11.000000Z",
04-04 10:48:59.673 10037 10037 E chromium:          "encoder": "HandBrake 0.9.4 2009112300",
04-04 10:48:59.673 10037 10037 E chromium:          "major_brand": "mp42",
04-04 10:48:59.673 10037 10037 E chromium:          "minor_version": "0"
04-04 10:48:59.673 10037 10037 E chromium:       },
04-04 10:48:59.673 10037 10037 E chromium:       "type": "mov,mp4,m4a,3gp,3g2,mj2"
04-04 10:48:59.673 10037 10037 E chromium:    }, {
04-04 10:48:59.673 10037 10037 E chromium:       "tags": {
04-04 10:48:59.673 10037 10037 E chromium:          "creation_time": "2010-03-20T21:29:11.000000Z",
04-04 10:48:59.673 10037 10037 E chromium:          "encoder": "JVT/AVC Coding",
04-04 10:48:59.673 10037 10037 E chromium:          "language": "und"
04-04 10:48:59.673 10037 10037 E chromium:       },
04-04 10:48:59.673 10037 10037 E chromium:       "type": "h264"
04-04 10:48:59.673 10037 10037 E chromium:    }, {
04-04 10:48:59.673 10037 10037 E chromium:       "tags": {
04-04 10:48:59.673 10037 10037 E chromium:          "creation_time": "2010-03-20T21:29:11.000000Z",
04-04 10:48:59.673 10037 10037 E chromium:          "language": "eng"
04-04 10:48:59.673 10037 10037 E chromium:       },
04-04 10:48:59.673 10037 10037 E chromium:       "type": "aac"
04-04 10:48:59.673 10037 10037 E chromium:    } ],
04-04 10:48:59.673 10037 10037 E chromium:    "width": 560
04-04 10:48:59.673 10037 10037 E chromium: }
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7a13e3e6e7e53f3ed67276818e99c22412feddf

commit b7a13e3e6e7e53f3ed67276818e99c22412feddf
Author: Xing Liu <xingliu@chromium.org>
Date: Fri Apr 13 16:56:03 2018

Media gallery: Decouple media gallery from extension blob reader.

Currently media gallery api reads media data from a blob in browser
process with extension's blob reader.

This CL abstracts a factory class to create MediaDataSource, so that
Android can implement a different source that read data from local file.

Eventually, media gallery api will not depend on extension, which is
not supported on Android, and can have different data source.

Bug: 826021, 826975 
Change-Id: I6d9d6c0ffc8cbae42cd036af34fb4944cf25e685
Reviewed-on: https://chromium-review.googlesource.com/997012
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550653}
[modify] https://crrev.com/b7a13e3e6e7e53f3ed67276818e99c22412feddf/chrome/browser/extensions/BUILD.gn
[add] https://crrev.com/b7a13e3e6e7e53f3ed67276818e99c22412feddf/chrome/browser/extensions/api/media_galleries/blob_data_source_factory.cc
[add] https://crrev.com/b7a13e3e6e7e53f3ed67276818e99c22412feddf/chrome/browser/extensions/api/media_galleries/blob_data_source_factory.h
[modify] https://crrev.com/b7a13e3e6e7e53f3ed67276818e99c22412feddf/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
[modify] https://crrev.com/b7a13e3e6e7e53f3ed67276818e99c22412feddf/chrome/services/media_gallery_util/ipc_data_source.cc
[modify] https://crrev.com/b7a13e3e6e7e53f3ed67276818e99c22412feddf/chrome/services/media_gallery_util/ipc_data_source.h
[modify] https://crrev.com/b7a13e3e6e7e53f3ed67276818e99c22412feddf/chrome/services/media_gallery_util/public/cpp/safe_media_metadata_parser.cc
[modify] https://crrev.com/b7a13e3e6e7e53f3ed67276818e99c22412feddf/chrome/services/media_gallery_util/public/cpp/safe_media_metadata_parser.h
[modify] https://crrev.com/b7a13e3e6e7e53f3ed67276818e99c22412feddf/chrome/services/media_gallery_util/public/mojom/media_parser.mojom

Comment 5 by dalecur...@chromium.org, Apr 13 2018 

Just FYI there's already a FileDataSource that you might be able to use then.

Comment 6 by xingliu@chromium.org, Apr 13 2018 

dalecurtis@, thanks, good to know. This will be helpful in test.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7a13e3e6e7e53f3ed67276818e99c22412feddf

commit b7a13e3e6e7e53f3ed67276818e99c22412feddf
Author: Xing Liu <xingliu@chromium.org>
Date: Fri Apr 13 16:56:03 2018

Media gallery: Decouple media gallery from extension blob reader.

Currently media gallery api reads media data from a blob in browser
process with extension's blob reader.

This CL abstracts a factory class to create MediaDataSource, so that
Android can implement a different source that read data from local file.

Eventually, media gallery api will not depend on extension, which is
not supported on Android, and can have different data source.

Bug: 826021, 826975 
Change-Id: I6d9d6c0ffc8cbae42cd036af34fb4944cf25e685
Reviewed-on: https://chromium-review.googlesource.com/997012
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550653}
[modify] https://crrev.com/b7a13e3e6e7e53f3ed67276818e99c22412feddf/chrome/browser/extensions/BUILD.gn
[add] https://crrev.com/b7a13e3e6e7e53f3ed67276818e99c22412feddf/chrome/browser/extensions/api/media_galleries/blob_data_source_factory.cc
[add] https://crrev.com/b7a13e3e6e7e53f3ed67276818e99c22412feddf/chrome/browser/extensions/api/media_galleries/blob_data_source_factory.h
[modify] https://crrev.com/b7a13e3e6e7e53f3ed67276818e99c22412feddf/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
[modify] https://crrev.com/b7a13e3e6e7e53f3ed67276818e99c22412feddf/chrome/services/media_gallery_util/ipc_data_source.cc
[modify] https://crrev.com/b7a13e3e6e7e53f3ed67276818e99c22412feddf/chrome/services/media_gallery_util/ipc_data_source.h
[modify] https://crrev.com/b7a13e3e6e7e53f3ed67276818e99c22412feddf/chrome/services/media_gallery_util/public/cpp/safe_media_metadata_parser.cc
[modify] https://crrev.com/b7a13e3e6e7e53f3ed67276818e99c22412feddf/chrome/services/media_gallery_util/public/cpp/safe_media_metadata_parser.h
[modify] https://crrev.com/b7a13e3e6e7e53f3ed67276818e99c22412feddf/chrome/services/media_gallery_util/public/mojom/media_parser.mojom
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/353ce8eafb9ad2daa4472ade16dc7a61840d4289

commit 353ce8eafb9ad2daa4472ade16dc7a61840d4289
Author: Xing Liu <xingliu@chromium.org>
Date: Fri Apr 20 20:31:13 2018

Media gallery service: Decouple from extension serialization.

Currently media gallery API serializes the metadata inside media gallery
util service with Chrome extension's idl generated dictionary
serializer.

Since download will use the service on Android, it can't depend on
extension. This CL introduces mojo metadata struct for media gallery
util service and does the serialization in chrome extension code outside
media gallery util service.


Bug: 826021, 826975 
Change-Id: Iae14d2c443824c826b27a96c2a9aad6de018cb59
Reviewed-on: https://chromium-review.googlesource.com/1002533
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552453}
[modify] https://crrev.com/353ce8eafb9ad2daa4472ade16dc7a61840d4289/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/353ce8eafb9ad2daa4472ade16dc7a61840d4289/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
[modify] https://crrev.com/353ce8eafb9ad2daa4472ade16dc7a61840d4289/chrome/browser/extensions/api/media_galleries/media_galleries_api.h
[add] https://crrev.com/353ce8eafb9ad2daa4472ade16dc7a61840d4289/chrome/browser/extensions/api/media_galleries/media_galleries_api_util.cc
[add] https://crrev.com/353ce8eafb9ad2daa4472ade16dc7a61840d4289/chrome/browser/extensions/api/media_galleries/media_galleries_api_util.h
[modify] https://crrev.com/353ce8eafb9ad2daa4472ade16dc7a61840d4289/chrome/services/media_gallery_util/media_metadata_parser.cc
[modify] https://crrev.com/353ce8eafb9ad2daa4472ade16dc7a61840d4289/chrome/services/media_gallery_util/media_metadata_parser.h
[modify] https://crrev.com/353ce8eafb9ad2daa4472ade16dc7a61840d4289/chrome/services/media_gallery_util/media_parser.cc
[modify] https://crrev.com/353ce8eafb9ad2daa4472ade16dc7a61840d4289/chrome/services/media_gallery_util/public/cpp/DEPS
[modify] https://crrev.com/353ce8eafb9ad2daa4472ade16dc7a61840d4289/chrome/services/media_gallery_util/public/cpp/safe_media_metadata_parser.cc
[modify] https://crrev.com/353ce8eafb9ad2daa4472ade16dc7a61840d4289/chrome/services/media_gallery_util/public/cpp/safe_media_metadata_parser.h
[modify] https://crrev.com/353ce8eafb9ad2daa4472ade16dc7a61840d4289/chrome/services/media_gallery_util/public/mojom/media_parser.mojom

Comment 9 by xingliu@chromium.org, Apr 20 2018

Blockedon: -826975
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/302e0653717ecec2fa09985e055aa6f8b08a847e

commit 302e0653717ecec2fa09985e055aa6f8b08a847e
Author: Xing Liu <xingliu@chromium.org>
Date: Fri Apr 27 18:23:08 2018

Download: Implement media parser to get media metadata.

This CL hooks android download code to media gallery util service, which
provides the functionality to safely parse media metadata in an utility
process. Also includes necessary change to build media gallery util
service on Android.


Bug: 826021
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie76992ed65b746b784374b5acefcdebe4e26fe50
Reviewed-on: https://chromium-review.googlesource.com/1028614
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554427}
[modify] https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/app/BUILD.gn
[modify] https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/app/generated_resources.grd
[modify] https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/browser/BUILD.gn
[add] https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/browser/android/download/download_media_parser.cc
[add] https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/browser/android/download/download_media_parser.h
[add] https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/browser/android/download/local_media_data_source_factory.cc
[add] https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/browser/android/download/local_media_data_source_factory.h
[modify] https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/utility/BUILD.gn
[modify] https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/media/filters/BUILD.gn
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38cfb4d63291bd1f58e3c80484cb8370dd3e4f87

commit 38cfb4d63291bd1f58e3c80484cb8370dd3e4f87
Author: Xing Liu <xingliu@chromium.org>
Date: Mon Jul 16 18:40:37 2018

Download Media: Adds a JNI bridge for download media parser.

This CL adds a JNI bridge for DownloadMediaParser. Since Android
currently doesn't support browser test, a high level java test needs
this bridge. Also the UI code may call through this routine.

Bug: 826021
Change-Id: I58dfb770fc03bcc567b55a98eb0a8c51d0f02052
Reviewed-on: https://chromium-review.googlesource.com/1136523
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575362}
[add] https://crrev.com/38cfb4d63291bd1f58e3c80484cb8370dd3e4f87/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadMediaParserBridge.java
[modify] https://crrev.com/38cfb4d63291bd1f58e3c80484cb8370dd3e4f87/chrome/android/java_sources.gni
[modify] https://crrev.com/38cfb4d63291bd1f58e3c80484cb8370dd3e4f87/chrome/browser/BUILD.gn
[add] https://crrev.com/38cfb4d63291bd1f58e3c80484cb8370dd3e4f87/chrome/browser/android/download/download_media_parser_bridge.cc
[add] https://crrev.com/38cfb4d63291bd1f58e3c80484cb8370dd3e4f87/chrome/browser/android/download/download_media_parser_bridge.h

Comment 12 by xingliu@chromium.org, Aug 24 

Video thumbnail out of process prototype is basically working.
screencap.png
123 KB View Download
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0a0fb97befa1021400e97910c637712d8f07789

commit f0a0fb97befa1021400e97910c637712d8f07789
Author: Xing Liu <xingliu@chromium.org>
Date: Wed Sep 05 18:33:50 2018

Video thumbnail: Extract video frame on Android.

This CL implements the functionality to extract one encoded video key
frame in utility process with ffmpeg for video thumbnail retrieval.

The decoding will be done in later CLs with MojoVideoDecoder.

TBR=dtrainor@chromium.org

Bug: 826021
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia36ffe5ab4bb6fc32e55f1de089f07046e72a1bd
Reviewed-on: https://chromium-review.googlesource.com/1145780
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588946}
[modify] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/android/BUILD.gn
[modify] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadMediaParserBridge.java
[modify] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/android/java_sources.gni
[add] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadMediaParserTest.java
[modify] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/browser/android/download/download_media_parser.cc
[modify] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/browser/android/download/download_media_parser.h
[modify] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/browser/android/download/download_media_parser_bridge.cc
[modify] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/browser/android/download/download_media_parser_bridge.h
[modify] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/browser/android/download/local_media_data_source_factory.h
[modify] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/services/media_gallery_util/BUILD.gn
[add] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/services/media_gallery_util/media_parser_android.cc
[add] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/services/media_gallery_util/media_parser_android.h
[add] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/services/media_gallery_util/media_parser_android_unittest.cc
[modify] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/services/media_gallery_util/media_parser_factory.cc
[modify] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/services/media_gallery_util/public/mojom/BUILD.gn
[modify] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/services/media_gallery_util/public/mojom/media_parser.mojom
[modify] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/test/BUILD.gn
[modify] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/media/filters/BUILD.gn
[add] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/media/filters/android/video_frame_extractor.cc
[add] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/media/filters/android/video_frame_extractor.h
[add] https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/media/filters/android/video_frame_extractor_unittest.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e57733325074452402b2f56fc392c8c16201fae6

commit e57733325074452402b2f56fc392c8c16201fae6
Author: Xing Liu <xingliu@chromium.org>
Date: Tue Sep 11 19:08:00 2018

Video Thumbnail: Decode the video frame on Android.

This CL does the following things:

1. Implements a GpuVideoAcceleratorFactories for browser process in
content/ to create MojoVideoDecoder in the browser process.

2. Decodes video frame with MojoVideoDecoder in browser process in
DownloadMediaParser. The actual decoding happens in GPU process with
Android MediaCodec, which is same as other usages for MediaCodec based
decoders.

Test is covered in DownloadMediaParserTest.

TBR=dtrainor@chromium.org

Bug: 826021
Change-Id: I242ff31ba8f205af3b03709fb78bd14f5bc33e45
Reviewed-on: https://chromium-review.googlesource.com/1212343
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590431}
[modify] https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/chrome/browser/BUILD.gn
[modify] https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/chrome/browser/android/DEPS
[modify] https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/chrome/browser/android/download/download_media_parser.cc
[modify] https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/chrome/browser/android/download/download_media_parser.h
[modify] https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/content/browser/BUILD.gn
[add] https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/content/browser/media/android/browser_gpu_video_accelerator_factories.cc
[add] https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/content/browser/media/android/browser_gpu_video_accelerator_factories.h
[modify] https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/content/public/browser/BUILD.gn
[add] https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/content/public/browser/android/gpu_video_accelerator_factories_provider.h
[modify] https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/media/mojo/clients/BUILD.gn
[modify] https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/media/video/gpu_video_accelerator_factories.h
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f529e3a26deeb24f21508d77b9ebb7c96bc226f

commit 9f529e3a26deeb24f21508d77b9ebb7c96bc226f
Author: Xing Liu <xingliu@chromium.org>
Date: Fri Sep 14 18:28:18 2018

Android Video Thumbnail: Render video frame to bitmap.

This CL finishes the video thumbnail pipeline for most codec except
vp8, vp9. Now it's ready to hook to the UI frontend. It does following:

1. Render the video frame with existing media toolkit, which can read
back pixel data from a texture in GPU process.

2. Plumbs a few metadata fields and thumbnail bitmap to Java layer.

Bug: 826021
Change-Id: Id6635975726f4b12ab51e01cb6b3e78a198632f4
Reviewed-on: https://chromium-review.googlesource.com/1222694
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591406}
[add] https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadMediaData.java
[modify] https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadMediaParserBridge.java
[modify] https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/android/java_sources.gni
[modify] https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadMediaParserTest.java
[modify] https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/browser/BUILD.gn
[modify] https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/browser/android/download/download_media_parser.cc
[modify] https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/browser/android/download/download_media_parser.h
[modify] https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/browser/android/download/download_media_parser_bridge.cc
[add] https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/browser/android/download/video_frame_thumbnail_converter.cc
[add] https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/browser/android/download/video_frame_thumbnail_converter.h
[modify] https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/content/browser/media/android/browser_gpu_video_accelerator_factories.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4679a2dc1ed0db5c5a98e019880d4030181ca6f3

commit 4679a2dc1ed0db5c5a98e019880d4030181ca6f3
Author: Xing Liu <xingliu@chromium.org>
Date: Mon Oct 01 19:57:33 2018

Android video thumbnail: Generate thumbnails for vp8, vp9 videos.

This CL does the following:

1. Use VpxVideoDecoder in utility process to do software decoding for
vp8, vp9 video files.

2. Simplify the class to render media::VideoFrame into bitmap, since
PaintCanvasVideoRenderer works for all kind of VideoFrames.

3. Do not retrieve poster image from metadata. The mime type of the
poster image is inferred from mime sniffer, and needs to be
processed in sandbox process.


Bug: 826021
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I91c9cf72a75be4bc3a95203a40633647e079a40a
Reviewed-on: https://chromium-review.googlesource.com/1234859
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595523}
[modify] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/android/BUILD.gn
[modify] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadMediaParserTest.java
[modify] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/browser/BUILD.gn
[modify] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/browser/android/download/download_media_parser.cc
[modify] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/browser/android/download/download_media_parser.h
[delete] https://crrev.com/888b9a2fcfd57b1d235d60c26fe204ebe8ebb533/chrome/browser/android/download/video_frame_thumbnail_converter.cc
[delete] https://crrev.com/888b9a2fcfd57b1d235d60c26fe204ebe8ebb533/chrome/browser/android/download/video_frame_thumbnail_converter.h
[modify] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/services/media_gallery_util/BUILD.gn
[modify] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/services/media_gallery_util/media_parser_android.cc
[modify] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/services/media_gallery_util/media_parser_android.h
[modify] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/services/media_gallery_util/media_parser_android_unittest.cc
[modify] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/services/media_gallery_util/public/mojom/media_parser.mojom
[modify] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/base/BUILD.gn
[add] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/base/video_thumbnail_decoder.cc
[add] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/base/video_thumbnail_decoder.h
[add] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/base/video_thumbnail_decoder_unittest.cc
[modify] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/filters/android/video_frame_extractor.cc
[modify] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/filters/android/video_frame_extractor.h
[modify] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/filters/android/video_frame_extractor_unittest.cc
[modify] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/mojo/common/mojo_shared_buffer_video_frame.cc
[modify] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/mojo/common/mojo_shared_buffer_video_frame.h
[modify] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/mojo/common/mojo_shared_buffer_video_frame_unittest.cc
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25a3837ec57a6dea8ba52776728542e00f0f0f74

commit 25a3837ec57a6dea8ba52776728542e00f0f0f74
Author: Xing Liu <xingliu@chromium.org>
Date: Tue Oct 02 02:50:51 2018

Android Video Thumbnail: Hook video thumbnail backend to UI.

This CL hooks the video thumbnail backend to the UI layer of new
download home.

Bug: 826021
Change-Id: I190ad09e8231d94d7546128bd1d22dc39f4d5f35
Reviewed-on: https://chromium-review.googlesource.com/1247529
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595706}
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/java/res_download/layout/download_manager_video_item.xml
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadMediaParserBridge.java
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/java/src/org/chromium/chrome/browser/download/home/glue/ThumbnailRequestGlue.java
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/UiUtils.java
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ImageFetcher.java
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/java/src/org/chromium/chrome/browser/widget/ThumbnailGenerator.java
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/java/src/org/chromium/chrome/browser/widget/ThumbnailProvider.java
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadMediaParserTest.java
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ThumbnailDiskStorageTest.java
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ThumbnailProviderImplTest.java
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/BUILD.gn
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/android/download/download_media_parser.cc
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/android/download/download_media_parser.h
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/android/download/download_media_parser_bridge.cc
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/android/download/download_media_parser_bridge.h
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/android/widget/thumbnail_generator.cc
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/android/widget/thumbnail_generator.h
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/download/image_thumbnail_request.cc
[modify] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/download/image_thumbnail_request.h
[add] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/download/thumbnail_util.cc
[add] https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/download/thumbnail_util.h
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23c98a65baed441b3418ef542d8e4d86bb18f485

commit 23c98a65baed441b3418ef542d8e4d86bb18f485
Author: Xing Liu <xingliu@chromium.org>
Date: Thu Oct 11 18:51:35 2018

Download media: Adds metrics for download media parser.

This CL adds the metrics for download media parser, so we can
understand the overall reliability of the feature.

TBR=jwd@chormium.org

Bug: 826021
Change-Id: I2f556b3ab206c2a2cdbca9bd8d7d99979cd385a9
Reviewed-on: https://chromium-review.googlesource.com/c/1257859
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598871}
[modify] https://crrev.com/23c98a65baed441b3418ef542d8e4d86bb18f485/chrome/browser/android/download/download_media_parser.cc
[modify] https://crrev.com/23c98a65baed441b3418ef542d8e4d86bb18f485/chrome/browser/android/download/download_media_parser.h
[modify] https://crrev.com/23c98a65baed441b3418ef542d8e4d86bb18f485/chrome/browser/download/download_stats.cc
[modify] https://crrev.com/23c98a65baed441b3418ef542d8e4d86bb18f485/chrome/browser/download/download_stats.h
[modify] https://crrev.com/23c98a65baed441b3418ef542d8e4d86bb18f485/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/23c98a65baed441b3418ef542d8e4d86bb18f485/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment