New issue
Advanced search Search tips

Issue 826011 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Nov 15
Cc:
eugene...@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: 2019-01-15
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Remove CameraControllerTest.TestAVCaptureDeviceValue unit test when iOS 10 is deprecated

Project Member Reported by pkl@chromium.org, Mar 26 2018 
The unit test of CameraControllerTest.TestAVCaptureDeviceValue was added to detect iOS re-defintion of AVCaptureDeviceTypeBuiltInWideAngleCamera constant. The hardcoded value is used for iOS 10.0 compatibility.

The unit test can be delete when iOS 10.0 is deprecated.

Comment 1 by eugene...@chromium.org, Mar 26 2018

NextAction: 2019-01-15
This should be ready for removal in a year.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dc40ed9da4680e607550a48fd8636854b4476ca

commit 2dc40ed9da4680e607550a48fd8636854b4476ca
Author: Justin Cohen <justincohen@google.com>
Date: Thu Nov 15 21:22:16 2018

[ios] Remove more iOS10 code.

Followup to crrev.com/c/1335207, which missed some @available calls.

Bug: 894099,  826369 ,  826011 
Change-Id: I901cf055264b73ac6c2cebddabb0c050e53d8f0f
Reviewed-on: https://chromium-review.googlesource.com/c/1335960
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608507}
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/app_launcher/BUILD.gn
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/app_launcher/app_launcher_coordinator.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/app_launcher/app_launcher_util.h
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/app_launcher/app_launcher_util.mm
[delete] https://crrev.com/200318d56a2f658c725b104eec7a61d03581be57/ios/chrome/browser/ui/app_launcher/app_launcher_util_unittest.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/bookmarks/cells/bookmark_parent_folder_item.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/bookmarks/cells/bookmark_text_field_item.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_articles_header_item.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/first_run/welcome_to_chrome_view.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/ntp/incognito_view.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/qr_scanner/BUILD.gn
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/qr_scanner/camera_controller.mm
[delete] https://crrev.com/200318d56a2f658c725b104eec7a61d03581be57/ios/chrome/browser/ui/qr_scanner/camera_controller_unittest.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/reading_list/empty_reading_list_message_util.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/settings/cells/settings_detail_item.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/settings/cells/settings_switch_item.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/table_view/cells/table_view_detail_text_item.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/table_view/table_view_navigation_controller.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/toolbar/adaptive_toolbar_view_controller.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/util/uikit_ui_util.h
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/util/uikit_ui_util.mm
[modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/test/BUILD.gn

Comment 3 by justincohen@chromium.org, Nov 15

Status: Fixed (was: Available)

Comment 4 by monor...@bugs.chromium.org, Jan 15 

The NextAction date has arrived: 2019-01-15
►

Sign in to add a comment