Supersize: Unify or distinguish ** from Overhead |
|||
Issue descriptionFrom: https://crrev.com/c/980779 There's a spot in some of the other goldens that looks like: Padding accounts for 48 bytes (0.0%) 3 placeholders (symbols that start with **) account for 35830760 bytes (99.8%) Can you also add a line to this output such that it says how much goes to overhead symbols? Hurt my head a little bit to think about this, but I think: "star symbol" == "** foo" == "Placeholder symbol" --> size is not padding "Overhead symbol" == "Overhead: " --> size is padding. I'm not actually sure this distinction is useful though... Maybe we should just convert everything to Overhead: or "**", and have them all be padding-only?
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a216271ffcb01d303243e85605f5da8478de049d commit a216271ffcb01d303243e85605f5da8478de049d Author: Peter Wen <wnwen@chromium.org> Date: Wed Apr 04 16:28:16 2018 Supersize: Categorize pak artifacts as overhead This compression overhead should be a padding-only symbol since it is purely overhead that is inactionable. Bug: 826008 Change-Id: I6d2b21676d3cd41efdb738d1c85b4f783dff9286 Reviewed-on: https://chromium-review.googlesource.com/995964 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#548087} [modify] https://crrev.com/a216271ffcb01d303243e85605f5da8478de049d/tools/binary_size/libsupersize/archive.py [modify] https://crrev.com/a216271ffcb01d303243e85605f5da8478de049d/tools/binary_size/libsupersize/testdata/Archive_Apk.golden [modify] https://crrev.com/a216271ffcb01d303243e85605f5da8478de049d/tools/binary_size/libsupersize/testdata/Archive_Pak_Files.golden
,
Apr 12 2018
This is actually not very straightforward, leaving this for future analysis.
,
Yesterday
(36 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1db34c333b55e4c32cde54258e793fdf6cb7963 commit d1db34c333b55e4c32cde54258e793fdf6cb7963 Author: agrieve <agrieve@chromium.org> Date: Tue Jan 22 00:54:09 2019 //tools/binary_size/README.md: Add sentence about "star symbols" Bug: 826008 Change-Id: I2619cef2f5688961b2ece93ef0d491ff8c813b90 Reviewed-on: https://chromium-review.googlesource.com/c/1426140 Auto-Submit: agrieve <agrieve@chromium.org> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#624705} [modify] https://crrev.com/d1db34c333b55e4c32cde54258e793fdf6cb7963/tools/binary_size/README.md
,
Yesterday
(36 hours ago)
|
|||
►
Sign in to add a comment |
|||
Comment 1 by wnwen@chromium.org
, Mar 29 2018