The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/6ccf1128aaadc29f1898f036d868d2fe8124f24d

commit 6ccf1128aaadc29f1898f036d868d2fe8124f24d
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Mar 29 01:06:37 2018

[buildbucket] use v1 package alias

When importing common/api/buildbucket/v1, use v1 package alias.

R=jchinlee@chromium.org, tandrii@chromium.org

Bug: 826006
Change-Id: Ib3216e7f5b0704baae70b77d4e0c832e90715e06
Reviewed-on: https://chromium-review.googlesource.com/985105
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/6ccf1128aaadc29f1898f036d868d2fe8124f24d/buildbucket/build.go
[modify] https://crrev.com/6ccf1128aaadc29f1898f036d868d2fe8124f24d/buildbucket/build_test.go
[modify] https://crrev.com/6ccf1128aaadc29f1898f036d868d2fe8124f24d/buildbucket/status.go
[modify] https://crrev.com/6ccf1128aaadc29f1898f036d868d2fe8124f24d/buildbucket/status_test.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/c7ca41c7a8d1c07125a7ee8c95cbc58a51ff20e6

commit c7ca41c7a8d1c07125a7ee8c95cbc58a51ff20e6
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Mar 29 19:04:38 2018

[buildbucket] add initial protos

These protos have been copied from
https://chromium.googlesource.com/infra/infra/+/27cb9b6cd981ddc2775641ab5b4c6cc122e8b108/appengine/cr-buildbucket/proto
with the following modifications:
- updated copyright
- added go_package option
- fixed imports

No changes to the schema.

Bug: 826006
Change-Id: I84057fe812496f76a94ad7534d8c9ea5f8ca59ce
Reviewed-on: https://chromium-review.googlesource.com/985496
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[add] https://crrev.com/c7ca41c7a8d1c07125a7ee8c95cbc58a51ff20e6/buildbucket/proto/build.pb.go
[add] https://crrev.com/c7ca41c7a8d1c07125a7ee8c95cbc58a51ff20e6/buildbucket/proto/build.proto
[add] https://crrev.com/c7ca41c7a8d1c07125a7ee8c95cbc58a51ff20e6/buildbucket/proto/common.pb.go
[add] https://crrev.com/c7ca41c7a8d1c07125a7ee8c95cbc58a51ff20e6/buildbucket/proto/common.proto
[add] https://crrev.com/c7ca41c7a8d1c07125a7ee8c95cbc58a51ff20e6/buildbucket/proto/gen.go
[add] https://crrev.com/c7ca41c7a8d1c07125a7ee8c95cbc58a51ff20e6/buildbucket/proto/step.pb.go
[add] https://crrev.com/c7ca41c7a8d1c07125a7ee8c95cbc58a51ff20e6/buildbucket/proto/step.proto

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/3820bf0c12200962821cceaf38beec74b38d2e09

commit 3820bf0c12200962821cceaf38beec74b38d2e09
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Mar 29 20:03:48 2018

[buildbucket] move tag consts to v1

The tag keys "builder", "build_address" and "buildset" are specific to v1.
Move them into the v1 package.

Bug: 826006
Change-Id: Ic6bf966a2963e9e7d2447a6e1d6dcedccb6a7242
Reviewed-on: https://chromium-review.googlesource.com/985624
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/3820bf0c12200962821cceaf38beec74b38d2e09/buildbucket/build.go
[modify] https://crrev.com/3820bf0c12200962821cceaf38beec74b38d2e09/buildbucket/buildset.go
[modify] https://crrev.com/3820bf0c12200962821cceaf38beec74b38d2e09/common/api/buildbucket/buildbucket/v1/const.go
[modify] https://crrev.com/3820bf0c12200962821cceaf38beec74b38d2e09/milo/buildsource/buildbot/buildstore/query.go
[modify] https://crrev.com/3820bf0c12200962821cceaf38beec74b38d2e09/milo/buildsource/buildbucket/builder.go
[modify] https://crrev.com/3820bf0c12200962821cceaf38beec74b38d2e09/milo/buildsource/buildbucket/pubsub.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/ac86caba682113a5a4a6676e2b7b4fd2dd9e29cd

commit ac86caba682113a5a4a6676e2b7b4fd2dd9e29cd
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Mar 29 20:44:29 2018

[buildbucket] remove Rietveld support

Rietveld is not used anymore.

R=jchinlee@chromium.org

Bug: 826006
Change-Id: I1a5152ccda3430a430fd26e531e63c44b30d57f7
Reviewed-on: https://chromium-review.googlesource.com/985633
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/ac86caba682113a5a4a6676e2b7b4fd2dd9e29cd/buildbucket/buildset.go
[modify] https://crrev.com/ac86caba682113a5a4a6676e2b7b4fd2dd9e29cd/buildbucket/buildset_test.go
[modify] https://crrev.com/ac86caba682113a5a4a6676e2b7b4fd2dd9e29cd/milo/buildsource/buildbot/build.go
[modify] https://crrev.com/ac86caba682113a5a4a6676e2b7b4fd2dd9e29cd/milo/buildsource/buildbot/expectations/chromium_presubmit.426944.build.json
[modify] https://crrev.com/ac86caba682113a5a4a6676e2b7b4fd2dd9e29cd/milo/buildsource/buildbot/expectations/win_chromium_rel_ng.246309.build.json
[modify] https://crrev.com/ac86caba682113a5a4a6676e2b7b4fd2dd9e29cd/milo/buildsource/swarming/expectations/build-expired.json
[modify] https://crrev.com/ac86caba682113a5a4a6676e2b7b4fd2dd9e29cd/milo/frontend/expectations/buildbot.build-Debug_page-_chromium_presubmit_426944.html
[modify] https://crrev.com/ac86caba682113a5a4a6676e2b7b4fd2dd9e29cd/milo/frontend/expectations/buildbot.build-Debug_page-_win_chromium_rel_ng_246309.html
[modify] https://crrev.com/ac86caba682113a5a4a6676e2b7b4fd2dd9e29cd/milo/frontend/expectations/swarming.build-build-expired.html
[modify] https://crrev.com/ac86caba682113a5a4a6676e2b7b4fd2dd9e29cd/milo/frontend/ui/build.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/f1ea7a9c1a9cccc76026125106f09cd45c58047b

commit f1ea7a9c1a9cccc76026125106f09cd45c58047b
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Mar 29 20:51:00 2018

[buildbucket] move Timestamp functions to v1

luci/buildbucket's Timestamp functions are specific to v1. Move them there.

Bug: 826006
Change-Id: If5bcad2fa565a72b78cdecab6698531d6489cf6e
Reviewed-on: https://chromium-review.googlesource.com/985619
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/f1ea7a9c1a9cccc76026125106f09cd45c58047b/buildbucket/build.go
[add] https://crrev.com/f1ea7a9c1a9cccc76026125106f09cd45c58047b/common/api/buildbucket/buildbucket/v1/timestamp.go
[modify] https://crrev.com/f1ea7a9c1a9cccc76026125106f09cd45c58047b/milo/buildsource/buildbucket/pubsub_test.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/1823d8f43f9b895e24745a976f16f89707ac1252

commit 1823d8f43f9b895e24745a976f16f89707ac1252
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Mar 29 21:31:28 2018

[buildbucket] Refactor buildset types

Buildset types in luci/buildbucket package will be replaced with protos that
are being added in https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/985496/2/buildbucket/proto/common.pb.go

The protos are a bit different, so update the existing types to make migration
easier:
- Rename .String() to .BuildSet() because protoc-generated structs already
  have a different .String() implementation
- Rename GerritChange.PatchSet to Patchset, and make it int64
- Rename GitilesCommit.Revision to Id

Bug: 826006
Change-Id: I0b4aac7f193c029d2d591c9f12b15ca96f04695a
Reviewed-on: https://chromium-review.googlesource.com/985799
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/1823d8f43f9b895e24745a976f16f89707ac1252/buildbucket/build.go
[modify] https://crrev.com/1823d8f43f9b895e24745a976f16f89707ac1252/buildbucket/buildset.go
[modify] https://crrev.com/1823d8f43f9b895e24745a976f16f89707ac1252/buildbucket/buildset_test.go
[modify] https://crrev.com/1823d8f43f9b895e24745a976f16f89707ac1252/luci_notify/notify/pubsub.go
[modify] https://crrev.com/1823d8f43f9b895e24745a976f16f89707ac1252/luci_notify/notify/pubsub_test.go
[modify] https://crrev.com/1823d8f43f9b895e24745a976f16f89707ac1252/milo/buildsource/buildbot/build.go
[modify] https://crrev.com/1823d8f43f9b895e24745a976f16f89707ac1252/milo/buildsource/buildbot/buildstore/build.go
[modify] https://crrev.com/1823d8f43f9b895e24745a976f16f89707ac1252/milo/buildsource/buildbot/buildstore/buildbucket.go
[modify] https://crrev.com/1823d8f43f9b895e24745a976f16f89707ac1252/milo/common/model/build_summary.go
[modify] https://crrev.com/1823d8f43f9b895e24745a976f16f89707ac1252/milo/frontend/ui/build.go
[modify] https://crrev.com/1823d8f43f9b895e24745a976f16f89707ac1252/scheduler/appengine/engine/request.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/094a323437500847b4b5a95fddfd936039df1dd0

commit 094a323437500847b4b5a95fddfd936039df1dd0
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Mar 29 23:56:10 2018

[buildbucket] use protos as bulidset types

Use GerritChagne and GitilesCommit protobuf messages as buildsets.
Remove custom structs.
Update clients.

Bug: 826006
Change-Id: I28c99417488b96c43790cbb2c691f4be9c3e4d9e
Reviewed-on: https://chromium-review.googlesource.com/985800
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/094a323437500847b4b5a95fddfd936039df1dd0/buildbucket/build.go
[modify] https://crrev.com/094a323437500847b4b5a95fddfd936039df1dd0/buildbucket/build_test.go
[rename] https://crrev.com/094a323437500847b4b5a95fddfd936039df1dd0/buildbucket/proto/buildset.go
[rename] https://crrev.com/094a323437500847b4b5a95fddfd936039df1dd0/buildbucket/proto/buildset_test.go
[modify] https://crrev.com/094a323437500847b4b5a95fddfd936039df1dd0/luci_notify/notify/pubsub.go
[modify] https://crrev.com/094a323437500847b4b5a95fddfd936039df1dd0/luci_notify/notify/pubsub_test.go
[modify] https://crrev.com/094a323437500847b4b5a95fddfd936039df1dd0/milo/buildsource/buildbot/build.go
[modify] https://crrev.com/094a323437500847b4b5a95fddfd936039df1dd0/milo/buildsource/buildbot/buildstore/build.go
[modify] https://crrev.com/094a323437500847b4b5a95fddfd936039df1dd0/milo/buildsource/buildbot/buildstore/buildbucket.go
[modify] https://crrev.com/094a323437500847b4b5a95fddfd936039df1dd0/milo/buildsource/buildbucket/build.go
[modify] https://crrev.com/094a323437500847b4b5a95fddfd936039df1dd0/milo/buildsource/swarming/build.go
[modify] https://crrev.com/094a323437500847b4b5a95fddfd936039df1dd0/milo/common/model/build_summary.go
[modify] https://crrev.com/094a323437500847b4b5a95fddfd936039df1dd0/milo/frontend/ui/build.go
[modify] https://crrev.com/094a323437500847b4b5a95fddfd936039df1dd0/scheduler/appengine/engine/request.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/5bd2dd2b38c620cae7ffd93bdcbae01143170278

commit 5bd2dd2b38c620cae7ffd93bdcbae01143170278
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Mar 29 23:59:40 2018

[buildbucket] Move address functions to buildbucket/v1

The concept of build address does not propagate to v2, so move build address
functions to buildbucket v1.

R=hinoka@chromium.org, jchinlee@chromium.org

Bug: 826006
Change-Id: Ie71f41a937c00b19341c74c9a3fdb4f6658bfc93
Reviewed-on: https://chromium-review.googlesource.com/985908
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>

[modify] https://crrev.com/5bd2dd2b38c620cae7ffd93bdcbae01143170278/buildbucket/build.go
[add] https://crrev.com/5bd2dd2b38c620cae7ffd93bdcbae01143170278/common/api/buildbucket/buildbucket/v1/address.go
[add] https://crrev.com/5bd2dd2b38c620cae7ffd93bdcbae01143170278/common/api/buildbucket/buildbucket/v1/address_test.go
[modify] https://crrev.com/5bd2dd2b38c620cae7ffd93bdcbae01143170278/common/api/buildbucket/buildbucket/v1/buildbucket-gen.go
[modify] https://crrev.com/5bd2dd2b38c620cae7ffd93bdcbae01143170278/milo/buildsource/buildbot/buildstore/build.go
[modify] https://crrev.com/5bd2dd2b38c620cae7ffd93bdcbae01143170278/milo/common/model/build_summary.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/200f50b877f5a26095bc4f65b2909fab2d64cd0a

commit 200f50b877f5a26095bc4f65b2909fab2d64cd0a
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Mar 30 00:04:00 2018

[buildbucket] add duration functions to buildbucketpb.Build

Add RunDuration and SchedulingDuration functions consistent with
buildbucket.Build type, in preparation of replacing buildbucket.Build with
buildbucketpb.Build.

R=jchinlee@chromium.org

Bug: 826006
Change-Id: Ic3d2b4fa08a374fdd286bf11400e82bbb1641c6f
Reviewed-on: https://chromium-review.googlesource.com/986754
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[add] https://crrev.com/200f50b877f5a26095bc4f65b2909fab2d64cd0a/buildbucket/proto/build.go
[add] https://crrev.com/200f50b877f5a26095bc4f65b2909fab2d64cd0a/buildbucket/proto/build_test.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/9c64cb958f859db5273bdea6e6622b25c46fa4dd

commit 9c64cb958f859db5273bdea6e6622b25c46fa4dd
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Mar 30 00:09:30 2018

[buildbucke] Update Status proto consts

https://chromium.googlesource.com/infra/luci/luci-go/+/1acf8c3ab44f3fb83a41ecd5db2cc8e9290efc31/buildbucket/status.go#38
uses consts different from the values in the proto.

Update the proto to use the same values to make migration easier.

Bug: 826006
Change-Id: I4127d4e50c31737b5e052159cd0d908fdf3172c3
Reviewed-on: https://chromium-review.googlesource.com/985965
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/9c64cb958f859db5273bdea6e6622b25c46fa4dd/buildbucket/proto/common.pb.go
[modify] https://crrev.com/9c64cb958f859db5273bdea6e6622b25c46fa4dd/buildbucket/proto/common.proto

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/409f5b0a6860ed0d2fa83811de1abcf8d59fe588

commit 409f5b0a6860ed0d2fa83811de1abcf8d59fe588
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Mar 30 00:13:41 2018

[buildbucket] remove StatusTimeout

In v2 StatusTimeout is a part of StatusInfraFailure, so remove StatusTimeout
from buildbucket package. Nothing used it so far.

R=jchinlee@chromium.org

Bug: 826006
Change-Id: Id74ee10d83ab5b054ed2c04594c45dd8c5b2e904
Reviewed-on: https://chromium-review.googlesource.com/985970
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/409f5b0a6860ed0d2fa83811de1abcf8d59fe588/buildbucket/status.go
[modify] https://crrev.com/409f5b0a6860ed0d2fa83811de1abcf8d59fe588/buildbucket/status_test.go
[modify] https://crrev.com/409f5b0a6860ed0d2fa83811de1abcf8d59fe588/milo/buildsource/buildbot/buildstore/buildbucket.go
[modify] https://crrev.com/409f5b0a6860ed0d2fa83811de1abcf8d59fe588/milo/buildsource/buildbucket/common.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/3b8e04dbb6098bbb04f0dbb38f5684b3b8414188

commit 3b8e04dbb6098bbb04f0dbb38f5684b3b8414188
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Mar 30 00:18:50 2018

[buildbucket] rename Status consts

Using gorename tool, rename all Status consts to match ones in common.pb.go.

This CL is entirely made by the tool. No manual changes.

R=jchinlee@chromium.org

Bug: 826006
Change-Id: Id6a01e453fc09e40a3a768f1a0e92a6a1966af18
Reviewed-on: https://chromium-review.googlesource.com/986833
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/3b8e04dbb6098bbb04f0dbb38f5684b3b8414188/buildbucket/build_test.go
[modify] https://crrev.com/3b8e04dbb6098bbb04f0dbb38f5684b3b8414188/buildbucket/status.go
[modify] https://crrev.com/3b8e04dbb6098bbb04f0dbb38f5684b3b8414188/buildbucket/status_test.go
[modify] https://crrev.com/3b8e04dbb6098bbb04f0dbb38f5684b3b8414188/luci_notify/notify/notify.go
[modify] https://crrev.com/3b8e04dbb6098bbb04f0dbb38f5684b3b8414188/luci_notify/notify/notify_test.go
[modify] https://crrev.com/3b8e04dbb6098bbb04f0dbb38f5684b3b8414188/luci_notify/notify/pubsub_test.go
[modify] https://crrev.com/3b8e04dbb6098bbb04f0dbb38f5684b3b8414188/milo/buildsource/buildbot/buildstore/buildbucket.go
[modify] https://crrev.com/3b8e04dbb6098bbb04f0dbb38f5684b3b8414188/milo/buildsource/buildbucket/common.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/3a086d9300ba3154018aa700967710505467dd73

commit 3a086d9300ba3154018aa700967710505467dd73
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Mar 30 00:22:11 2018

[buildbucket] remove bulidbucket.Status

Remove buildbucket.Status in favor of buildbucketpb.Status.
Update all usages.

R=jchinlee@chromium.org

Bug: 826006
Change-Id: I5a614b4819188d4b13f15124f109cd91d0c67097
Reviewed-on: https://chromium-review.googlesource.com/986836
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/3a086d9300ba3154018aa700967710505467dd73/buildbucket/build.go
[modify] https://crrev.com/3a086d9300ba3154018aa700967710505467dd73/buildbucket/build_test.go
[add] https://crrev.com/3a086d9300ba3154018aa700967710505467dd73/buildbucket/proto/common.go
[modify] https://crrev.com/3a086d9300ba3154018aa700967710505467dd73/buildbucket/status.go
[modify] https://crrev.com/3a086d9300ba3154018aa700967710505467dd73/buildbucket/status_test.go
[modify] https://crrev.com/3a086d9300ba3154018aa700967710505467dd73/luci_notify/notify/builder.go
[modify] https://crrev.com/3a086d9300ba3154018aa700967710505467dd73/luci_notify/notify/notify.go
[modify] https://crrev.com/3a086d9300ba3154018aa700967710505467dd73/luci_notify/notify/notify_test.go
[modify] https://crrev.com/3a086d9300ba3154018aa700967710505467dd73/luci_notify/notify/pubsub_test.go
[modify] https://crrev.com/3a086d9300ba3154018aa700967710505467dd73/luci_notify/testutil/data.go
[modify] https://crrev.com/3a086d9300ba3154018aa700967710505467dd73/milo/buildsource/buildbot/buildstore/buildbucket.go
[modify] https://crrev.com/3a086d9300ba3154018aa700967710505467dd73/milo/buildsource/buildbucket/common.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/a80429e9382123542363f0ed1c572533a3f82367

commit a80429e9382123542363f0ed1c572533a3f82367
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Mar 30 00:25:11 2018

[buildbucket] remove CanaryPreference

Remove CanaryPreference to simplify migration to protos that don't have it
yet. Nothing uses CanaryPreference type.

R=tandrii@chromium.org

Bug: 826006
Change-Id: I512d7d1446cd5cc84007c39762419cf2e13efbb2
Reviewed-on: https://chromium-review.googlesource.com/986876
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/a80429e9382123542363f0ed1c572533a3f82367/buildbucket/build.go
[modify] https://crrev.com/a80429e9382123542363f0ed1c572533a3f82367/buildbucket/build_test.go
[delete] https://crrev.com/3a086d9300ba3154018aa700967710505467dd73/buildbucket/canary.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/9554026b0da88230ebd377e65725d5f2d89b75ca

commit 9554026b0da88230ebd377e65725d5f2d89b75ca
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Mar 30 00:27:50 2018

[buildbucket] Rename BuildSet() to BuildSetString()

Automatic change using gorename.

R=tandrii@chromium.org

Bug: 826006
Change-Id: Idc628352f50e2fd7a29dafc9d00b0226a9ab4377
Reviewed-on: https://chromium-review.googlesource.com/986914
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/9554026b0da88230ebd377e65725d5f2d89b75ca/buildbucket/build.go
[modify] https://crrev.com/9554026b0da88230ebd377e65725d5f2d89b75ca/buildbucket/proto/buildset.go
[modify] https://crrev.com/9554026b0da88230ebd377e65725d5f2d89b75ca/buildbucket/proto/buildset_test.go
[modify] https://crrev.com/9554026b0da88230ebd377e65725d5f2d89b75ca/milo/buildsource/buildbot/buildstore/build.go
[modify] https://crrev.com/9554026b0da88230ebd377e65725d5f2d89b75ca/milo/common/model/build_summary.go
[modify] https://crrev.com/9554026b0da88230ebd377e65725d5f2d89b75ca/scheduler/appengine/engine/request.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/679a4e4ff9c5615bcd147a008e600c968e903139

commit 679a4e4ff9c5615bcd147a008e600c968e903139
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Mar 30 19:45:44 2018

[buildbucket] use bbv1 alias for buildbucket/v1 package

Update all imports of common/api/buildbucket/buildbucket/v1 to use bbv1 alias,
except those in buildbucket package.

R=tandrii@chromium.org

Bug: 826006
Change-Id: I3a3f1fbaa79fd71adf1e300b9c7d6a78ec333ac5
Reviewed-on: https://chromium-review.googlesource.com/987537
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/679a4e4ff9c5615bcd147a008e600c968e903139/luci_notify/notify/pubsub.go
[modify] https://crrev.com/679a4e4ff9c5615bcd147a008e600c968e903139/milo/buildsource/buildbot/buildstore/build.go
[modify] https://crrev.com/679a4e4ff9c5615bcd147a008e600c968e903139/milo/buildsource/buildbot/buildstore/buildbucket.go
[modify] https://crrev.com/679a4e4ff9c5615bcd147a008e600c968e903139/milo/buildsource/buildbot/buildstore/query.go
[modify] https://crrev.com/679a4e4ff9c5615bcd147a008e600c968e903139/milo/buildsource/buildbucket/build.go
[modify] https://crrev.com/679a4e4ff9c5615bcd147a008e600c968e903139/milo/buildsource/buildbucket/builder.go
[modify] https://crrev.com/679a4e4ff9c5615bcd147a008e600c968e903139/milo/buildsource/buildbucket/common.go
[modify] https://crrev.com/679a4e4ff9c5615bcd147a008e600c968e903139/milo/buildsource/buildbucket/pubsub.go
[modify] https://crrev.com/679a4e4ff9c5615bcd147a008e600c968e903139/milo/buildsource/buildbucket/pubsub_test.go
[modify] https://crrev.com/679a4e4ff9c5615bcd147a008e600c968e903139/milo/common/model/build_summary.go
[modify] https://crrev.com/679a4e4ff9c5615bcd147a008e600c968e903139/scheduler/appengine/task/buildbucket/buildbucket.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d53007cc82a432a63252779596f67ab93050efa1

commit d53007cc82a432a63252779596f67ab93050efa1
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Mar 30 21:51:35 2018

Roll infra/go/src/go.chromium.org/luci/ 1acf8c3ab..9554026b0 (25 commits)

Roll luci-go to 9554026b0 and update luci-migration with respect to breaking
changes in buildbucket package. Also change package alias bbapi to bbv1.

The rest of the CL description was generated by roll-dep

https://chromium.googlesource.com/infra/luci/luci-go/+log/1acf8c3ab44f..9554026b0da8

$ git log 1acf8c3ab..9554026b0 --date=short --no-merges --format='%ad %ae %s'
2018-03-29 nodir [buildbucket] Rename BuildSet() to BuildSetString()
2018-03-29 nodir [buildbucket] remove CanaryPreference
2018-03-29 nodir [buildbucket] remove bulidbucket.Status
2018-03-29 nodir [buildbucket] rename Status consts
2018-03-29 nodir [buildbucket] remove StatusTimeout
2018-03-29 nodir [buildbucke] Update Status proto consts
2018-03-29 nodir [buildbucket] add duration functions to buildbucketpb.Build
2018-03-29 nodir [buildbucket] Move address functions to buildbucket/v1
2018-03-28 nodir [buildbucket] use protos as bulidset types
2018-03-28 nodir [buildbucket] Refactor buildset types
2018-03-28 nodir [buildbucket] move Timestamp functions to v1
2018-03-28 nodir [buildbucket] remove Rietveld support
2018-03-28 nodir [buildbucket] move tag consts to v1
2018-03-28 nodir [buildbucket] add initial protos
2018-03-28 smut [Machine Database] Allow racks to specify a KVM in the config
2018-03-28 nodir [buildbucket] use v1 package alias
2018-03-23 smut [Machine Database] Record cidr block info in vlans table
2018-03-22 smut [Machine Database] Add KVM config, schema
2018-03-23 smut [Machine Database] Report pRPC tsmon metrics
2018-03-22 vadimsh [cipd] Add NormalizePrefixMetadata function that normalizes PrefixMetadata proto.
2018-03-22 vadimsh [cipd] Clarify some edge cases in UpdatePrefixMetadata doc.
2018-03-22 vadimsh [cipd] Get rid of cipd/appengine/impl/common.
2018-03-22 hinoka [milo] Use text labels instead of link labels for title
2018-03-22 hinoka [milo] Update go generated artifacts
2018-03-22 smut [Machine Database] Update proto comments, document field requirements

Created with:
  roll-dep infra/go/src/go.chromium.org/luci

R=tandrii@cheromium.org
Bug: 826006

Change-Id: Id845826f738fc795f12019cff8d5c239db5f3651
Reviewed-on: https://chromium-review.googlesource.com/987534
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/d53007cc82a432a63252779596f67ab93050efa1/go/src/infra/appengine/luci-migration/analysis/group.go
[modify] https://crrev.com/d53007cc82a432a63252779596f67ab93050efa1/go/src/infra/appengine/luci-migration/scheduling/scheduling_test.go
[modify] https://crrev.com/d53007cc82a432a63252779596f67ab93050efa1/go/src/infra/appengine/luci-migration/analysis/tryjobs_test.go
[modify] https://crrev.com/d53007cc82a432a63252779596f67ab93050efa1/go/src/infra/appengine/luci-migration/analysis/tryjobs.go
[modify] https://crrev.com/d53007cc82a432a63252779596f67ab93050efa1/go/src/infra/appengine/luci-migration/analysis/group_test.go
[modify] https://crrev.com/d53007cc82a432a63252779596f67ab93050efa1/DEPS
[modify] https://crrev.com/d53007cc82a432a63252779596f67ab93050efa1/go/src/infra/appengine/luci-migration/scheduling/scheduling.go
[modify] https://crrev.com/d53007cc82a432a63252779596f67ab93050efa1/go/src/infra/appengine/luci-migration/analysis/compare_test.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/35caf7a36bc28d348a3d52e1c2ad571ce973e2ac

commit 35caf7a36bc28d348a3d52e1c2ad571ce973e2ac
Author: Nodir Turakulov <nodir@google.com>
Date: Mon Apr 02 19:29:10 2018

[buildbucket] add V1->V2 functions

Add BuildToV2 and StatusToV2 functions that convert v1 build/status to v2
formats.

Deprecate buildbucket.Build in favor of v2 Build proto message.
Clients will be updated gradually.

R=tandrii@chromium.org

Bug: 826006
Change-Id: Ia4364a0813630794a8ca9c40ef08e3f08c24dd12
Reviewed-on: https://chromium-review.googlesource.com/987540
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/35caf7a36bc28d348a3d52e1c2ad571ce973e2ac/buildbucket/build.go
[modify] https://crrev.com/35caf7a36bc28d348a3d52e1c2ad571ce973e2ac/buildbucket/proto/build.go
[delete] https://crrev.com/7f077ba3badcf40171f7eeee078d7f355d22cea5/buildbucket/status.go
[delete] https://crrev.com/7f077ba3badcf40171f7eeee078d7f355d22cea5/buildbucket/status_test.go
[add] https://crrev.com/35caf7a36bc28d348a3d52e1c2ad571ce973e2ac/buildbucket/testdata/v1_builds.json
[add] https://crrev.com/35caf7a36bc28d348a3d52e1c2ad571ce973e2ac/buildbucket/testdata/v2_builds.json
[add] https://crrev.com/35caf7a36bc28d348a3d52e1c2ad571ce973e2ac/buildbucket/v1.go
[add] https://crrev.com/35caf7a36bc28d348a3d52e1c2ad571ce973e2ac/buildbucket/v1_test.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/36d676932f25f157bd1724248372630c594db141

commit 36d676932f25f157bd1724248372630c594db141
Author: Nodir Turakulov <nodir@google.com>
Date: Mon Apr 02 19:38:00 2018

[luci-notify] Migrate to buildbucket.v2 proto.

Migrate from buildbucket.Build to buildbucketpb.Build.

This CL has a breaking change: Builder entity ID changes from
"buildbucket/luci.{project}.{bucket-suffix}/{builder}"
to
"buildbucket/{project}/{bucket-suffix}/{builder}"
However, the worst implication is an extra email per builder if status of the
builder changes (success->failure, or vice-versa) at the moment of migration.
This risk is acceptable.

Bug: 826006

Change-Id: If3489e316b28bd7f00b78c842bee03d4602cbdd6
Reviewed-on: https://chromium-review.googlesource.com/987547
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>

[add] https://crrev.com/36d676932f25f157bd1724248372630c594db141/buildbucket/proto/builder.go
[modify] https://crrev.com/36d676932f25f157bd1724248372630c594db141/luci_notify/notify/builder.go
[modify] https://crrev.com/36d676932f25f157bd1724248372630c594db141/luci_notify/notify/notify.go
[modify] https://crrev.com/36d676932f25f157bd1724248372630c594db141/luci_notify/notify/pubsub.go
[modify] https://crrev.com/36d676932f25f157bd1724248372630c594db141/luci_notify/notify/pubsub_test.go
[modify] https://crrev.com/36d676932f25f157bd1724248372630c594db141/luci_notify/testutil/data.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/49eeeea89a95d53b132e9bcb026c0dc0e9f3794c

commit 49eeeea89a95d53b132e9bcb026c0dc0e9f3794c
Author: Nodir Turakulov <nodir@google.com>
Date: Mon Apr 02 20:16:00 2018

[buildbucket] add Build.Output.summary_markdown

add summary_markdown field to v2 Build.Output.
Update BuildToV2 to parse it from ui.info result detail.
Will be used in Milo.

R=hinoka@chromium.org

Bug: 826006
Change-Id: I3f00101ed95d69abcd315f4c074a46f4b212cb16
Reviewed-on: https://chromium-review.googlesource.com/990586
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/49eeeea89a95d53b132e9bcb026c0dc0e9f3794c/buildbucket/proto/build.pb.go
[modify] https://crrev.com/49eeeea89a95d53b132e9bcb026c0dc0e9f3794c/buildbucket/proto/build.proto
[modify] https://crrev.com/49eeeea89a95d53b132e9bcb026c0dc0e9f3794c/buildbucket/testdata/v1_builds.json
[modify] https://crrev.com/49eeeea89a95d53b132e9bcb026c0dc0e9f3794c/buildbucket/testdata/v2_builds.json
[modify] https://crrev.com/49eeeea89a95d53b132e9bcb026c0dc0e9f3794c/buildbucket/v1.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/d553b89e89a7b8f8f289c471dcede2d9298640c2

commit d553b89e89a7b8f8f289c471dcede2d9298640c2
Author: Nodir Turakulov <nodir@google.com>
Date: Mon Apr 02 21:01:20 2018

[buildbucket] support absence of project

When converting v1 build to v2, retreive project from luci.<project>.<suffix>
bucket, even if the build.project is empty

R=hinoka@chromium.org

Bug: 826006
Change-Id: Id7506c7f84f00db337018c9275164977622d8261
Reviewed-on: https://chromium-review.googlesource.com/990726
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/d553b89e89a7b8f8f289c471dcede2d9298640c2/buildbucket/testdata/v1_builds.json
[modify] https://crrev.com/d553b89e89a7b8f8f289c471dcede2d9298640c2/buildbucket/testdata/v2_builds.json
[modify] https://crrev.com/d553b89e89a7b8f8f289c471dcede2d9298640c2/buildbucket/v1.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/77fb0d870732e8c52f1834fd6d24034dc73d3fae

commit 77fb0d870732e8c52f1834fd6d24034dc73d3fae
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Apr 06 21:34:01 2018

[buildbucket] Update Status proto enum

"go.chromium.org/luci/buildbucket".Build type is being replaced with its proto
counterpart. The existing Go package used different numerical constants for
Status enums, so reuse them in the proto.

Note that today these protos are used only in BigQuery tables which persists
enums as strings, so changing tag values does not matter.

R=vadimsh@chromium.org

Bug: 826006
Change-Id: I226c681d2d20ef6081e4ddf8ae176def0cf316c9
Reviewed-on: https://chromium-review.googlesource.com/985964
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/77fb0d870732e8c52f1834fd6d24034dc73d3fae/appengine/cr-buildbucket/proto/common.proto
[modify] https://crrev.com/77fb0d870732e8c52f1834fd6d24034dc73d3fae/appengine/cr-buildbucket/proto/common_pb2.py

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/aba4ff76e83ad56c0c53c6bb3fddd6162bd3800d

commit aba4ff76e83ad56c0c53c6bb3fddd6162bd3800d
Author: Nodir Turakulov <nodir@google.com>
Date: Tue May 08 02:07:58 2018

[gerrit] Add GetChange to gerrit.proto

Add GetChange RPC with a minimal ChangeInfo message.

Bug: 826006
Change-Id: I73057fa552c23654dfea3322aa29b1547047853d
Reviewed-on: https://chromium-review.googlesource.com/1048628
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/aba4ff76e83ad56c0c53c6bb3fddd6162bd3800d/common/api/gerrit/gerrit.go
[modify] https://crrev.com/aba4ff76e83ad56c0c53c6bb3fddd6162bd3800d/common/api/gerrit/rest.go
[modify] https://crrev.com/aba4ff76e83ad56c0c53c6bb3fddd6162bd3800d/common/api/gerrit/rest_test.go
[modify] https://crrev.com/aba4ff76e83ad56c0c53c6bb3fddd6162bd3800d/common/proto/gerrit/gerrit.mock.pb.go
[modify] https://crrev.com/aba4ff76e83ad56c0c53c6bb3fddd6162bd3800d/common/proto/gerrit/gerrit.pb.go
[modify] https://crrev.com/aba4ff76e83ad56c0c53c6bb3fddd6162bd3800d/common/proto/gerrit/gerrit.proto
[modify] https://crrev.com/aba4ff76e83ad56c0c53c6bb3fddd6162bd3800d/common/proto/gerrit/pb.discovery.go
[modify] https://crrev.com/aba4ff76e83ad56c0c53c6bb3fddd6162bd3800d/common/proto/gerrit/validation.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/caaeb38237b6fe9b3aa3e5df66c99de523fab277

commit caaeb38237b6fe9b3aa3e5df66c99de523fab277
Author: Nodir Turakulov <nodir@google.com>
Date: Tue May 08 06:45:58 2018

[milo] load CL author email from Gerrit

Currently Milo loads build's CL author email from "changes" build parameter.
Use buildset and Gerrit RPC instead.

Bug: 826006
Change-Id: Iaed1cc3c16a4a799114ec599519f58faf3f6f969
Reviewed-on: https://chromium-review.googlesource.com/1048828
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/caaeb38237b6fe9b3aa3e5df66c99de523fab277/common/api/gerrit/rest.go
[modify] https://crrev.com/caaeb38237b6fe9b3aa3e5df66c99de523fab277/common/api/gitiles/common.go
[modify] https://crrev.com/caaeb38237b6fe9b3aa3e5df66c99de523fab277/milo/buildsource/buildbot/builder_test.go
[modify] https://crrev.com/caaeb38237b6fe9b3aa3e5df66c99de523fab277/milo/buildsource/buildbucket/build.go
[modify] https://crrev.com/caaeb38237b6fe9b3aa3e5df66c99de523fab277/milo/buildsource/buildbucket/builder_test.go
[modify] https://crrev.com/caaeb38237b6fe9b3aa3e5df66c99de523fab277/milo/buildsource/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.Swarming.json
[add] https://crrev.com/caaeb38237b6fe9b3aa3e5df66c99de523fab277/milo/common/gerrit.go
[modify] https://crrev.com/caaeb38237b6fe9b3aa3e5df66c99de523fab277/milo/frontend/middleware.go
[modify] https://crrev.com/caaeb38237b6fe9b3aa3e5df66c99de523fab277/milo/frontend/routes.go
[modify] https://crrev.com/caaeb38237b6fe9b3aa3e5df66c99de523fab277/milo/git/client.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fa6fb4a20b1c9eacc3b09464658940a91fe276d8

commit fa6fb4a20b1c9eacc3b09464658940a91fe276d8
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Jun 27 00:02:43 2018

[luci-migration] Don't use buildbucket.Build

buildbucket.Build is deprecated. It is being replaced with buildbucketpb.Build
which cannot be used by migration app because migration app inherently deals
with buildbot Builds. Inline buildbucket.Build into existing scheduling.Build
struct and reimplement migration app-specific build parsing.

Bug: 826006
Change-Id: I9bac8a58b8d7b6813cdf428d6db867ccb861a228
Reviewed-on: https://chromium-review.googlesource.com/1105383
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>

[modify] https://crrev.com/fa6fb4a20b1c9eacc3b09464658940a91fe276d8/go/src/infra/appengine/luci-migration/app/handlers.go
[modify] https://crrev.com/fa6fb4a20b1c9eacc3b09464658940a91fe276d8/go/src/infra/appengine/luci-migration/scheduling/scheduling_test.go
[modify] https://crrev.com/fa6fb4a20b1c9eacc3b09464658940a91fe276d8/go/src/infra/appengine/luci-migration/analysis/tryjobs.go
[modify] https://crrev.com/fa6fb4a20b1c9eacc3b09464658940a91fe276d8/go/src/infra/appengine/luci-migration/scheduling/scheduling.go

currently not working on this because the issue is blocked