Crash in ash::PowerButtonController::OnPowerButtonEvent |
||||||
Issue descriptionChrome OS:10452.27.0/ 66.0.3359.52 crash report:https://crash.corp.google.com/browse?stbtiq=1e5d435397d29ad9#0 Stack Quality99%Show frame trust levels 0x00005bc2708b73b7 (chrome -memory:2586 ) ash::PowerButtonController::OnPowerButtonEvent(bool, base::TimeTicks const&) 0x00005bc26ef0514b (chrome -power_manager_client.cc:873 ) chromeos::PowerManagerClientImpl::InputEventReceived(dbus::Signal*) 0x00005bc26ef8e7e8 (chrome -callback.h:124 ) dbus::ObjectProxy::RunMethod(base::TimeTicks, std::__1::vector<base::RepeatingCallback<void (dbus::Signal*)>, std::__1::allocator<base::RepeatingCallback<void (dbus::Signal*)> > >, dbus::Signal*) 0x00005bc26ef8f352 (chrome -bind_internal.h:447 ) base::internal::Invoker<base::internal::BindState<void (dbus::ObjectProxy::*)(base::TimeTicks, std::__1::vector<base::RepeatingCallback<void (dbus::Signal*)>, std::__1::allocator<base::RepeatingCallback<void (dbus::Signal*)> > >, dbus::Signal*), scoped_refptr<dbus::ObjectProxy>, base::TimeTicks, std::__1::vector<base::RepeatingCallback<void (dbus::Signal*)>, std::__1::allocator<base::RepeatingCallback<void (dbus::Signal*)> > >, dbus::Signal*>, void ()>::Run(base::internal::BindStateBase*) 0x00005bc26ba60c08 (chrome -callback.h:95 ) base::MessageLoop::RunTask(base::PendingTask*) 0x00005bc26ba62a04 (chrome -message_loop.cc:403 ) base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) 0x00005bc26e01db3f (chrome -run_loop.cc:130 ) ChromeBrowserMainParts::MainMessageLoopRun(int*) 0x00005bc26c6430c0 (chrome -browser_main_loop.cc:1052 ) content::BrowserMainLoop::RunMainMessageLoopParts() 0x00005bc26c645fd1 (chrome -browser_main_runner.cc:161 ) content::BrowserMainRunnerImpl::Run() 0x00005bc26c63b94d (chrome -browser_main.cc:46 ) content::BrowserMain(content::MainFunctionParams const&) 0x00005bc26e002ae6 (chrome -content_main_runner.cc:423 ) content::ContentMainRunnerImpl::Run() 0x00005bc26e00e793 (chrome -main.cc:453 ) service_manager::Main(service_manager::MainParams const&) 0x00005bc26bb5ecb8 (chrome -content_main.cc:19 ) ChromeMain 0x00007c2ce05b8735 (libc-2.23.so -libc-start.c:289 ) __libc_start_main 0x00005bc26bb53148 (chrome + 0x01092148 ) _start
,
Mar 26 2018
lock_state_controller_ will only be used in OnPowerButtonEvent for LEGACY power button (for chromebox currently). And that part is the old logic that I kept from previous logic.
,
Mar 26 2018
Oh, this crash happened in 66.0.3359.52? I changed a lot of the power button behavior in 67, I guess we may don't have this crash in 67?
,
Mar 26 2018
Ah, got it. I misread the commit history. It'll require looking at the 66 branch to figure out what's going on. :-/
,
Mar 26 2018
,
Mar 27 2018
FWIW I'm not seeing this crash signature with any frequency on crash/ If there's a significant rewrite in 67 it might be worth marking this "wontfix"
,
Mar 27 2018
Sorry, cors version is wrong at comment#0, as per the crash report it was reprod on M67. https://crash.corp.google.com/browse?stbtiq=1e5d435397d29ad9#0
,
Mar 27 2018
,
Mar 28 2018
Can I know which type of device did the crash happen?
,
Mar 28 2018
since I can not get enough info from the crash report currently.
,
Mar 28 2018
The crash report says eve
,
Apr 3 2018
Issue 828521 has been merged into this issue.
,
Apr 3 2018
,
Apr 3 2018
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4c343c8162f37198e4ccf5400dc5a0f7568e3df commit a4c343c8162f37198e4ccf5400dc5a0f7568e3df Author: Min Chen <minch@google.com> Date: Tue Apr 03 22:39:16 2018 Cancel menu showing animation only if menu is opened. Bug: 826005 Change-Id: I237dbf4ae50b02a225110fa72dc0bb0c0127535f Reviewed-on: https://chromium-review.googlesource.com/993755 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#547854} [modify] https://crrev.com/a4c343c8162f37198e4ccf5400dc5a0f7568e3df/ash/system/power/power_button_controller.cc
,
Apr 5 2018
Feel free to reopen it if the crash still happen. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by abodenha@chromium.org
, Mar 26 2018Labels: OS-Chrome
Owner: minch@chromium.org
Status: Assigned (was: Untriaged)