New issue
Advanced search Search tips

Issue 825996 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

RenderProcessHostTest.StopResetsVideoCaptureStreams is broken

Project Member Reported by emir...@chromium.org, Mar 26 2018

Issue description

This test currently passes by luck as it is missing EnablePixelOutput() call that is necessary to get proper pixel values out of <video>[0].

[0] https://cs.chromium.org/chromium/src/content/browser/webrtc/webrtc_content_browsertest_base.cc?rcl=f3ccd6a7f9d62f05a29d308385fb418f56190ed0&l=47
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8c707011e0b5014fc36d55d92dd09381053f42d

commit f8c707011e0b5014fc36d55d92dd09381053f42d
Author: Emircan Uysaler <emircan@chromium.org>
Date: Tue Mar 27 06:23:01 2018

Add pixel output for VideoCaptureStream usage in RenderProcessHostTest

These tests currently pass by luck as they are missing EnablePixelOutput() call
that is necessary to get proper pixel values out of <video>, that is necessary
for detecting events.

This CL adds a test class instance to setup these tests properly.

Bug:  825996 
Change-Id: I2b629d3d5fa8a3b038c101aa3aeed419cb5e04ff
Reviewed-on: https://chromium-review.googlesource.com/981401
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546038}
[modify] https://crrev.com/f8c707011e0b5014fc36d55d92dd09381053f42d/content/browser/renderer_host/render_process_host_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment