Submit to CQ button disappears intermittently |
||||
Issue descriptionHere is my typical workflow when submitting a patch. This happens every time, and I think it's a bug: 1. Get nits + LGTM from final reviewer ([Submit to CQ] visible) 2. Upload new changes to address nits ([Submit to CQ] visible) 3. Post comments saying that I addressed nits ([Submit to CQ] disappears) 4. Reload the page ([Submit to CQ] visible).
,
Mar 26 2018
,
Mar 27 2018
Ravi, is this a bug with AutoSubmit hiding things?
,
Mar 27 2018
Should not be because of https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior/+/master/src/main/resources/static/chromium-behavior.html#188 When you set a breakpoint in chromium-behavior.html for a chromium-review change it returns there. Locally I commented out PLUGIN.on('showchange', installAutoSubmit); and still see the behavior of CQ button disappearing whenever you post a comment via the reply dialog.
,
Mar 27 2018
Well damn, yeah, I see it too now. That's wild. Unassigning from Ravi since it isn't autosubmit. Not sure what the root cause is yet, though. |
||||
►
Sign in to add a comment |
||||
Comment 1 by logan@google.com
, Mar 26 2018