Similar problem with chrome://crashes/ - dedicated bug in https://bugs.chromium.org/p/chromium/issues/detail?id=825994
Similar problem with chrome://device-log/

chrome://flash/ appears to have a similar problem.

chrome://gpu/ might have a similar issue; need to check more closely to verify.

Back to the main issue - chrome://webrtc-logs:
* I'm going to make a simple fix first, which I'll try to merge into M66.
* I'll later elaborate on it in M67, where I'll do the general refactoring I was about to do there, to support both textual as well as event logs. If time permits, I will move things away from keeping this information in a dedicated file. (The logs themselves still in their own files, but the log-of-logs, which doesn't get cleared, out of its own file.)

+dullweber@, who knows things about the browsing data remover, and would be a good person to ask for a code review.

No need, I am just about to upload the CL.

Sorry, I was too vague - I can add him as a reviewer, sure, but the bug is not actually in forgetting to remove the data, but in doing it incorrectly. It is inside of components/webrtc_logging/browser/log_cleanup.cc. I have also found some other problems in that file, but I'll treat them separately.

Thanks for finding these issues! All of these pages should definitely be clearable. If they retain data across restarts, they should also expire after some weeks unless there is a very good reason to keep them (crashes/, webrtc-logs/).

It looks like the issue with webrtc is not a recent regression so I don't think you need to worry about M66 as it is already in beta.

* Since the CL for the fix is up, I wonder if I should remove the restricting label?
* chrome://webrtc-logs and chrome://crashes have their own bugs. I'll open bugs for the other three as well. Mike, do you have specific assignees in mind, or shall I leave it up to triagers / my own judgement?
* How far along is M66? I was hoping to merge into it. The fix is rather simple. Should we not try?

M66 stable cut is on April 12. I think the general approach is that only recent regression and big security issues are merged late. The relevant documentation is probably this: https://www.chromium.org/developers/the-zen-of-merge-requests

I don't think the restriction label is required as this is not a security issue. Only someone who already has access to your pc can take advantage of it.

Thanks for creating the bugs! I can't help you with assignees but please CC me and tag them as Privacy issues, so we can keep track.

Thanks, dullweber@, for explaining. I'll not attempt to merge to M66, then.

Additional side-quest bugs spawned:
* chrome://device-log/ - https://bugs.chromium.org/p/chromium/issues/detail?id=826490
* chrome://flash/ - https://bugs.chromium.org/p/chromium/issues/detail?id=826491

dullweber@ - I've CCed you and applied the Hotlist-Privacy label.

Could someone with more seniority here than me approve removing the Restrict-View-Google label from this bug? :-)

The fix is here - https://chromium-review.googlesource.com/c/chromium/src/+/982055.
grunell@ is OOO until April 3rd, but if any owner can review before, I am available to land it before.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a4532d1fcc12e05f02486d8e8314220ce1947e3

commit 4a4532d1fcc12e05f02486d8e8314220ce1947e3
Author: Elad Alon <eladalon@chromium.org>
Date: Thu Apr 05 16:59:05 2018

Fix removal of old entries from chrome://webrtc-logs

When WebRTC textual log files are deleted, either because of
expiration or because the user clears browsing history,
entries from the logs' index are now also removed.

As a drive-by:
* Fixed the unbounded reading of a file into memory.
* Marked with TODOs (and filed bugs) for several other
  problems found.

Bug:  825977 ,  827131 
Change-Id: If34acf6290ec90c3ce99c0704c58bc8a8188f92d
Reviewed-on: https://chromium-review.googlesource.com/982055
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548455}
[modify] https://crrev.com/4a4532d1fcc12e05f02486d8e8314220ce1947e3/components/webrtc_logging/browser/log_cleanup.cc
[modify] https://crrev.com/4a4532d1fcc12e05f02486d8e8314220ce1947e3/components/webrtc_logging/browser/log_cleanup.h
[modify] https://crrev.com/4a4532d1fcc12e05f02486d8e8314220ce1947e3/components/webrtc_logging/browser/log_cleanup_unittest.cc