New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 825973 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Roll ChromiumOS FreeType to 26ad1acbcb4ca9e25163bd102971c8f0e1b56d87

Project Member Reported by bunge...@chromium.org, Mar 26 2018

Issue description

Chromium is rolling FreeType to 61ee69a66e73f33a955d263bcb4d40e62dfe6286 at https://chromium-review.googlesource.com/c/chromium/src/+/980694 . Note that this will require a build change since ftfntfmt.c and ftlcdfil.c have been pulled into ftbase.c.

 

Comment 1 by js...@chromium.org, Mar 26 2018

Labels: -Pri-3 M-67 Pri-2
Status: Assigned (was: Untriaged)
Thank you for the alert. I'll update it.  

Do you expect to make more updates before the branch cut-off for 67?  

Well, I think Chrome OS had better just use bundled FT and HB before long. That way, it can benefit from auto-hinting (that is only possible when FT and HB are built together to depend on each other).  
We just got a few fixes in for format 2 character maps and for bitmap fonts, which is most of the reason for this roll. I don't expect to need to roll again in the next week or so, unless something interesting comes up.
Summary: Roll ChromiumOS FreeType to 26ad1acbcb4ca9e25163bd102971c8f0e1b56d87 (was: Roll ChromiumOS FreeType to 61ee69a66e73f33a955d263bcb4d40e62dfe6286)
So something did come up (something always comes up) and we're rolling Chromium's FreeType to 26ad1acbcb4ca9e25163bd102971c8f0e1b56d87 . Details about that at https://chromium-review.googlesource.com/c/chromium/src/+/995918 .

Comment 4 by js...@chromium.org, Apr 9 2018

Thanks. The issue in the latest roll is not likely to affect Chrome OS, but I'll just go with the rest of Chrome. 


Comment 5 by js...@chromium.org, Apr 12 2018

I'm taking 3 CLs more (up to 4a03f17) because they handle 3 issues discovered by oss-fuzzer. 

Ok, but note that Chromium is now on 26ad1acbcb4ca9e25163bd102971c8f0e1b56d87 which is a number of commits after 4a03f17 .

Comment 7 by js...@chromium.org, Apr 13 2018

Oops. I meant:  bd9400bd464  (which is 3 commits past 26ad1acb). 


Comment 9 by js...@chromium.org, Apr 13 2018

Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d9ec3d37c04be41a6159648bd761b8f39d7d5e62

commit d9ec3d37c04be41a6159648bd761b8f39d7d5e62
Author: Jungshik Shin <jshin@chromium.org>
Date: Sat Apr 14 01:45:38 2018

Update FreeType to bd9400b (2.9 + 49 CLs)

This is to match the version of FreeType to that on other platforms for 67
branch. It takes 3 more latest CLs from the upstream to resolve issues
identified by oss-fuzzer.

BUG= chromium:825973 
TEST=1. emerge-<board> freetype 2. cros deploy <device> freetype
Change-Id: I6306f988df836591679139d4d8a00c5caa52d25f
Reviewed-on: https://chromium-review.googlesource.com/1011664
Commit-Ready: Jungshik Shin <jshin@chromium.org>
Tested-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[add] https://crrev.com/d9ec3d37c04be41a6159648bd761b8f39d7d5e62/media-libs/freetype/files/freetype-2.9-bd9400b.patch
[rename] https://crrev.com/d9ec3d37c04be41a6159648bd761b8f39d7d5e62/media-libs/freetype/freetype-2.9-r2.ebuild
[delete] https://crrev.com/48730c27a95bca0c8c9e90f425d8e70a57590170/media-libs/freetype/files/freetype-2.9-4a03f17.patch
[modify] https://crrev.com/d9ec3d37c04be41a6159648bd761b8f39d7d5e62/media-libs/freetype/freetype-2.9.ebuild

Status: Fixed (was: Started)
This appears to be fixed now, so I'm closing (about to open a new issue to track rolling FreeType in ChromeOS).

Comment 12 by js...@chromium.org, Apr 24 2018

Labels: Merge-Request-67
Missed M67 branch cut by a couple of days. To match FreeType version on other platforms, we need to merge this to M67 branch on CrOS. 

Other platforms including Linux has been using this version of FreeType in 67 branch. So, it should be safe. Also, CrOS canary/dev builds have been out with this revision. 


Labels: -Merge-Request-67 Merge-Approved-67
Approving merge to M67 Chrome OS.

Project Member

Comment 14 by sheriffbot@chromium.org, Apr 30 2018

Cc: kbleicher@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 15 by sheriffbot@chromium.org, May 4 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment