MacViews: reduce height of titlebar in full-screen |
|||||||
Issue descriptionThis was previously implemented in https://chromium-review.googlesource.com/c/chromium/src/+/912628 but that method caused Issue 824757
,
Mar 29 2018
** Bulk Edit ** FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.
,
Apr 25 2018
Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.
,
Jun 20 2018
,
Jul 12
,
Jul 12
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7d78be694eb9d2c623ec19776f3457b3dec0049 commit c7d78be694eb9d2c623ec19776f3457b3dec0049 Author: Wei Li <weili@chromium.org> Date: Thu Jul 12 21:27:41 2018 [MacViews] Reduce the height of title bar in fullscreen In fullscreen mode, the height of the title bar should be as regular size, not as the regular tab strip height. We can not create a new class for fullscreen since that will trigger an NSThemeFrame assert error in reacquireToolbarViewFromFullScreenWindowAndShow(); we can not directly check styleMask in _titleHeight() function because that may not reflect its fullscreen status. This CL introduces a variable and records its fullscreen status in setStyleMask(). The title bar height is decided based on that variable. BUG= 825968 ,831219 Change-Id: I2e827e31f6e7769344584e2ff9ddd5c4efedc419 Reviewed-on: https://chromium-review.googlesource.com/1132135 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Sidney San MartÃn <sdy@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#574726} [modify] https://crrev.com/c7d78be694eb9d2c623ec19776f3457b3dec0049/chrome/browser/ui/views/frame/browser_native_widget_window_mac.mm
,
Jul 16
Tested this issue on build without fix 67.0.3379.0 using Mac 10.12.6 and on the latest chrome version 69.0.3493.0. Steps: --------- 1. Launched Chrome 2. Enabled full screen mode We have Observed that "Window size same in both versions" @Reporter: Please find the attached screen-cast and let us know if we have missed anything in the process. Could you please help in verifying the fix. Thanks..!
,
Jul 16
Re. #8, this only affects MacViews, and only content fullscreen. See attached screen recording. Before this change, the title bar which appeared was much taller.
,
Jul 16
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ellyjo...@chromium.org
, Mar 29 2018