We need a bottom toolbar that is persistently on-screen (resizing the viewport) and scrolls off synchronized with the top toolbar.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ada9880c6a28df2ce68745a9c3370a6def4a01b commit 3ada9880c6a28df2ce68745a9c3370a6def4a01b Author: Matthew Jones <mdjones@chromium.org> Date: Fri Mar 30 23:05:52 2018 onSheetOffsetChanged now sends events for states less than peek Bottom sheet now sends offset change events for all height changes. This includes hidden to peeking and offset changes from the browser controls. Bug: 825965 Change-Id: I65842a7bf6e1d984f6f0f335368f49e8e0fde125 Reviewed-on: https://chromium-review.googlesource.com/986881 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#547306} [modify] https://crrev.com/3ada9880c6a28df2ce68745a9c3370a6def4a01b/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java [modify] https://crrev.com/3ada9880c6a28df2ce68745a9c3370a6def4a01b/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetObserver.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94de8546524bb95b385f7eb8a96b140fc0fc3c0d commit 94de8546524bb95b385f7eb8a96b140fc0fc3c0d Author: Matthew Jones <mdjones@chromium.org> Date: Thu Apr 05 15:42:56 2018 Implement simple bottom toolbar with MVC framework This change implements a simple bottom toolbar that has an android view, a composited component, resizes the viewport, and scrolls on and off-screen. This toolbar is implemented using the new MVC guidelines: - The BottomToolbarController sets up all the components of the bottom toolbar. - The BottomToolbarMediator is responsible for pushing updates to the model and running most of the business logic. - The BottomToolbarModel is a blob of state with no actual business logic. - The BottomToolbarViewBinder reacts to events from a PropertyModelChangeProcessor and updates the relevant views. BUG= 815324 , 825965 Change-Id: I75e5aac6a2bb2a21ea9e4010fc81076d2d39da8b Reviewed-on: https://chromium-review.googlesource.com/980577 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#548436} [add] https://crrev.com/94de8546524bb95b385f7eb8a96b140fc0fc3c0d/chrome/android/java/res/layout/bottom_toolbar.xml [modify] https://crrev.com/94de8546524bb95b385f7eb8a96b140fc0fc3c0d/chrome/android/java/res/layout/main.xml [modify] https://crrev.com/94de8546524bb95b385f7eb8a96b140fc0fc3c0d/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/94de8546524bb95b385f7eb8a96b140fc0fc3c0d/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java [modify] https://crrev.com/94de8546524bb95b385f7eb8a96b140fc0fc3c0d/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java [modify] https://crrev.com/94de8546524bb95b385f7eb8a96b140fc0fc3c0d/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ScrollingBottomViewSceneLayer.java [add] https://crrev.com/94de8546524bb95b385f7eb8a96b140fc0fc3c0d/chrome/android/java/src/org/chromium/chrome/browser/modelutil/PropertyModelChangeProcessor.java [add] https://crrev.com/94de8546524bb95b385f7eb8a96b140fc0fc3c0d/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarController.java [add] https://crrev.com/94de8546524bb95b385f7eb8a96b140fc0fc3c0d/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarMediator.java [add] https://crrev.com/94de8546524bb95b385f7eb8a96b140fc0fc3c0d/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarModel.java [add] https://crrev.com/94de8546524bb95b385f7eb8a96b140fc0fc3c0d/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarViewBinder.java [add] https://crrev.com/94de8546524bb95b385f7eb8a96b140fc0fc3c0d/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ScrollingBottomViewResourceFrameLayout.java [modify] https://crrev.com/94de8546524bb95b385f7eb8a96b140fc0fc3c0d/chrome/android/java_sources.gni
Comment 1 by bugdroid1@chromium.org
, Mar 30 2018