New issue
Advanced search Search tips

Issue 825958 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Create an autotest for the UrlBase manual test

Project Member Reported by dhadd...@chromium.org, Mar 26 2018

Issue description

Section 13 of the AU manual test cases has just one test case:
https://testtracker.googleplex.com/testplans/testcase/detail/906000?id=450&revision=125

I will create an autotest for this to remove the need for us to it manually. And it will give us much greater coverage than we have ever had
 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ff0aba913a88f985f4e8c5196efe95c6a51d2eff

commit ff0aba913a88f985f4e8c5196efe95c6a51d2eff
Author: David Haddock <dhaddock@chromium.org>
Date: Tue Apr 03 05:42:58 2018

Add a base class for update engine client tests.

We have one already for server tests but I now need to share info
between some of the client tests too. This is in preparation for an
upcoming cl testing the UrlBase parameter in omaha responses.

I have moved the cleanup (collection of logs) to the base class.
I have added some common strings (log location etc) too.

BUG= chromium:825958 
TEST=autoupdate_ForcedOOBEUpdate.interrupt.full still passes

Change-Id: Ieb73d10b79f8dd064b487449bee54b5acc424c38
Reviewed-on: https://chromium-review.googlesource.com/985093
Commit-Ready: David Haddock <dhaddock@chromium.org>
Tested-by: David Haddock <dhaddock@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

[add] https://crrev.com/ff0aba913a88f985f4e8c5196efe95c6a51d2eff/client/cros/update_engine/update_engine_test.py
[modify] https://crrev.com/ff0aba913a88f985f4e8c5196efe95c6a51d2eff/client/site_tests/autoupdate_DisconnectReconnectNetwork/autoupdate_DisconnectReconnectNetwork.py
[modify] https://crrev.com/ff0aba913a88f985f4e8c5196efe95c6a51d2eff/client/site_tests/autoupdate_StartOOBEUpdate/autoupdate_StartOOBEUpdate.py

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8a613a62e7d51bd0039355ddeda3e3523a27acc5

commit 8a613a62e7d51bd0039355ddeda3e3523a27acc5
Author: David Haddock <dhaddock@chromium.org>
Date: Tue Apr 03 05:43:04 2018

Test that we continue with second URL when first fails.

This is an automated test to replace the manual execution of this test:
https://testtracker.googleplex.com/testplans/testcase/detail/906000?id=450

I've addd a server test which gets the current payload to use for the
build the test is running on. This class will be used by all tests that
are testing something in the omaha response (e.g Two UrlBase lines,
bad MetaDatasize, bad SHA256 etc)

The client test does all of the functionality testing.

I have also updated our nano omaha devserver to switch to the other url
after one failure.

BUG= chromium:825958 
TEST=autoupdate_OmahaResponse.url_switch.full
TEST=autoupdate_OmahaResponse.local

Change-Id: I37485dd54eb5c4d714309056b281c0cd702fa595
Reviewed-on: https://chromium-review.googlesource.com/985136
Commit-Ready: David Haddock <dhaddock@chromium.org>
Tested-by: David Haddock <dhaddock@chromium.org>
Reviewed-by: David Haddock <dhaddock@chromium.org>

[modify] https://crrev.com/8a613a62e7d51bd0039355ddeda3e3523a27acc5/server/cros/update_engine/update_engine_test.py
[add] https://crrev.com/8a613a62e7d51bd0039355ddeda3e3523a27acc5/client/site_tests/autoupdate_UrlSwitch/autoupdate_UrlSwitch.py
[add] https://crrev.com/8a613a62e7d51bd0039355ddeda3e3523a27acc5/server/site_tests/autoupdate_OmahaResponse/control.local
[add] https://crrev.com/8a613a62e7d51bd0039355ddeda3e3523a27acc5/server/site_tests/autoupdate_OmahaResponse/autoupdate_OmahaResponse.py
[modify] https://crrev.com/8a613a62e7d51bd0039355ddeda3e3523a27acc5/client/cros/update_engine/nano_omaha_devserver.py
[add] https://crrev.com/8a613a62e7d51bd0039355ddeda3e3523a27acc5/server/site_tests/autoupdate_OmahaResponse/control.url_switch.full
[add] https://crrev.com/8a613a62e7d51bd0039355ddeda3e3523a27acc5/client/site_tests/autoupdate_UrlSwitch/control

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment