Issue metadata
Sign in to add a comment
|
Android: PageInfo details link causes a crash. |
||||||||||||||||||||||||
Issue descriptionChrome crashes if Details link is clicked on a site where a certificate error was previously bypassed with the following output, looks like the failing assert is https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/page_info/ConnectionInfoPopup.java?rcl=66ca67fbbe552c4997956fc4ba14a5be96d9d751&l=157. Noticed this on 67.0.3380 03-26 10:35:22.439 2421 2421 W System.err: java.lang.AssertionError 03-26 10:35:22.439 2421 2421 W System.err: at org.chromium.chrome.browser.page_info.ConnectionInfoPopup.addResetCertDecisionsButton(ConnectionInfoPopup.java:157) 03-26 10:35:22.440 2421 2421 W System.err: at org.chromium.chrome.browser.page_info.ConnectionInfoPopup.nativeInit(Native Method) 03-26 10:35:22.440 2421 2421 W System.err: at org.chromium.chrome.browser.page_info.ConnectionInfoPopup.<init>(ConnectionInfoPopup.java:71) 03-26 10:35:22.440 2421 2421 W System.err: at org.chromium.chrome.browser.page_info.ConnectionInfoPopup.show(ConnectionInfoPopup.java:242) 03-26 10:35:22.440 2421 2421 W System.err: at org.chromium.chrome.browser.page_info.PageInfoPopup$9.run(PageInfoPopup.java:866) 03-26 10:35:22.440 2421 2421 W System.err: at android.os.Handler.handleCallback(Handler.java:790) 03-26 10:35:22.440 2421 2421 W System.err: at android.os.Handler.dispatchMessage(Handler.java:99) 03-26 10:35:22.440 2421 2421 W System.err: at android.os.Looper.loop(Looper.java:164) 03-26 10:35:22.440 2421 2421 W System.err: at android.app.ActivityThread.main(ActivityThread.java:6494) 03-26 10:35:22.440 2421 2421 W System.err: at java.lang.reflect.Method.invoke(Native Method) 03-26 10:35:22.440 2421 2421 W System.err: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438) 03-26 10:35:22.440 2421 2421 W System.err: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807) 03-26 10:35:22.485 2421 2421 F chromium: [FATAL:jni_android.cc(259)] Please include Java exception stack in crash report To reproduce: 1) Go to expired.badssl.com 2) Click through the interstitial. 3) Click on the red /!\ icon on the omnibox. 4) Click on the Details link in the pageinfo popup.
,
Mar 31 2018
,
Apr 18 2018
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4fecf9b4d42da42f8a80c0e9c8987e47dafcbda7 commit 4fecf9b4d42da42f8a80c0e9c8987e47dafcbda7 Author: Christopher Thompson <cthomp@chromium.org> Date: Thu Apr 26 19:01:27 2018 Remove invalid assert from ConnectionInfoPopup In the ConnectionInfoPopup shown from the "Details" link the Android PageInfoPopup, if a user has bypassed a certificate warning, the call to nativeInit() will call back into the Java addResetCertDecisionsButton() method before nativeInit() has returned and set the mNativeConnectionInfoPopup member. The assert in addResetCertDecisionsButton() would then always fail, causing a crash. This CL removes the assert, as none of the behavior of the method requires a handle to the native object. Bug: 825911 Change-Id: Ice75f5e416ed09efbc160e2de2e9541906430bf1 Reviewed-on: https://chromium-review.googlesource.com/1022070 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#554107} [modify] https://crrev.com/4fecf9b4d42da42f8a80c0e9c8987e47dafcbda7/chrome/android/java/src/org/chromium/chrome/browser/page_info/ConnectionInfoPopup.java
,
Apr 26 2018
,
May 3 2018
Verified in M68-68.0.3417.3 build
,
Jun 13 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by est...@chromium.org
, Mar 31 2018Labels: M-67
Status: Available (was: Untriaged)