New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 825910 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Project config streamlining: Remove project name

Project Member Reported by qyears...@chromium.org, Mar 26 2018

Issue description

Tricium project configs currently contain a name field, but this is not necessary. When requesting a list of project configs, they all come with the project name. When requesting one particular project config, the project name must already be known. Thus keeping project name in project config is superfluous.

Context:
https://chromium-review.googlesource.com/c/infra/infra/+/974543/2/go/src/infra/tricium/api/v1/config.proto#85

Step 1: Change poll to fetch project configs
Step 2: Remove field from all project configs
Step 3: Remove field from schema
 
Also related:

 - "kind" in RepoDetails could be removed. "if we ever have hg for example: oneof kind { GitRepoDetails git_details\n HGRepoDetails hg_details = 4 }"
 - If GerritDetails is given that could make GitDetails superfluous since it contains mostly the same information (git/gerrit host, project name)

Labels: Milestone
Owner: qyears...@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment