New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 825908 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
simonhatch@chromium.org
█ phoglund@chromium.org
eyaich@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Perf Dashboard - Migrate WebRTC rows that use webrtc_rev

Project Member Reported by simonhatch@chromium.org, Mar 26 2018 
Coming out of an email thread, it looks like both webrtc_git and webrtc_rev have been used to specify webrtc revisions in uploads, the latter is specified by the recipe.

The dashboard revision config only had entries for webrtc_git until recently, when I added one for webrtc_rev to get the revisions showing but we should only have 1 key instead of the 2. Proposal is to use webrtc_git going forward, since anybody who used that would have seen their revision data and anybody who used webrtc_rev would never had it work.

We can support both for now, but ideally we go back at some point and migrate the webrtc_rev -> webrtc_git and remove the entry from the revision config.

Comment 1 by eyaich@chromium.org, Mar 26 2018

Components: Speed>Benchmarks>Waterfall
From the recipe side it would be nice to be aligned on fields so we cut down on confusion in this area.  

https://cs.chromium.org/search/?q=%5C%27webrtc_rev%5C%27&sq=package:chromium&type=cs

These references need to be updated.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/249e88ec9a0b6e091cb05a11dd0ef22a56521601

commit 249e88ec9a0b6e091cb05a11dd0ef22a56521601
Author: Emily Hanley <eyaich@google.com>
Date: Tue Mar 27 13:42:58 2018

Updating webrtc_rev to what dashboard expects: webrtc_git

Bug: 825908
Change-Id: I51019116cbcd2ca8ca969efa77ce4ea93f90450a
Reviewed-on: https://chromium-review.googlesource.com/980669
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546096}
[modify] https://crrev.com/249e88ec9a0b6e091cb05a11dd0ef22a56521601/tools/perf/core/results_dashboard.py
[modify] https://crrev.com/249e88ec9a0b6e091cb05a11dd0ef22a56521601/tools/perf/core/upload_results_to_perf_dashboard.py
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/57fb1b70742233c8e7fd592aac35796e883ce1ba

commit 57fb1b70742233c8e7fd592aac35796e883ce1ba
Author: Emily Hanley <eyaich@google.com>
Date: Wed Mar 28 14:08:06 2018

Moving webrtc_rev to be webrtc_git

Bug:825908
Change-Id: I4bcfb7edb54dfb475473e5d018acad71f0110f8b
Reviewed-on: https://chromium-review.googlesource.com/980670
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@google.com>

[modify] https://crrev.com/57fb1b70742233c8e7fd592aac35796e883ce1ba/scripts/slave/unittests/data/artificial_graph-summary.dat
[modify] https://crrev.com/57fb1b70742233c8e7fd592aac35796e883ce1ba/scripts/slave/unittests/data/processes-summary.dat
[modify] https://crrev.com/57fb1b70742233c8e7fd592aac35796e883ce1ba/scripts/slave/unittests/data/hist1-summary.dat
[modify] https://crrev.com/57fb1b70742233c8e7fd592aac35796e883ce1ba/scripts/slave/performance_log_processor.py
[modify] https://crrev.com/57fb1b70742233c8e7fd592aac35796e883ce1ba/scripts/slave/unittests/data/hist1_0.3-summary.dat
[modify] https://crrev.com/57fb1b70742233c8e7fd592aac35796e883ce1ba/scripts/slave/unittests/data/hist1_0.8-summary.dat
[modify] https://crrev.com/57fb1b70742233c8e7fd592aac35796e883ce1ba/scripts/slave/results_dashboard.py
[modify] https://crrev.com/57fb1b70742233c8e7fd592aac35796e883ce1ba/scripts/slave/unittests/data/commit_charge-summary.dat
[modify] https://crrev.com/57fb1b70742233c8e7fd592aac35796e883ce1ba/scripts/slave/slave_utils.py
[modify] https://crrev.com/57fb1b70742233c8e7fd592aac35796e883ce1ba/scripts/slave/unittests/data/ws_final_total-summary.dat
[modify] https://crrev.com/57fb1b70742233c8e7fd592aac35796e883ce1ba/scripts/slave/unittests/data/hist1_0.05-summary.dat
[modify] https://crrev.com/57fb1b70742233c8e7fd592aac35796e883ce1ba/scripts/slave/unittests/data/vm_final_total-summary.dat
[modify] https://crrev.com/57fb1b70742233c8e7fd592aac35796e883ce1ba/scripts/slave/unittests/data/vm_final_browser-summary.dat
[modify] https://crrev.com/57fb1b70742233c8e7fd592aac35796e883ce1ba/scripts/slave/unittests/data/ws_final_browser-summary.dat

Comment 4 by eyaich@chromium.org, Mar 28 2018

Cc: simonhatch@chromium.org
This is officially migrated in the recipe so we should start seeing only webrtc_git.  At some point we should migrate the data in the dashboard.
►

Sign in to add a comment