New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 825905 link

Starred by 1 user
Status: Fixed
Owner:
█ jcivelli@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Change SubresourceLoadComplete() in frame.mojom to ResourceLoadComplete()

Project Member Reported by jcivelli@chromium.org, Mar 26 2018 
When Chrome runs with the network service, the task manager will track the network usage for a tab using WebContentsObserver methods.
So far it would use SubresourceLoadComplete(), but that does not include frame loads.
We should change that notification to include frame loads and rename it ResourceLoadComplete().
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/116683f52d941cc5acda35111f97b0f4d08bc79f

commit 116683f52d941cc5acda35111f97b0f4d08bc79f
Author: Jay Civelli <jcivelli@google.com>
Date: Tue Mar 27 19:56:23 2018

Change subresource loaded notifications

Making the subresource loaded notification in frame.mojom be for all
resources including frame resources.
This is going to be used by the task manager when the network service is
enabled to track network usage.

Bug:  825905 
Tbr: tsepez@chromium.org
Change-Id: I890d6c4103141a7e1d78e7cda015a750e62da380
Reviewed-on: https://chromium-review.googlesource.com/981080
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546216}
[modify] https://crrev.com/116683f52d941cc5acda35111f97b0f4d08bc79f/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/116683f52d941cc5acda35111f97b0f4d08bc79f/chrome/browser/safe_browsing/client_side_detection_host.h
[modify] https://crrev.com/116683f52d941cc5acda35111f97b0f4d08bc79f/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
[modify] https://crrev.com/116683f52d941cc5acda35111f97b0f4d08bc79f/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/116683f52d941cc5acda35111f97b0f4d08bc79f/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/116683f52d941cc5acda35111f97b0f4d08bc79f/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/116683f52d941cc5acda35111f97b0f4d08bc79f/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/116683f52d941cc5acda35111f97b0f4d08bc79f/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/116683f52d941cc5acda35111f97b0f4d08bc79f/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/116683f52d941cc5acda35111f97b0f4d08bc79f/content/common/frame.mojom
[modify] https://crrev.com/116683f52d941cc5acda35111f97b0f4d08bc79f/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/116683f52d941cc5acda35111f97b0f4d08bc79f/content/public/common/BUILD.gn
[rename] https://crrev.com/116683f52d941cc5acda35111f97b0f4d08bc79f/content/public/common/resource_load_info.mojom
[modify] https://crrev.com/116683f52d941cc5acda35111f97b0f4d08bc79f/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/116683f52d941cc5acda35111f97b0f4d08bc79f/content/test/test_render_frame.cc

Comment 2 by jcivelli@chromium.org, Mar 27 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment