New issue
Advanced search Search tips

Issue 825904 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Mac] Harmony session restore bubble doesn't update anchoring when fullscreened

Project Member Reported by lgrey@chromium.org, Mar 26 2018

Issue description

See attached image
 
Screen Shot 2018-03-26 at 1.30.07 PM.png
23.3 KB View Download
Status: Started (was: Available)
https://chromium-review.googlesource.com/c/chromium/src/+/981234
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83c3f7662808f7fb7e78f2ac7921280e54e82f59

commit 83c3f7662808f7fb7e78f2ac7921280e54e82f59
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Tue Mar 27 17:36:12 2018

views: anchor SessionCrashedBubbleView

This utility function makes the bubble stay anchored when fullscreening the
window. Most other chrome bubbles inherit from one of the extension or
location decoration bubble classes and therefore already have this behavior,
but SessionCrashedBubbleView is unusual.

Bug:  825904 
Change-Id: Ibc482f9f3f29de9e049b26770463f7e1d2a19c96
Reviewed-on: https://chromium-review.googlesource.com/981234
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546151}
[modify] https://crrev.com/83c3f7662808f7fb7e78f2ac7921280e54e82f59/chrome/browser/ui/views/session_crashed_bubble_view.cc

Status: Fixed (was: Started)
Labels: TE-Verified-M67 TE-Verified-67.0.3383.0
Able to reproduce the issue on chrome reported version 67.0.3381.0(without fix)
Verified the fix on Mac 10.12.6on Chrome version# 67.0.3383.0 as per the comment#0
Attaching screenshot for reference.
Observed "Able to see restore bubble anchoring correctly when fullscreened"
Hence, the fix is working as expected.
Adding the verified label.

Thanks!
825904.png
147 KB View Download

Sign in to add a comment