New issue
Advanced search Search tips

Issue 825901 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment

Support DrawRenderPass in SkiaRenderer with DDL

Project Member Reported by penghuang@chromium.org, Mar 26 2018

Issue description

Right now, SkiaRenderer may need render RenderPass into a SkSurface(backed by a texture), and then render the texture into the frame. We should figure how how to do it with DDL.
 
Blocking: 824382
Components: Internals>Services>Viz

Comment 2 by xing...@intel.com, Apr 24 2018

Cc: xing...@intel.com
Project Member

Comment 3 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a198ac253dcf6933f66855866e0d6f9ee63d7776

commit a198ac253dcf6933f66855866e0d6f9ee63d7776
Author: Peng Huang <penghuang@chromium.org>
Date: Tue May 08 18:05:21 2018

SkiaRenderer: fix a crash with SkDDL + RenderPass

Bug:  825901 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I83f7d79a3bf5a75945a9f3546468804249fe95a0
Reviewed-on: https://chromium-review.googlesource.com/1050365
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556872}
[modify] https://crrev.com/a198ac253dcf6933f66855866e0d6f9ee63d7776/components/viz/service/display/skia_renderer.cc

Blocking: 898270
Labels: vulkanize
Labels: -vulkanize Proj-Vulkanize
Blocking: 899750
Is this finished? I thought that render passes worked now?
Status: Fixed (was: Assigned)
It has been implemented.
Blocking: 644851

Sign in to add a comment